From patchwork Fri Apr 26 04:44:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 16414 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4FB3D23A42 for ; Fri, 26 Apr 2013 04:57:54 +0000 (UTC) Received: by mail-wi0-f198.google.com with SMTP id c10sf271618wiw.9 for ; Thu, 25 Apr 2013 21:56:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:x-beenthere:x-received:received-spf :x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=dR7OWwy8wX2RKIkZfohflJga4d95MpsZcGru1cGkVOs=; b=mRoAnttsjNvuO4F7eja470XcQesCE4ycxRwCnw8ka1JsCjJlbZJKF1uWTy/brsv+B9 vlz4BctdK8rCOkDOlTFLljvV12ALQN9BCrvcrFBaWN6cKzR1Xr9i0dt3FbF6axlWQ9wa pDy1n7wakDOjrXQPPTpqOVkjhhPWSDik3m40NM7batZZQLq+zsP4vnwqDY/nnXh+veN2 gRlbJrfCmbXnFUXYRuvRK1bM61qv/3X+LEf82ya69MvT8GBDV2FT3g70gVPUanJekfaL IhDsk61mVxChVfSGMjWxbtNrgyWAPdXaBzOu9IYweP8/p/Q0ltDTmyhGZors2kze75SG 1lbA== X-Received: by 10.180.75.7 with SMTP id y7mr644094wiv.0.1366952218063; Thu, 25 Apr 2013 21:56:58 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.180.98.166 with SMTP id ej6ls42148wib.7.canary; Thu, 25 Apr 2013 21:56:58 -0700 (PDT) X-Received: by 10.194.173.167 with SMTP id bl7mr79947104wjc.50.1366952217974; Thu, 25 Apr 2013 21:56:57 -0700 (PDT) Received: from mail-ve0-x232.google.com (mail-ve0-x232.google.com [2607:f8b0:400c:c01::232]) by mx.google.com with ESMTPS id kv3si3456172wjb.25.2013.04.25.21.56.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Apr 2013 21:56:57 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c01::232 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c01::232; Received: by mail-ve0-f178.google.com with SMTP id c13so1627814vea.23 for ; Thu, 25 Apr 2013 21:56:56 -0700 (PDT) X-Received: by 10.52.71.4 with SMTP id q4mr24030710vdu.8.1366952216730; Thu, 25 Apr 2013 21:56:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.127.98 with SMTP id nf2csp52144veb; Thu, 25 Apr 2013 21:56:56 -0700 (PDT) X-Received: by 10.68.178.165 with SMTP id cz5mr56086937pbc.214.1366952215750; Thu, 25 Apr 2013 21:56:55 -0700 (PDT) Received: from mail-pb0-x233.google.com (mail-pb0-x233.google.com [2607:f8b0:400e:c01::233]) by mx.google.com with ESMTPS id tu1si9528094pac.41.2013.04.25.21.56.55 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Apr 2013 21:56:55 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400e:c01::233 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=2607:f8b0:400e:c01::233; Received: by mail-pb0-f51.google.com with SMTP id rr4so1018090pbb.38 for ; Thu, 25 Apr 2013 21:56:55 -0700 (PDT) X-Received: by 10.66.122.42 with SMTP id lp10mr45500307pab.116.1366952215125; Thu, 25 Apr 2013 21:56:55 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id bs3sm10037667pbb.36.2013.04.25.21.56.51 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 25 Apr 2013 21:56:54 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] [media] exynos4-is: Fix potential null pointer dereference in mipi-csis.c Date: Fri, 26 Apr 2013 10:14:07 +0530 Message-Id: <1366951447-6202-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQnIP/FyECX9ekASAhJLo84VKBiQwpsPW5uc6aeXaw1fVqWY9I1T8E1n46M0Vj9ds5BEnt8T X-Original-Sender: sachin.kamat@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c01::232 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , When 'node' is NULL, the print statement tries to dereference it. Remove it from the error message. Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos4-is/mipi-csis.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c index a2eda9d..6ddc69f 100644 --- a/drivers/media/platform/exynos4-is/mipi-csis.c +++ b/drivers/media/platform/exynos4-is/mipi-csis.c @@ -745,8 +745,7 @@ static int s5pcsis_parse_dt(struct platform_device *pdev, node = v4l2_of_get_next_endpoint(node, NULL); if (!node) { - dev_err(&pdev->dev, "No port node at %s\n", - node->full_name); + dev_err(&pdev->dev, "Port node not available\n"); return -EINVAL; } /* Get port node and validate MIPI-CSI channel id. */