From patchwork Mon Nov 26 04:49:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 13186 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id D3FAA23EFB for ; Mon, 26 Nov 2012 04:55:37 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 97EA7A180E3 for ; Mon, 26 Nov 2012 04:55:37 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id c10so4033426ieb.11 for ; Sun, 25 Nov 2012 20:55:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=FqocQkvPGjegKbk4JJNDJhgAlgsuudn74fDIX86ZA6Q=; b=VT0j7gLRnba+LaI6hEtyH13i+pRqtHEkHp2qiUGmCKExp+RM5BRxTmVHDz/xQKJPX+ kTmereaDzhG6kPMWUU+C3zF6NSZLwZzqu4gNuNnoj/PzID+ZRi2kMutVlNWg80C8xqVz oc2DIdR/riCIkMmkjQ6hBzy4U9rD7QxEXpK4QTkR5nuQDce6s3r9H570eZZ/bQDHsaha F6a3ACzonlK7a357bDqTx+hLIMmqaWZ5GWK/l/X7mZR19EflKRghqPIluqeKAVxC23e4 LMSBFgZwc14Ig2z2QNLoKXsnLx0Ww6MgEUc1HlqfeT7Y2q93OARfr3TTmDfDUhUqJrE6 Seww== Received: by 10.43.125.133 with SMTP id gs5mr8763277icc.54.1353905737047; Sun, 25 Nov 2012 20:55:37 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp201118igt; Sun, 25 Nov 2012 20:55:36 -0800 (PST) Received: by 10.66.77.105 with SMTP id r9mr29357304paw.76.1353905736437; Sun, 25 Nov 2012 20:55:36 -0800 (PST) Received: from mail-da0-f52.google.com (mail-da0-f52.google.com [209.85.210.52]) by mx.google.com with ESMTPS id f5si17461234pav.140.2012.11.25.20.55.36 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:55:36 -0800 (PST) Received-SPF: neutral (google.com: 209.85.210.52 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.210.52; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.52 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-da0-f52.google.com with SMTP id f10so4614574dak.11 for ; Sun, 25 Nov 2012 20:55:36 -0800 (PST) Received: by 10.68.232.201 with SMTP id tq9mr34210931pbc.12.1353905736197; Sun, 25 Nov 2012 20:55:36 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id g1sm8082844pax.21.2012.11.25.20.55.33 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:55:35 -0800 (PST) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: t.stanislaws@samsung.com, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/9] [media] s5p-tv: Add missing braces around sizeof in sdo_drv.c Date: Mon, 26 Nov 2012 10:19:00 +0530 Message-Id: <1353905348-15475-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353905348-15475-1-git-send-email-sachin.kamat@linaro.org> References: <1353905348-15475-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQl3+VxkIIjSZXqyc7z6+QKb65LAZe9D3A76uaqBTqenG3dXNdIdzkWSnsTkYy8u1GAbdd/m Silences the following checkpatch warnings: WARNING: sizeof *sdev should be sizeof(*sdev) FILE: media/platform/s5p-tv/sdo_drv.c:304: sdev = devm_kzalloc(&pdev->dev, sizeof *sdev, GFP_KERNEL); WARNING: sizeof sdev->sd.name should be sizeof(sdev->sd.name) FILE: media/platform/s5p-tv/sdo_drv.c:394: strlcpy(sdev->sd.name, "s5p-sdo", sizeof sdev->sd.name); Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/sdo_drv.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-tv/sdo_drv.c b/drivers/media/platform/s5p-tv/sdo_drv.c index ad68bbe..91e2de3 100644 --- a/drivers/media/platform/s5p-tv/sdo_drv.c +++ b/drivers/media/platform/s5p-tv/sdo_drv.c @@ -301,7 +301,7 @@ static int __devinit sdo_probe(struct platform_device *pdev) struct clk *sclk_vpll; dev_info(dev, "probe start\n"); - sdev = devm_kzalloc(&pdev->dev, sizeof *sdev, GFP_KERNEL); + sdev = devm_kzalloc(&pdev->dev, sizeof(*sdev), GFP_KERNEL); if (!sdev) { dev_err(dev, "not enough memory.\n"); ret = -ENOMEM; @@ -394,7 +394,7 @@ static int __devinit sdo_probe(struct platform_device *pdev) /* configuration of interface subdevice */ v4l2_subdev_init(&sdev->sd, &sdo_sd_ops); sdev->sd.owner = THIS_MODULE; - strlcpy(sdev->sd.name, "s5p-sdo", sizeof sdev->sd.name); + strlcpy(sdev->sd.name, "s5p-sdo", sizeof(sdev->sd.name)); /* set default format */ sdev->fmt = sdo_find_format(SDO_DEFAULT_STD);