From patchwork Wed Sep 26 07:18:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 11729 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 87F5423E42 for ; Wed, 26 Sep 2012 07:21:50 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 09F30A18A40 for ; Wed, 26 Sep 2012 07:21:49 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so642327iej.11 for ; Wed, 26 Sep 2012 00:21:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=qk5iJih1VQysHN01SQB6eTmxD1WBGn4OzGCWMruPGA4=; b=nKWb13vY9/2seIb3Xbwy2PDPPew2ZxDkOaTjYFb9v8XwLinK77RIZWZhqqvo8GcBZA cqhWIeHTb+VdAdYjog5LIA2v4LWy0InOD1pYOqrexoW81ZGIdO2OIRcsiNhNeS6ZF6rY jp0sT2HrQDvYuFtB6uz/3am73+8i6v4ckQagtaEt9cWxlOJ8b0yfS8PclviwBnc2Qv76 cbAiCyurwiFDlcCfQ9wbLWSwwds1TzjEo688BiHDCAXPtsk3G+7mE7jTRfcL9HRaVyMa J8qziWokRWPj/2BmWJDRd4VM2vDN8HMq2kckVMkDUkQAYTPav6ZIwhWljQuoj4xtQjQ9 CUGg== Received: by 10.50.195.134 with SMTP id ie6mr10395151igc.28.1348644109739; Wed, 26 Sep 2012 00:21:49 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp340508igc; Wed, 26 Sep 2012 00:21:49 -0700 (PDT) Received: by 10.68.228.98 with SMTP id sh2mr164742pbc.95.1348644109195; Wed, 26 Sep 2012 00:21:49 -0700 (PDT) Received: from mail-da0-f50.google.com (mail-da0-f50.google.com [209.85.210.50]) by mx.google.com with ESMTPS id rr1si3035817pbc.98.2012.09.26.00.21.49 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 26 Sep 2012 00:21:49 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.210.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.210.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by daez20 with SMTP id z20so84246dae.37 for ; Wed, 26 Sep 2012 00:21:49 -0700 (PDT) Received: by 10.66.72.197 with SMTP id f5mr46630820pav.20.1348644108851; Wed, 26 Sep 2012 00:21:48 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id ru4sm1633623pbc.25.2012.09.26.00.21.46 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 26 Sep 2012 00:21:48 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: s.nawrocki@samsung.com, shaik.ameer@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 2/2] [media] exynos-gsc: Add missing static storage class specifiers Date: Wed, 26 Sep 2012 12:48:04 +0530 Message-Id: <1348643884-4005-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1348643884-4005-1-git-send-email-sachin.kamat@linaro.org> References: <1348643884-4005-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQlGTRYYIVl2+0FTZeFZskvFxuNvEjiSTmoU5TsAC7BKikWDdYdsFb6TxoBqqUK/xvKbHzBz Fixes the following warnings: drivers/media/platform/exynos-gsc/gsc-core.c:313:5: warning: symbol 'get_plane_info' was not declared. Should it be static? drivers/media/platform/exynos-gsc/gsc-core.c:746:28: warning: symbol 'gsc_ctrl_ops' was not declared. Should it be static? drivers/media/platform/exynos-gsc/gsc-m2m.c:102:5: warning: symbol 'gsc_fill_addr' was not declared. Should it be static? drivers/media/platform/exynos-gsc/gsc-m2m.c:252:16: warning: symbol 'gsc_m2m_qops' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos-gsc/gsc-core.c | 4 ++-- drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c index 90a6c55..bfec9e6 100644 --- a/drivers/media/platform/exynos-gsc/gsc-core.c +++ b/drivers/media/platform/exynos-gsc/gsc-core.c @@ -310,7 +310,7 @@ int gsc_enum_fmt_mplane(struct v4l2_fmtdesc *f) return 0; } -u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *index) +static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *index) { if (frm->addr.y == addr) { *index = 0; @@ -743,7 +743,7 @@ static int gsc_s_ctrl(struct v4l2_ctrl *ctrl) return ret; } -const struct v4l2_ctrl_ops gsc_ctrl_ops = { +static const struct v4l2_ctrl_ops gsc_ctrl_ops = { .s_ctrl = gsc_s_ctrl, }; diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c index a4f327e..3c7f005 100644 --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c @@ -99,7 +99,7 @@ static void gsc_m2m_job_abort(void *priv) gsc_m2m_job_finish(ctx, VB2_BUF_STATE_ERROR); } -int gsc_fill_addr(struct gsc_ctx *ctx) +static int gsc_fill_addr(struct gsc_ctx *ctx) { struct gsc_frame *s_frame, *d_frame; struct vb2_buffer *vb = NULL; @@ -249,7 +249,7 @@ static void gsc_m2m_buf_queue(struct vb2_buffer *vb) v4l2_m2m_buf_queue(ctx->m2m_ctx, vb); } -struct vb2_ops gsc_m2m_qops = { +static struct vb2_ops gsc_m2m_qops = { .queue_setup = gsc_m2m_queue_setup, .buf_prepare = gsc_m2m_buf_prepare, .buf_queue = gsc_m2m_buf_queue,