From patchwork Mon Sep 24 06:17:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 11654 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 8ACC223F66 for ; Mon, 24 Sep 2012 06:21:27 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 16CB8A18205 for ; Mon, 24 Sep 2012 06:21:26 +0000 (UTC) Received: by ieje10 with SMTP id e10so9154810iej.11 for ; Sun, 23 Sep 2012 23:21:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=v9s5YzhW/scqNAJ0VQ4QYkWk4bQGyvua9pYj0n4xlgg=; b=TyexECEL16gqk0pMvWL9OU2FYkYYn6nUWhgWZJGQE/kQ31YF0GJTZ2Bpz9QoGD6muR b3chOVGtRueiZI+e4GdMJgj5uKHupN+STB4SRauKyTCowt70SvhM3afW8gRKgskVcpmM DIsGlA51WZSSpTgOU0GgNSVYvsL/bSKlVhPRvCjeG3tsVLfg4I5Aj26/guacs1gIMJII eAHSmBMp61/fig6SfS0eW7FVW4rd0sFJR1oWFuu0yd6ydl56hakcmQUAOFLUKy/hH4+p cZTYrVAlGjghEgrXZUvD+JJHpOioO88UOnCLmbym0cZh4vhZnD4qDXZHrw9SEdP8mX8U j60g== Received: by 10.50.154.227 with SMTP id vr3mr4336694igb.43.1348467686436; Sun, 23 Sep 2012 23:21:26 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp228633igc; Sun, 23 Sep 2012 23:21:26 -0700 (PDT) Received: by 10.68.220.137 with SMTP id pw9mr34107128pbc.1.1348467685682; Sun, 23 Sep 2012 23:21:25 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id s7si6036439pax.190.2012.09.23.23.21.25 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 23 Sep 2012 23:21:25 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by pbcmd12 with SMTP id md12so12518347pbc.37 for ; Sun, 23 Sep 2012 23:21:25 -0700 (PDT) Received: by 10.68.203.230 with SMTP id kt6mr33687787pbc.163.1348467685164; Sun, 23 Sep 2012 23:21:25 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id ho7sm9161024pbc.3.2012.09.23.23.21.22 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 23 Sep 2012 23:21:24 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: mchehab@infradead.org, sachin.kamat@linaro.org, m.szyprowski@samsung.com, pawel@osciak.com, patches@linaro.org Subject: [PATCH 1/4] [media] mem2mem_testdev: Fix incorrect location of v4l2_m2m_release() Date: Mon, 24 Sep 2012 11:47:45 +0530 Message-Id: <1348467468-19854-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQnecXuB9ycsyg60/rOAT6z4o4ML+QZayc4+7BkI3W1mtxXeRKNV5eSJCkKbDIuAAo5Z3US7 v4l2_m2m_release() was placed after the return statement and outside any of the goto labels and hence was not getting executed under the error exit path. This patch moves it under the exit path label. Signed-off-by: Sachin Kamat Acked-by: Marek Szyprowski --- drivers/media/platform/mem2mem_testdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/mem2mem_testdev.c b/drivers/media/platform/mem2mem_testdev.c index 771a84f..fc95559 100644 --- a/drivers/media/platform/mem2mem_testdev.c +++ b/drivers/media/platform/mem2mem_testdev.c @@ -1067,8 +1067,8 @@ static int m2mtest_probe(struct platform_device *pdev) return 0; - v4l2_m2m_release(dev->m2m_dev); err_m2m: + v4l2_m2m_release(dev->m2m_dev); video_unregister_device(dev->vfd); rel_vdev: video_device_release(vfd);