From patchwork Tue Aug 14 04:52:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 10714 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 9D65A23E56 for ; Tue, 14 Aug 2012 04:53:51 +0000 (UTC) Received: from mail-gh0-f180.google.com (mail-gh0-f180.google.com [209.85.160.180]) by fiordland.canonical.com (Postfix) with ESMTP id 5AB99A181E6 for ; Tue, 14 Aug 2012 04:53:51 +0000 (UTC) Received: by ghbg10 with SMTP id g10so4028457ghb.11 for ; Mon, 13 Aug 2012 21:53:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=a3jKmAGCCrB3o6WhWeA3BxURuAW154yDY4SDmV9l6UY=; b=gtMm77IvqwmFDX9jfF6zT838ZXrrosHgImy+Nrn85qpN9IO4WYpDTm9SvLw6MLT9CV OcniR4Jh7YEcV3H2AP+Y6YWc+Sx3cPdyBYzxSZ/flrP28LVBzb5fpskssZXYnE6mnldO 2zdDSxlCHPvBf+yj8plsqxYK6NPO44y2YDCGk0JkMMoysI6hF2/+YwGNl5lw1+JhPCjx D1YyCI9qmVxaRsxktMQr+aeFlPElCkpimE1Two4A3mN4QLQZYnhRA86f0HBKKlX7SUCg CmVKl84YBgqRYnUAYGFnGGVrhpn08pui/f2ug+dUuAf7SP5Ey/itDwtztqNWf1VLSNCF G+zQ== Received: by 10.50.154.132 with SMTP id vo4mr9463367igb.31.1344920030662; Mon, 13 Aug 2012 21:53:50 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.200 with SMTP id ew8csp213288igc; Mon, 13 Aug 2012 21:53:50 -0700 (PDT) Received: by 10.236.153.9 with SMTP id e9mr13793949yhk.32.1344920029463; Mon, 13 Aug 2012 21:53:49 -0700 (PDT) Received: from mail-yw0-f50.google.com (mail-yw0-f50.google.com [209.85.213.50]) by mx.google.com with ESMTPS id n64si1489403yhk.111.2012.08.13.21.53.48 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 13 Aug 2012 21:53:49 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.213.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.213.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.213.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by yhjj63 with SMTP id j63so4699541yhj.37 for ; Mon, 13 Aug 2012 21:53:48 -0700 (PDT) Received: by 10.68.201.73 with SMTP id jy9mr21524868pbc.124.1344920028318; Mon, 13 Aug 2012 21:53:48 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id io1sm460625pbc.67.2012.08.13.21.53.45 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 13 Aug 2012 21:53:47 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: s.nawrocki@samsung.com, mchehab@infradead.org, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH] [media] s5p-fimc: Make FIMC-Lite dependent on S5P-FIMC Date: Tue, 14 Aug 2012 10:22:03 +0530 Message-Id: <1344919923-16764-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQke5/lbCXTFVtWxokadaatTgOZ2Vjo/OrNfF1FQwp0kbuds6enFGs81ALlq8CofP5wzZK5R FIMC-Lite driver accesses functions which are defined in files attached to S5P_FIMC. Without this patch, if only FIMC-Lite is selected, following errors are observed for missing symbols: drivers/built-in.o: In function `fimc_md_create_links': fimc-mdevice.c:641: undefined reference to `fimc_sensor_notify' drivers/built-in.o: In function `fimc_md_link_notify': fimc-mdevice.c:838: undefined reference to `fimc_ctrls_delete' fimc-mdevice.c:854: undefined reference to `fimc_capture_ctrls_create' drivers/built-in.o: In function `fimc_md_init': fimc-mdevice.c:1018: undefined reference to `fimc_register_driver' drivers/built-in.o: In function `fimc_md_exit': fimc-mdevice.c:1028: undefined reference to `fimc_unregister_driver' make: *** [vmlinux] Error 1 Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-fimc/Kconfig | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/s5p-fimc/Kconfig b/drivers/media/video/s5p-fimc/Kconfig index a564f7e..17a1f8d 100644 --- a/drivers/media/video/s5p-fimc/Kconfig +++ b/drivers/media/video/s5p-fimc/Kconfig @@ -35,7 +35,7 @@ if ARCH_EXYNOS config VIDEO_EXYNOS_FIMC_LITE tristate "EXYNOS FIMC-LITE camera interface driver" - depends on I2C + depends on I2C && VIDEO_S5P_FIMC select VIDEOBUF2_DMA_CONTIG help This is a V4L2 driver for Samsung EXYNOS4/5 SoC FIMC-LITE camera