From patchwork Thu May 10 06:35:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 8511 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 5C57C23ED1 for ; Thu, 10 May 2012 06:45:41 +0000 (UTC) Received: from mail-gg0-f180.google.com (mail-gg0-f180.google.com [209.85.161.180]) by fiordland.canonical.com (Postfix) with ESMTP id 286EAA1819A for ; Thu, 10 May 2012 06:45:41 +0000 (UTC) Received: by ggnf1 with SMTP id f1so294486ggn.11 for ; Wed, 09 May 2012 23:45:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=q2qxtxoBZvBmqpVULmCb/mnJXfJ/k4WeKmIH00K7W2U=; b=U/k12UdLQySKeLzY1eqPaqiqDmW0/Xd2jrLtQxA40a9X2po8eW51RxugMjE9Mavnxm WWFzKAwndCTovqfwaJ6oTQaEf8tsS37F1ntBcnaAPe2FGJI8HevNP1NmIEiliSlafCMJ Nrz+ktcp0FZwPYDVla7lqU4CPgLrgGwSc80YAVZJAK4R2LWEOjqGzsfrbvh1Dftd/kP5 DWLrZ+1RBtE/odxZqYP4wthjREXTH289ZpQjR1g9QEFW8XwqfLk5XFdNHD7c/v6luk2S bNEGWhEuxuEzgbQJBk4LxfL/l0HWBmh39v48mgMEDeKbVojAJS0M1vOt7KExdFGlkROF 8Hrg== Received: by 10.50.10.225 with SMTP id l1mr1691233igb.1.1336632340461; Wed, 09 May 2012 23:45:40 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.73.147 with SMTP id q19csp71557ibj; Wed, 9 May 2012 23:45:40 -0700 (PDT) Received: by 10.68.132.232 with SMTP id ox8mr16874296pbb.145.1336632339788; Wed, 09 May 2012 23:45:39 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id vn9si2125769pbc.228.2012.05.09.23.45.39 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 May 2012 23:45:39 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by pbbrr4 with SMTP id rr4so1889033pbb.37 for ; Wed, 09 May 2012 23:45:39 -0700 (PDT) Received: by 10.68.202.130 with SMTP id ki2mr17235420pbc.52.1336632339497; Wed, 09 May 2012 23:45:39 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id q1sm8574684pbp.62.2012.05.09.23.45.36 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 May 2012 23:45:38 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: mchehab@infradead.org, k.debski@samsung.com, kyungmin.park@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 2/2] [media] s5p-g2d: Add missing static storage class in g2d.c file Date: Thu, 10 May 2012 12:05:48 +0530 Message-Id: <1336631748-25160-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1336631748-25160-1-git-send-email-sachin.kamat@linaro.org> References: <1336631748-25160-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQmM7G4SKjXcsP5SLY1TV54OA/c0ZQMVFR9q/h2b97S/y1SWyJTLCZcKpf5p6dEsXQLQIvtz Fixes the following sparse warnings: drivers/media/video/s5p-g2d/g2d.c:68:18: warning: symbol 'def_frame' was not declared. Should it be static? drivers/media/video/s5p-g2d/g2d.c:80:16: warning: symbol 'find_fmt' was not declared. Should it be static? drivers/media/video/s5p-g2d/g2d.c:205:5: warning: symbol 'g2d_setup_ctrls' was not declared. Should it be static? Signed-off-by: Sachin Kamat Acked-by: Kamil Debski --- drivers/media/video/s5p-g2d/g2d.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/s5p-g2d/g2d.c b/drivers/media/video/s5p-g2d/g2d.c index 70bee1c..115b936 100644 --- a/drivers/media/video/s5p-g2d/g2d.c +++ b/drivers/media/video/s5p-g2d/g2d.c @@ -65,7 +65,7 @@ static struct g2d_fmt formats[] = { }; #define NUM_FORMATS ARRAY_SIZE(formats) -struct g2d_frame def_frame = { +static struct g2d_frame def_frame = { .width = DEFAULT_WIDTH, .height = DEFAULT_HEIGHT, .c_width = DEFAULT_WIDTH, @@ -77,7 +77,7 @@ struct g2d_frame def_frame = { .bottom = DEFAULT_HEIGHT, }; -struct g2d_fmt *find_fmt(struct v4l2_format *f) +static struct g2d_fmt *find_fmt(struct v4l2_format *f) { unsigned int i; for (i = 0; i < NUM_FORMATS; i++) { @@ -202,7 +202,7 @@ static const struct v4l2_ctrl_ops g2d_ctrl_ops = { .s_ctrl = g2d_s_ctrl, }; -int g2d_setup_ctrls(struct g2d_ctx *ctx) +static int g2d_setup_ctrls(struct g2d_ctx *ctx) { struct g2d_dev *dev = ctx->dev;