From patchwork Fri Oct 6 10:08:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Verkuil X-Patchwork-Id: 731317 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11169E92FFB for ; Fri, 6 Oct 2023 10:08:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231681AbjJFKI6 (ORCPT ); Fri, 6 Oct 2023 06:08:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231717AbjJFKI4 (ORCPT ); Fri, 6 Oct 2023 06:08:56 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DD4AFD for ; Fri, 6 Oct 2023 03:08:53 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DF61C433C9 for ; Fri, 6 Oct 2023 10:08:52 +0000 (UTC) From: Hans Verkuil To: linux-media@vger.kernel.org Subject: [PATCH 0/9] media: fix smatch warnings Date: Fri, 6 Oct 2023 12:08:41 +0200 Message-Id: X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This series fixes various smatch warnings. The build scripts didn't call smatch with the -p=kernel option, so some warnings were disabled. After fixing that new warnings appeared that are fixed in this series. A few warnings remain for false positives that would be very painful to fix, and those are filtered by the build script so that they don't pollute the output. Note that the adp1653 patch is a v2 of the first attempt: https://patchwork.linuxtv.org/project/linux-media/patch/da55b552-08ce-6bbe-c70b-eda6f53727f0@xs4all.nl/ I incorporated Sakari's suggestions in the v2. Regards, Hans Hans Verkuil (9): staging: media: atomisp: drop check for reentrant .s_stream() media: i2c: adp1653: don't reuse the same node pointer staging: media: atomisp: improve unwinding media: dvb-usb-v2: af9035: fix missing unlock media: nxp: imx-jpeg: use goto instead of return media: qcom: venus: fix incorrect return value media: i2c: tc358746: check fmt validity media: i2c: mt9m114: goto proper error path media: pci: mgb4: fix potential spectre vulnerability drivers/media/i2c/adp1653.c | 28 ++++++++++--------- drivers/media/i2c/mt9m114.c | 4 +-- drivers/media/i2c/tc358746.c | 6 +++- drivers/media/pci/mgb4/mgb4_sysfs_out.c | 5 +++- .../media/platform/nxp/imx-jpeg/mxc-jpeg.c | 2 +- .../media/platform/qcom/venus/pm_helpers.c | 2 +- drivers/media/usb/dvb-usb-v2/af9035.c | 13 ++++++--- .../media/atomisp/i2c/atomisp-gc0310.c | 6 ---- .../staging/media/atomisp/pci/atomisp_cmd.c | 18 ++++++++---- 9 files changed, 49 insertions(+), 35 deletions(-)