mbox series

[0/4] drm/nouveau: Simplify nouveau_fence.c

Message ID 20250424130254.42046-2-phasta@kernel.org
Headers show
Series drm/nouveau: Simplify nouveau_fence.c | expand

Message

Philipp Stanner April 24, 2025, 1:02 p.m. UTC 
Just some minor attempts at improving the readability of
nouveau_fence.c

This series is based on this partially merged series: [1]

Feel free to drop single patches if they are not deemed worth the
effort.

P.

[1] https://lore.kernel.org/dri-devel/20250415121900.55719-3-phasta@kernel.org/

Philipp Stanner (4):
  drm/nouveau: nouveau_fence: Standardize list iterations
  drm/nouveau: Simplify calls to nvif_event_block()
  drm/nouveau: Simplify nouveau_fence_done()
  drm/nouveau: Check dma_fence in canonical way

 drivers/gpu/drm/nouveau/nouveau_fence.c | 72 +++++++++++--------------
 1 file changed, 30 insertions(+), 42 deletions(-)

Comments

Christian König April 28, 2025, 2:43 p.m. UTC | #1 
On 4/24/25 15:02, Philipp Stanner wrote:
> nouveau_fence_done() contains an if branch that checks whether a
> nouveau_fence has either of the two existing nouveau_fence backend ops,
> which will always evaluate to true.
> 
> Remove the surplus check.
> 
> Signed-off-by: Philipp Stanner <phasta@kernel.org>


Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/gpu/drm/nouveau/nouveau_fence.c | 24 +++++++++++-------------
>  1 file changed, 11 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c
> index 2b79bcb7da16..fb9811938c82 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_fence.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
> @@ -249,21 +249,19 @@ nouveau_fence_emit(struct nouveau_fence *fence)
>  bool
>  nouveau_fence_done(struct nouveau_fence *fence)
>  {
> -	if (fence->base.ops == &nouveau_fence_ops_legacy ||
> -	    fence->base.ops == &nouveau_fence_ops_uevent) {
> -		struct nouveau_fence_chan *fctx = nouveau_fctx(fence);
> -		struct nouveau_channel *chan;
> -		unsigned long flags;
> +	struct nouveau_fence_chan *fctx = nouveau_fctx(fence);
> +	struct nouveau_channel *chan;
> +	unsigned long flags;
>  
> -		if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->base.flags))
> -			return true;
> +	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->base.flags))
> +		return true;
> +
> +	spin_lock_irqsave(&fctx->lock, flags);
> +	chan = rcu_dereference_protected(fence->channel, lockdep_is_held(&fctx->lock));
> +	if (chan)
> +		nouveau_fence_update(chan, fctx);
> +	spin_unlock_irqrestore(&fctx->lock, flags);
>  
> -		spin_lock_irqsave(&fctx->lock, flags);
> -		chan = rcu_dereference_protected(fence->channel, lockdep_is_held(&fctx->lock));
> -		if (chan)
> -			nouveau_fence_update(chan, fctx);
> -		spin_unlock_irqrestore(&fctx->lock, flags);
> -	}
>  	return dma_fence_is_signaled(&fence->base);
>  }
>