mbox series

[v1,00/13] Convert to use devm_kmemdup_array()

Message ID 20250221165333.2780888-1-raag.jadav@intel.com
Headers show
Series Convert to use devm_kmemdup_array() | expand

Message

Raag Jadav Feb. 21, 2025, 4:53 p.m. UTC 
This series is the second wave of patches to add users of newly introduced
devm_kmemdup_array() helper. Original series on [1].

This depends on changes available on immutable tag[2]. Feel free to pick
your subsystem patches with it, or share your preferred way to route them.

[1] https://lore.kernel.org/r/20250212062513.2254767-1-raag.jadav@intel.com
[2] https://lore.kernel.org/r/Z7cqCaME4LxTTBn6@black.fi.intel.com

Raag Jadav (13):
  ASoC: Intel: avs: use devm_kmemdup_array()
  ASoC: hdac_hdmi: use devm_kmemdup_array()
  ASoC: tlv320dac33: use devm_kmemdup_array()
  ASoC: uda1380: use devm_kmemdup_array()
  ASoC: meson: axg-tdm-interface: use devm_kmemdup_array()
  ASoC: uniphier: use devm_kmemdup_array()
  fbdev: pxafb: use devm_kmemdup_array()
  power: supply: sc27xx: use devm_kmemdup_array()
  regulator: devres: use devm_kmemdup_array()
  regulator: cros-ec: use devm_kmemdup_array()
  media: atmel-isi: use devm_kmemdup_array()
  media: stm32-dcmi: use devm_kmemdup_array()
  ntb: idt: use devm_kmemdup_array()

 drivers/media/platform/atmel/atmel-isi.c     |  8 ++------
 drivers/media/platform/st/stm32/stm32-dcmi.c |  8 ++------
 drivers/ntb/hw/idt/ntb_hw_idt.c              | 11 +++-------
 drivers/power/supply/sc27xx_fuel_gauge.c     |  5 ++---
 drivers/regulator/cros-ec-regulator.c        |  4 ++--
 drivers/regulator/devres.c                   |  5 ++---
 drivers/video/fbdev/pxafb.c                  | 21 ++++++++------------
 sound/soc/codecs/hdac_hdmi.c                 |  3 +--
 sound/soc/codecs/tlv320dac33.c               |  6 ++----
 sound/soc/codecs/uda1380.c                   |  6 ++----
 sound/soc/intel/avs/boards/da7219.c          |  3 ++-
 sound/soc/intel/avs/boards/es8336.c          |  3 ++-
 sound/soc/intel/avs/boards/nau8825.c         |  3 ++-
 sound/soc/intel/avs/boards/rt274.c           |  3 ++-
 sound/soc/intel/avs/boards/rt286.c           |  3 ++-
 sound/soc/intel/avs/boards/rt298.c           |  3 ++-
 sound/soc/intel/avs/boards/rt5663.c          |  3 ++-
 sound/soc/intel/avs/boards/rt5682.c          |  3 ++-
 sound/soc/meson/axg-tdm-interface.c          |  9 ++-------
 sound/soc/uniphier/aio-cpu.c                 |  8 ++------
 20 files changed, 46 insertions(+), 72 deletions(-)


base-commit: b16e9f8547a328b19af59afc213ce323124d11e9

Comments

Raag Jadav Feb. 22, 2025, 9:27 a.m. UTC | #1 
Cc: Arnd

On Fri, Feb 21, 2025 at 10:05:09AM -0700, Dave Jiang wrote:
> On 2/21/25 9:53 AM, Raag Jadav wrote:
> > Convert to use devm_kmemdup_array() which is more robust.
> > 
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> 
> I think this patch [1] from earlier today makes this change unnecessary now.
> 
> [1]: https://lore.kernel.org/ntb/20250221085748.2298463-1-arnd@kernel.org/

Sure, in that case we can drop this one. Thanks for noticing.

Raag

> > ---
> >  drivers/ntb/hw/idt/ntb_hw_idt.c | 11 +++--------
> >  1 file changed, 3 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/ntb/hw/idt/ntb_hw_idt.c b/drivers/ntb/hw/idt/ntb_hw_idt.c
> > index 544d8a4d2af5..dbfc53d0ef0c 100644
> > --- a/drivers/ntb/hw/idt/ntb_hw_idt.c
> > +++ b/drivers/ntb/hw/idt/ntb_hw_idt.c
> > @@ -1103,16 +1103,11 @@ static struct idt_mw_cfg *idt_scan_mws(struct idt_ntb_dev *ndev, int port,
> >  		}
> >  	}
> >  
> > -	/* Allocate memory for memory window descriptors */
> > -	ret_mws = devm_kcalloc(&ndev->ntb.pdev->dev, *mw_cnt, sizeof(*ret_mws),
> > -			       GFP_KERNEL);
> > -	if (!ret_mws)
> > -		return ERR_PTR(-ENOMEM);
> > -
> >  	/* Copy the info of detected memory windows */
> > -	memcpy(ret_mws, mws, (*mw_cnt)*sizeof(*ret_mws));
> > +	ret_mws = devm_kmemdup_array(&ndev->ntb.pdev->dev, mws, *mw_cnt,
> > +				     sizeof(mws[0]), GFP_KERNEL);
> >  
> > -	return ret_mws;
> > +	return ret_mws ?: ERR_PTR(-ENOMEM);
> >  }
> >  
> >  /*
>