mbox series

[0/2] media: imx335: Support vertical flip

Message ID 20240710044633.81372-1-umang.jain@ideasonboard.com
Headers show
Series media: imx335: Support vertical flip | expand

Message

Umang Jain July 10, 2024, 4:46 a.m. UTC 
Hi all,

This work intends to supprt vertical flipping for IMX335 driver.
1/2 contains a small drive by fix, to rename the mode struct name
2/2 introduces the support for vertical flip for the mode.

Umang Jain (2):
  media: imx335: Rectify name of mode struct
  media: imx335: Support vertical flip

 drivers/media/i2c/imx335.c | 77 +++++++++++++++++++++++++++++++++++---
 1 file changed, 72 insertions(+), 5 deletions(-)

Comments

Tommaso Merciai July 10, 2024, 8:21 a.m. UTC | #1 
Hi Umang,

On Wed, Jul 10, 2024 at 10:16:31AM +0530, Umang Jain wrote:
> In commit 81495a59baeb ("media: imx335: Fix active area height discrepency")
> the height for the mode struct was rectified to '1944'. However, the
> name of mode struct is still reflecting to '1940'. Update it.
> 
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  drivers/media/i2c/imx335.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index 990d74214cc2..6c1e61b6696b 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -252,7 +252,7 @@ static const int imx335_tpg_val[] = {
>  };
>  
>  /* Sensor mode registers */
> -static const struct cci_reg_sequence mode_2592x1940_regs[] = {
> +static const struct cci_reg_sequence mode_2592x1944_regs[] = {
>  	{ IMX335_REG_MODE_SELECT, IMX335_MODE_STANDBY },
>  	{ IMX335_REG_MASTER_MODE, 0x00 },
>  	{ IMX335_REG_WINMODE, 0x04 },
> @@ -416,8 +416,8 @@ static const struct imx335_mode supported_mode = {
>  	.vblank_max = 133060,
>  	.pclk = 396000000,
>  	.reg_list = {
> -		.num_of_regs = ARRAY_SIZE(mode_2592x1940_regs),
> -		.regs = mode_2592x1940_regs,
> +		.num_of_regs = ARRAY_SIZE(mode_2592x1944_regs),
> +		.regs = mode_2592x1944_regs,
>  	},
>  };
>  
> -- 
> 2.45.0
> 
> 

Looks good to me.
Reviewed-by: Tommaso Merciai <tomm.merciai@gmail.com>

Thanks & Regards,
Tommaso