mbox series

[v5,0/6] rcar-vin: Add support for R-Car V4M

Message ID 20240704161620.1425409-1-niklas.soderlund+renesas@ragnatech.se
Headers show
Series rcar-vin: Add support for R-Car V4M | expand

Message

Niklas Söderlund July 4, 2024, 4:16 p.m. UTC 
Hello,

This series adds bindings and support to rcar-vin for R-Car V4M by the
means of adding a Gen4 family fallback compatible.

Previous versions of this series added V4M support like done for VIN
since the first Gen3 device, by the use of only a single SoC specific
compatible value. This was done as in Gen3 almost every new device
differed from the others and a family fallback was not very useful.

For the Gen4 devices with a video capture pipeline currently documented 
the VIN instances are very similar and a family fallback can be used.  
This however requires updating existing DTS files to add this new family 
fallback. This is done in a backward compatible way and the driver 
retains the compatible values.

See individual patches for changes since previous versions.

Niklas Söderlund (6):
  dt-bindings: media: renesas,vin: Add Gen4 family fallback
  arm64: dts: renesas: r8a779g0: Add family fallback for VIN IP
  arm64: dts: renesas: r8a779a0: Add family fallback for VIN IP
  media: rcar-vin: Add family compatible for R-Car Gen4 family
  dt-bindings: media: renesas,vin: Add binding for V4M
  arm64: dts: renesas: r8a779h0: Add family fallback for VIN IP

 .../bindings/media/renesas,vin.yaml           |  4 +
 arch/arm64/boot/dts/renesas/r8a779a0.dtsi     | 96 ++++++++++++-------
 arch/arm64/boot/dts/renesas/r8a779g0.dtsi     | 48 ++++++----
 arch/arm64/boot/dts/renesas/r8a779h0.dtsi     | 48 ++++++----
 .../platform/renesas/rcar-vin/rcar-core.c     | 21 ++--
 5 files changed, 141 insertions(+), 76 deletions(-)

Comments

Geert Uytterhoeven Aug. 20, 2024, 7:34 a.m. UTC | #1 
On Thu, Jul 4, 2024 at 6:16 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> This series adds bindings and support to rcar-vin for R-Car V4M by the
> means of adding a Gen4 family fallback compatible.
>
> Previous versions of this series added V4M support like done for VIN
> since the first Gen3 device, by the use of only a single SoC specific
> compatible value. This was done as in Gen3 almost every new device
> differed from the others and a family fallback was not very useful.
>
> For the Gen4 devices with a video capture pipeline currently documented
> the VIN instances are very similar and a family fallback can be used.
> This however requires updating existing DTS files to add this new family
> fallback. This is done in a backward compatible way and the driver
> retains the compatible values.
>
> See individual patches for changes since previous versions.
>
> Niklas Söderlund (6):
>   dt-bindings: media: renesas,vin: Add Gen4 family fallback
>   arm64: dts: renesas: r8a779g0: Add family fallback for VIN IP
>   arm64: dts: renesas: r8a779a0: Add family fallback for VIN IP
>   media: rcar-vin: Add family compatible for R-Car Gen4 family
>   dt-bindings: media: renesas,vin: Add binding for V4M
>   arm64: dts: renesas: r8a779h0: Add family fallback for VIN IP

Any chance the media parts can be accepted, so I can take the DTS
patches through the Renesas tree?

BTW, running b4 seems to add two bogus Acked-by tags from Conor:

$ b4 am 20240704161620.1425409-3-niklas.soderlund+renesas@ragnatech.se
Analyzing 7 messages in the thread
Analyzing 14 code-review messages
Checking attestation on all messages, may take a moment...
---
  ✗ [PATCH v5 1/6] dt-bindings: media: renesas,vin: Add Gen4 family fallback
  ✗ [PATCH v5 2/6] arm64: dts: renesas: r8a779g0: Add family fallback for VIN IP
    + Acked-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)
  ✗ [PATCH v5 3/6] arm64: dts: renesas: r8a779a0: Add family fallback for VIN IP
  ✗ [PATCH v5 4/6] media: rcar-vin: Add family compatible for R-Car Gen4 family
  ✗ [PATCH v5 5/6] dt-bindings: media: renesas,vin: Add binding for V4M
  ✗ [PATCH v5 6/6] arm64: dts: renesas: r8a779h0: Add family fallback for VIN IP
    + Acked-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)

I cannot find these Acks in my inbox or on lore.
What's happening?

Thanks!

Gr{oetje,eeting}s,

                        Geert
Niklas Söderlund Aug. 21, 2024, 11:51 a.m. UTC | #2 
Hello,

On 2024-08-20 09:34:55 +0200, Geert Uytterhoeven wrote:
> On Thu, Jul 4, 2024 at 6:16 PM Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > This series adds bindings and support to rcar-vin for R-Car V4M by the
> > means of adding a Gen4 family fallback compatible.
> >
> > Previous versions of this series added V4M support like done for VIN
> > since the first Gen3 device, by the use of only a single SoC specific
> > compatible value. This was done as in Gen3 almost every new device
> > differed from the others and a family fallback was not very useful.
> >
> > For the Gen4 devices with a video capture pipeline currently documented
> > the VIN instances are very similar and a family fallback can be used.
> > This however requires updating existing DTS files to add this new family
> > fallback. This is done in a backward compatible way and the driver
> > retains the compatible values.
> >
> > See individual patches for changes since previous versions.
> >
> > Niklas Söderlund (6):
> >   dt-bindings: media: renesas,vin: Add Gen4 family fallback
> >   arm64: dts: renesas: r8a779g0: Add family fallback for VIN IP
> >   arm64: dts: renesas: r8a779a0: Add family fallback for VIN IP
> >   media: rcar-vin: Add family compatible for R-Car Gen4 family
> >   dt-bindings: media: renesas,vin: Add binding for V4M
> >   arm64: dts: renesas: r8a779h0: Add family fallback for VIN IP
> 
> Any chance the media parts can be accepted, so I can take the DTS
> patches through the Renesas tree?

I would be happy to have some feedback on the media parts as well as I 
will need to send a very similar series for the rcar-isp driver to add a 
family fallback for Gen4. But I have hold of on posting them until I 
knew this is the correct path forward.

> 
> BTW, running b4 seems to add two bogus Acked-by tags from Conor:
> 
> $ b4 am 20240704161620.1425409-3-niklas.soderlund+renesas@ragnatech.se
> Analyzing 7 messages in the thread
> Analyzing 14 code-review messages
> Checking attestation on all messages, may take a moment...
> ---
>   ✗ [PATCH v5 1/6] dt-bindings: media: renesas,vin: Add Gen4 family fallback
>   ✗ [PATCH v5 2/6] arm64: dts: renesas: r8a779g0: Add family fallback for VIN IP
>     + Acked-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)
>   ✗ [PATCH v5 3/6] arm64: dts: renesas: r8a779a0: Add family fallback for VIN IP
>   ✗ [PATCH v5 4/6] media: rcar-vin: Add family compatible for R-Car Gen4 family
>   ✗ [PATCH v5 5/6] dt-bindings: media: renesas,vin: Add binding for V4M
>   ✗ [PATCH v5 6/6] arm64: dts: renesas: r8a779h0: Add family fallback for VIN IP
>     + Acked-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)
> 
> I cannot find these Acks in my inbox or on lore.
> What's happening?

No idea, I can't find any Acks from Conner in my inbox neither. Both 
patches in question where new in v4 of the series.