| Message ID | 20231030100022.9262-1-moudy.ho@mediatek.com |
|---|---|
| Headers | show |
| Series | introduce more MDP3 components in MT8195 | expand |
On Mon, Oct 30, 2023 at 06:00:09PM +0800, Moudy Ho wrote: > Added the configuration for MT8195 RDMA. In comparison to MT8183, it > no longer shares SRAM with RSZ, and there are now preconfigured 5 mbox. > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../bindings/media/mediatek,mdp3-rdma.yaml | 26 ++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > index c043204cf210..504334a76fb3 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > @@ -22,6 +22,7 @@ properties: > compatible: > enum: > - mediatek,mt8183-mdp3-rdma > + - mediatek,mt8195-mdp3-rdma > - mediatek,mt8195-vdo1-rdma > > reg: > @@ -58,7 +59,7 @@ properties: > > mboxes: > minItems: 1 > - maxItems: 2 > + maxItems: 5 > > interrupts: > maxItems: 1 > @@ -98,6 +99,29 @@ allOf: > - mboxes > - mediatek,gce-events > > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt8195-mdp3-rdma > + > + then: > + properties: > + clocks: > + items: > + - description: RDMA clock > + > + mboxes: > + items: > + - description: used for 1st data pipe from RDMA > + - description: used for 2nd data pipe from RDMA > + - description: used for 3rd data pipe from RDMA > + - description: used for 4th data pipe from RDMA > + - description: used for the data pipe from SPLIT Following the prior comments, add these entries to the top-level 'mboxes' and then here just put 'minItems: 5'. Rob
On Mon, 2023-10-30 at 14:26 -0500, Rob Herring wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > On Mon, 30 Oct 2023 18:00:22 +0800, Moudy Ho wrote: > > Add a compatible string for the PADDING block in MediaTek MT8195 > that > > is controlled by MDP3. > > > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > > --- > > .../bindings/display/mediatek/mediatek,padding.yaml | 4 > +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > Acked-by: Rob Herring <robh@kernel.org> > Hi Robe, I apologize for not noticing the changes in the dependent patch and failing to update one compatible name. I will remove the ACK tage and would appreciate your help in reviewing it again in the next version. Sincerely, Moudy
Changes since v7: - Rebase on linux-next. - Dependent dtsi files: https://patchwork.kernel.org/project/linux-mediatek/list/?series=797543 - Depends on: Message ID = 20231024130048.14749-9-shawn.sung@mediatek.com - Correct the bindings of the four components: FG, TCC, TDSHP and HDR. The names of the first three are expanded in the title, and the descriptions of all four have been enhanced. Changes since v6: - Rebase on v6.6-rc5. - Dependent dtsi files: https://patchwork.kernel.org/project/linux-mediatek/list/?series=792079 - Depends on: Message ID = 20231006073831.10402-5-shawn.sung@mediatek.com - Discard splitting RDMA's common properties and instead use 'allOf' to isolate different platform features. - Revise the incorrect properties in FG, HDR, STITCH, TCC and TDAP bindings. - Adding SoC-specific compatible string to components, like WROT and RSZ, that are inherited from MT8183. - Fixed typos in TCC patch and enhancing its hardware description. Changes since v5: - Rebase on v6.6-rc2. - Dependent dtsi files: https://patchwork.kernel.org/project/linux-mediatek/list/?series=786511 - Depends on: Message ID = 20230911074233.31556-5-shawn.sung@mediatek.com - Split out common propertis for RDMA. - Split each component into independent patches. Changes since v4: - Rebase on v6.6-rc1 - Organize identical hardware components into their respective files. Hi, The purpose of this patch is to separate the MDP3-related bindings from the original mailing list mentioned below: https://lore.kernel.org/all/20230208092209.19472-1-moudy.ho@mediatek.com/ Those binding files describe additional components that are present in the mt8195. Moudy Ho (16): dt-bindings: media: mediatek: mdp3: correct RDMA and WROT node with generic names dt-bindings: media: mediatek: mdp3: merge the indentical RDMA under display dt-bindings: media: mediatek: mdp3: add config for MT8195 RDMA dt-bindings: media: mediatek: mdp3: add compatible for MT8195 RSZ dt-bindings: media: mediatek: mdp3: add compatible for MT8195 WROT dt-bindings: media: mediatek: mdp3: add component FG for MT8195 dt-bindings: media: mediatek: mdp3: add component HDR for MT8195 dt-bindings: media: mediatek: mdp3: add component STITCH for MT8195 dt-bindings: media: mediatek: mdp3: add component TCC for MT8195 dt-bindings: media: mediatek: mdp3: add component TDSHP for MT8195 dt-bindings: display: mediatek: aal: add compatible for MT8195 dt-bindings: display: mediatek: color: add compatible for MT8195 dt-bindings: display: mediatek: merge: add compatible for MT8195 dt-bindings: display: mediatek: ovl: add compatible for MT8195 dt-bindings: display: mediatek: split: add compatible for MT8195 dt-bindings: display: mediatek: padding: add compatible for MT8195 .../display/mediatek/mediatek,aal.yaml | 1 + .../display/mediatek/mediatek,color.yaml | 1 + .../display/mediatek/mediatek,mdp-rdma.yaml | 88 -------------- .../display/mediatek/mediatek,merge.yaml | 1 + .../display/mediatek/mediatek,ovl.yaml | 1 + .../display/mediatek/mediatek,padding.yaml | 4 +- .../display/mediatek/mediatek,split.yaml | 27 +++++ .../bindings/media/mediatek,mdp3-fg.yaml | 61 ++++++++++ .../bindings/media/mediatek,mdp3-hdr.yaml | 61 ++++++++++ .../bindings/media/mediatek,mdp3-rdma.yaml | 108 ++++++++++++++---- .../bindings/media/mediatek,mdp3-rsz.yaml | 6 +- .../bindings/media/mediatek,mdp3-stitch.yaml | 61 ++++++++++ .../bindings/media/mediatek,mdp3-tcc.yaml | 62 ++++++++++ .../bindings/media/mediatek,mdp3-tdshp.yaml | 61 ++++++++++ .../bindings/media/mediatek,mdp3-wrot.yaml | 29 +++-- 15 files changed, 450 insertions(+), 122 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,mdp-rdma.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-stitch.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml create mode 100644 Documentation/devicetree/bindings/media/mediatek,mdp3-tdshp.yaml