mbox series

[-next,0/2] media: platform: Do not check for 0 return after calling platform_get_irq()

Message ID 20230803024645.2716057-1-ruanjinjie@huawei.com
Headers show
Series media: platform: Do not check for 0 return after calling platform_get_irq() | expand

Message

Jinjie Ruan Aug. 3, 2023, 2:46 a.m. UTC
There is no possible for platform_get_irq() and platform_get_irq_byname() 
to return 0,

And the return value of platform_get_irq() or platform_get_irq_byname() 
is more sensible to show the error reason.

Ruan Jinjie (2):
  media: camif-core: Do not check for 0 return after calling
    platform_get_irq()
  media: verisilicon: Do not check for 0 return after calling
    platform_get_irq()

 drivers/media/platform/samsung/s3c-camif/camif-core.c | 4 ++--
 drivers/media/platform/verisilicon/hantro_drv.c       | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Andi Shyti Aug. 5, 2023, 9:40 p.m. UTC | #1
Hi Ruan,

On Thu, Aug 03, 2023 at 10:46:44AM +0800, Ruan Jinjie wrote:
> It is not possible for platform_get_irq() to return 0. Use the
> return value from platform_get_irq().
> 
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Reviewed-by: Andi Shyti <andi.shyti@kernel.org> 

Thanks,
Andi