| Message ID | 20230407133852.2850145-1-luca.ceresoli@bootlin.com |
|---|---|
| Headers | show |
| Series | Add Tegra20 parallel video input capture | expand |
Hello Hans, On Fri, 7 Apr 2023 15:38:32 +0200 Luca Ceresoli <luca.ceresoli@bootlin.com> wrote: > New in v5: dropped the patch that was removing lots of the logic behind > enum_format, after discussion with Hans. The rest is unmodified except for > rebasing and fixing a couple typos in comments. > > Full details follow. > > Tegra20 and other Tegra SoCs have a video input (VI) peripheral that can > receive from either MIPI CSI-2 or parallel video (called respectively "CSI" > and "VIP" in the documentation). The kernel currently has a staging driver > for Tegra210 CSI capture. This patch set adds support for Tegra20 VIP > capture. > > Unfortunately I had no real documentation available to base this work on. > I only had a working downstream 3.1 kernel, so I started with the driver > found there and heavily reworked it to fit into the mainline tegra-video > driver structure. The existing code appears written with the intent of > being modular and allow adding new input mechanisms and new SoCs while > keeping a unique VI core module. However its modularity and extensibility > was not enough to add Tegra20 VIP support, so I added some hooks to turn > hard-coded behaviour into per-SoC or per-bus customizable code. There are > also a fix, some generic cleanups and DT bindings. > > Quick tour of the patches: > > * Device tree bindings > > 01. dt-bindings: display: tegra: add Tegra20 VIP > 02. dt-bindings: display: tegra: vi: add 'vip' property and example > > * Minor improvements to logging, comments, cleanups > > 03. staging: media: tegra-video: improve documentation of tegra_video_format fields > 04. staging: media: tegra-video: document tegra_channel_get_remote_source_subdev > 05. staging: media: tegra-video: fix typos in comment > 06. staging: media: tegra-video: improve error messages > 07. staging: media: tegra-video: slightly simplify cleanup on errors > 08. staging: media: tegra-video: move private struct declaration to C file > 09. staging: media: tegra-video: move tegra210_csi_soc to C file > 10. staging: media: tegra-video: remove unneeded include > > * Preparation to make the VI module generic enough to host Tegra20 and VIP > > 11. staging: media: tegra-video: Kconfig: allow TPG only on Tegra210 > 12. staging: media: tegra-video: move tegra_channel_fmt_align to a per-soc op > 13. staging: media: tegra-video: move default format to soc-specific data > 14. staging: media: tegra-video: move MIPI calibration calls from VI to CSI > 15. staging: media: tegra-video: add a per-soc enable/disable op > 16. staging: media: tegra-video: move syncpt init/free to a per-soc op > 17. staging: media: tegra-video: add syncpts for Tegra20 to struct tegra_vi > 18. staging: media: tegra-video: add hooks for planar YUV and H/V flip > 19. staging: media: tegra-video: add H/V flip controls > > * Implementation of VIP and Tegra20 > > 20. staging: media: tegra-video: add support for Tegra20 parallel input > > Enjoy! > > Changed in v5: > - removed patch 3 as requested by Hans Verkuil; now the driver is kept > video-node-centric and the enum_format logic is unchanged > - rebased on top of that > - trivial fixes (typos) According to your review of v4, removing patch 3 was the only change required, and I didn't do anything else, and there have been no big changes since v1 anyway, so I was wondering whether this series has any hope to make it for 6.4... Best regards, Luca
On 12/04/2023 11:16, Luca Ceresoli wrote: > Hello Hans, > > On Fri, 7 Apr 2023 15:38:32 +0200 > Luca Ceresoli <luca.ceresoli@bootlin.com> wrote: > >> New in v5: dropped the patch that was removing lots of the logic behind >> enum_format, after discussion with Hans. The rest is unmodified except for >> rebasing and fixing a couple typos in comments. >> >> Full details follow. >> >> Tegra20 and other Tegra SoCs have a video input (VI) peripheral that can >> receive from either MIPI CSI-2 or parallel video (called respectively "CSI" >> and "VIP" in the documentation). The kernel currently has a staging driver >> for Tegra210 CSI capture. This patch set adds support for Tegra20 VIP >> capture. >> >> Unfortunately I had no real documentation available to base this work on. >> I only had a working downstream 3.1 kernel, so I started with the driver >> found there and heavily reworked it to fit into the mainline tegra-video >> driver structure. The existing code appears written with the intent of >> being modular and allow adding new input mechanisms and new SoCs while >> keeping a unique VI core module. However its modularity and extensibility >> was not enough to add Tegra20 VIP support, so I added some hooks to turn >> hard-coded behaviour into per-SoC or per-bus customizable code. There are >> also a fix, some generic cleanups and DT bindings. >> >> Quick tour of the patches: >> >> * Device tree bindings >> >> 01. dt-bindings: display: tegra: add Tegra20 VIP >> 02. dt-bindings: display: tegra: vi: add 'vip' property and example >> >> * Minor improvements to logging, comments, cleanups >> >> 03. staging: media: tegra-video: improve documentation of tegra_video_format fields >> 04. staging: media: tegra-video: document tegra_channel_get_remote_source_subdev >> 05. staging: media: tegra-video: fix typos in comment >> 06. staging: media: tegra-video: improve error messages >> 07. staging: media: tegra-video: slightly simplify cleanup on errors >> 08. staging: media: tegra-video: move private struct declaration to C file >> 09. staging: media: tegra-video: move tegra210_csi_soc to C file >> 10. staging: media: tegra-video: remove unneeded include >> >> * Preparation to make the VI module generic enough to host Tegra20 and VIP >> >> 11. staging: media: tegra-video: Kconfig: allow TPG only on Tegra210 >> 12. staging: media: tegra-video: move tegra_channel_fmt_align to a per-soc op >> 13. staging: media: tegra-video: move default format to soc-specific data >> 14. staging: media: tegra-video: move MIPI calibration calls from VI to CSI >> 15. staging: media: tegra-video: add a per-soc enable/disable op >> 16. staging: media: tegra-video: move syncpt init/free to a per-soc op >> 17. staging: media: tegra-video: add syncpts for Tegra20 to struct tegra_vi >> 18. staging: media: tegra-video: add hooks for planar YUV and H/V flip >> 19. staging: media: tegra-video: add H/V flip controls >> >> * Implementation of VIP and Tegra20 >> >> 20. staging: media: tegra-video: add support for Tegra20 parallel input >> >> Enjoy! >> >> Changed in v5: >> - removed patch 3 as requested by Hans Verkuil; now the driver is kept >> video-node-centric and the enum_format logic is unchanged >> - rebased on top of that >> - trivial fixes (typos) > > According to your review of v4, removing patch 3 was the only change > required, and I didn't do anything else, and there have been no big > changes since v1 anyway, so I was wondering whether this series has any > hope to make it for 6.4... It's borderline. I first need to test it again, and I can do that Friday at the earliest (if I find the time). I'll try, but no promises... Regards, Hans
New in v5: dropped the patch that was removing lots of the logic behind enum_format, after discussion with Hans. The rest is unmodified except for rebasing and fixing a couple typos in comments. Full details follow. Tegra20 and other Tegra SoCs have a video input (VI) peripheral that can receive from either MIPI CSI-2 or parallel video (called respectively "CSI" and "VIP" in the documentation). The kernel currently has a staging driver for Tegra210 CSI capture. This patch set adds support for Tegra20 VIP capture. Unfortunately I had no real documentation available to base this work on. I only had a working downstream 3.1 kernel, so I started with the driver found there and heavily reworked it to fit into the mainline tegra-video driver structure. The existing code appears written with the intent of being modular and allow adding new input mechanisms and new SoCs while keeping a unique VI core module. However its modularity and extensibility was not enough to add Tegra20 VIP support, so I added some hooks to turn hard-coded behaviour into per-SoC or per-bus customizable code. There are also a fix, some generic cleanups and DT bindings. Quick tour of the patches: * Device tree bindings 01. dt-bindings: display: tegra: add Tegra20 VIP 02. dt-bindings: display: tegra: vi: add 'vip' property and example * Minor improvements to logging, comments, cleanups 03. staging: media: tegra-video: improve documentation of tegra_video_format fields 04. staging: media: tegra-video: document tegra_channel_get_remote_source_subdev 05. staging: media: tegra-video: fix typos in comment 06. staging: media: tegra-video: improve error messages 07. staging: media: tegra-video: slightly simplify cleanup on errors 08. staging: media: tegra-video: move private struct declaration to C file 09. staging: media: tegra-video: move tegra210_csi_soc to C file 10. staging: media: tegra-video: remove unneeded include * Preparation to make the VI module generic enough to host Tegra20 and VIP 11. staging: media: tegra-video: Kconfig: allow TPG only on Tegra210 12. staging: media: tegra-video: move tegra_channel_fmt_align to a per-soc op 13. staging: media: tegra-video: move default format to soc-specific data 14. staging: media: tegra-video: move MIPI calibration calls from VI to CSI 15. staging: media: tegra-video: add a per-soc enable/disable op 16. staging: media: tegra-video: move syncpt init/free to a per-soc op 17. staging: media: tegra-video: add syncpts for Tegra20 to struct tegra_vi 18. staging: media: tegra-video: add hooks for planar YUV and H/V flip 19. staging: media: tegra-video: add H/V flip controls * Implementation of VIP and Tegra20 20. staging: media: tegra-video: add support for Tegra20 parallel input Enjoy! Changed in v5: - removed patch 3 as requested by Hans Verkuil; now the driver is kept video-node-centric and the enum_format logic is unchanged - rebased on top of that - trivial fixes (typos) Changed in RESEND,v4: - add Rob's review tag on patch 2 Changed in v4: - fixed the leftovers after the removal of 'channel@0' in DT - added review tags by Dimtry Changed in v3: - removed the 'channel@0' node from the device tree representation of vip - squashed the last two patches (VIP + T20) into one - small cleanups - rebase on v6.2-rc1 Changed in v2: - improved dt-bindings patches based on reviews - removed patches 3 and 4 adding DT labels without a mainline user - two small fixes to the last patch [v4,resend] https://lore.kernel.org/linux-tegra/20230309144320.2937553-1-luca.ceresoli@bootlin.com/ [v4] https://lore.kernel.org/linux-tegra/20230130141603.323221-1-luca.ceresoli@bootlin.com/ [v3] https://lore.kernel.org/linux-media/20221229133205.981397-1-luca.ceresoli@bootlin.com/ [v2] https://lore.kernel.org/linux-tegra/20221222100328.6e341874@booty/T/#t [v1] https://lore.kernel.org/linux-tegra/20221124155634.5bc2a423@booty/T/#t Luca Luca Ceresoli (20): dt-bindings: display: tegra: add Tegra20 VIP dt-bindings: display: tegra: vi: add 'vip' property and example staging: media: tegra-video: improve documentation of tegra_video_format fields staging: media: tegra-video: document tegra_channel_get_remote_source_subdev staging: media: tegra-video: fix typos in comment staging: media: tegra-video: improve error messages staging: media: tegra-video: slightly simplify cleanup on errors staging: media: tegra-video: move private struct declaration to C file staging: media: tegra-video: move tegra210_csi_soc to C file staging: media: tegra-video: remove unneeded include staging: media: tegra-video: Kconfig: allow TPG only on Tegra210 staging: media: tegra-video: move tegra_channel_fmt_align to a per-soc op staging: media: tegra-video: move default format to soc-specific data staging: media: tegra-video: move MIPI calibration calls from VI to CSI staging: media: tegra-video: add a per-soc enable/disable op staging: media: tegra-video: move syncpt init/free to a per-soc op staging: media: tegra-video: add syncpts for Tegra20 to struct tegra_vi staging: media: tegra-video: add hooks for planar YUV and H/V flip staging: media: tegra-video: add H/V flip controls staging: media: tegra-video: add support for Tegra20 parallel input .../display/tegra/nvidia,tegra20-vi.yaml | 59 ++ .../display/tegra/nvidia,tegra20-vip.yaml | 41 ++ MAINTAINERS | 3 + drivers/staging/media/tegra-video/Kconfig | 1 + drivers/staging/media/tegra-video/Makefile | 2 + drivers/staging/media/tegra-video/csi.c | 48 ++ drivers/staging/media/tegra-video/csi.h | 4 - drivers/staging/media/tegra-video/tegra20.c | 661 ++++++++++++++++++ drivers/staging/media/tegra-video/tegra210.c | 90 +++ drivers/staging/media/tegra-video/vi.c | 222 ++---- drivers/staging/media/tegra-video/vi.h | 71 +- drivers/staging/media/tegra-video/video.c | 5 + drivers/staging/media/tegra-video/video.h | 2 +- drivers/staging/media/tegra-video/vip.c | 290 ++++++++ drivers/staging/media/tegra-video/vip.h | 68 ++ 15 files changed, 1380 insertions(+), 187 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml create mode 100644 drivers/staging/media/tegra-video/tegra20.c create mode 100644 drivers/staging/media/tegra-video/vip.c create mode 100644 drivers/staging/media/tegra-video/vip.h