mbox series

[v2,0/2] media: i2c: adv7604: Fix handling of video adjustments

Message ID 20230325205610.22583-1-laurent.pinchart+renesas@ideasonboard.com
Headers show
Series media: i2c: adv7604: Fix handling of video adjustments | expand

Message

Laurent Pinchart March 25, 2023, 8:56 p.m. UTC 
Hello,

This small series fixes two issues with video adjustments (brightness,
contrast, saturation and hue) in the adv7604 driver. Patch 1/2 makes
those controls effective (they currently have no effect), and patch 2/2
fixes the range of the hue control.

I have successfully tested the series with an ADV7612, and Hans with the
ADV7604. The ADV7604 and ADV7611 documentation of the hue control
differs from the ADV7612, but I believe that's because earlier
documentation was incorrect.

In patch 2/2 I've decided to represent the hue value as an unsigned
8-bit integer, mapping to the [0°, 360°[ range. Using a signed value
would map to the [-180°, 180°[ range instead, without making any other
difference (and without requiring any modification to the patch other
than changing the range). I don't have a strong preference between the
two options, and I'm pretty sure we can freely pick one without any fear
of an impact on existing userspace applications as patch 1/2 shows that
the hue control has currently no effect.

Compared to v1, this version fixes a typo in the commit message of patch
2/2.

Laurent Pinchart (2):
  media: i2c: adv7604: Enable video adjustment
  media: i2c: adv7604: Fix range of hue control

 drivers/media/i2c/adv7604.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)