| Message ID | 20230221145906.8113-1-hdegoede@redhat.com |
|---|---|
| Headers | show |
| Series | media: atomisp: Remove depth-mode and continuous mode support | expand |
Em Tue, 21 Feb 2023 15:58:56 +0100 Hans de Goede <hdegoede@redhat.com> escreveu: > Hi All, > > This is the first step of the removal of special/obscure features > discussed here: > > https://lore.kernel.org/linux-media/ea81b17b-7d1f-a5e1-11dd-04db310e1e50@redhat.com/ > > Plus some follow-up patches removing some dead code (some new dead > code as well as some pre-existing dead code). Nice cleanup. Yeah, I was considering doing this for some time, as those "extra" modes are meant to be used only on Android. Regards, Mauro > > Regards, > > Hans > > > Hans de Goede (10): > media: atomisp: Remove depth-mode support > media: atomisp: Remove continuous mode support > media: atomisp: Remove delayed_init related code > media: atomisp: Remove crop_needs_override from atomisp_set_fmt() > media: atomisp: Remove atomisp_css_enable_raw_binning() > media: atomisp: Remove atomisp_get_metadata_type() > media: atomisp: Remove unused SOC_CAMERA, XENON_FLASH and FILE_INPUT > subdev types > media: atomisp: Remove ATOMISP_USE_YUVPP() > media: atomisp: Remove yuvpp_mode > media: atomisp: Remove online_process setting > > .../media/atomisp/include/linux/atomisp.h | 26 - > .../atomisp/include/linux/atomisp_platform.h | 9 +- > .../staging/media/atomisp/pci/atomisp_cmd.c | 744 ++---------------- > .../staging/media/atomisp/pci/atomisp_cmd.h | 9 - > .../media/atomisp/pci/atomisp_compat.h | 7 - > .../media/atomisp/pci/atomisp_compat_css20.c | 321 +------- > .../staging/media/atomisp/pci/atomisp_fops.c | 110 +-- > .../media/atomisp/pci/atomisp_internal.h | 21 - > .../staging/media/atomisp/pci/atomisp_ioctl.c | 162 +--- > .../staging/media/atomisp/pci/atomisp_ioctl.h | 3 - > .../media/atomisp/pci/atomisp_subdev.c | 78 +- > .../media/atomisp/pci/atomisp_subdev.h | 16 - > .../staging/media/atomisp/pci/atomisp_v4l2.c | 35 +- > 13 files changed, 129 insertions(+), 1412 deletions(-) > Thanks, Mauro
Hi, On 2/21/23 17:00, Andy Shevchenko wrote: > On Tue, Feb 21, 2023 at 03:59:00PM +0100, Hans de Goede wrote: >> Remove the crop_needs_override local helper variable from >> atomisp_set_fmt(), as it always is true now. > > ... > >> + sink_crop.width = DIV_NEAREST_STEP( >> + sink_crop.height * >> + f->fmt.pix.width, >> + f->fmt.pix.height, >> + ATOM_ISP_STEP_WIDTH); > > Not sure how long this code stays, I would indent it as > > sink_crop.width = > DIV_NEAREST_STEP(sink_crop.height * > f->fmt.pix.width, > f->fmt.pix.height, > ATOM_ISP_STEP_WIDTH); Thanks, I've gone with: sink_crop.width = DIV_NEAREST_STEP(sink_crop.height * f->fmt.pix.width, f->fmt.pix.height, ATOM_ISP_STEP_WIDTH); Keeping the first DIV_NEAREST_STEP() argument on a single line. > > ... > >> + sink_crop.height = DIV_NEAREST_STEP( >> + sink_crop.width * >> + f->fmt.pix.height, >> + f->fmt.pix.width, >> + ATOM_ISP_STEP_HEIGHT); > > Ditto. Ditto :) Regards, Hans
Hi, On 2/21/23 17:04, Andy Shevchenko wrote: > On Tue, Feb 21, 2023 at 03:58:56PM +0100, Hans de Goede wrote: >> Hi All, >> >> This is the first step of the removal of special/obscure features >> discussed here: >> >> https://lore.kernel.org/linux-media/ea81b17b-7d1f-a5e1-11dd-04db310e1e50@redhat.com/ >> >> Plus some follow-up patches removing some dead code (some new dead >> code as well as some pre-existing dead code). > > As usual for non-commented > Reviewed-by: Andy Shevchenko <andy@kernel.org> Thanks! I have just pushed this series to: https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp Adding your Reviewed-by to 8/10 patches and addressing your remarks (except for the switch-case thing) in the other 2 patches. Let me know if you are ok with / want me to add your Reviewed-by to the other 2 patches. Regards, Hans
Hi All, This is the first step of the removal of special/obscure features discussed here: https://lore.kernel.org/linux-media/ea81b17b-7d1f-a5e1-11dd-04db310e1e50@redhat.com/ Plus some follow-up patches removing some dead code (some new dead code as well as some pre-existing dead code). Regards, Hans Hans de Goede (10): media: atomisp: Remove depth-mode support media: atomisp: Remove continuous mode support media: atomisp: Remove delayed_init related code media: atomisp: Remove crop_needs_override from atomisp_set_fmt() media: atomisp: Remove atomisp_css_enable_raw_binning() media: atomisp: Remove atomisp_get_metadata_type() media: atomisp: Remove unused SOC_CAMERA, XENON_FLASH and FILE_INPUT subdev types media: atomisp: Remove ATOMISP_USE_YUVPP() media: atomisp: Remove yuvpp_mode media: atomisp: Remove online_process setting .../media/atomisp/include/linux/atomisp.h | 26 - .../atomisp/include/linux/atomisp_platform.h | 9 +- .../staging/media/atomisp/pci/atomisp_cmd.c | 744 ++---------------- .../staging/media/atomisp/pci/atomisp_cmd.h | 9 - .../media/atomisp/pci/atomisp_compat.h | 7 - .../media/atomisp/pci/atomisp_compat_css20.c | 321 +------- .../staging/media/atomisp/pci/atomisp_fops.c | 110 +-- .../media/atomisp/pci/atomisp_internal.h | 21 - .../staging/media/atomisp/pci/atomisp_ioctl.c | 162 +--- .../staging/media/atomisp/pci/atomisp_ioctl.h | 3 - .../media/atomisp/pci/atomisp_subdev.c | 78 +- .../media/atomisp/pci/atomisp_subdev.h | 16 - .../staging/media/atomisp/pci/atomisp_v4l2.c | 35 +- 13 files changed, 129 insertions(+), 1412 deletions(-)