| Message ID | 20230207091902.2512905-1-milkfafa@gmail.com |
|---|---|
| Headers | show |
| Series | Support Nuvoton NPCM Video Capture/Encode Engine | expand |
Hi Marvin, Some review comments below: On 07/02/2023 10:19, Marvin Lin wrote: > Add driver for Video Capture/Differentiation Engine (VCD) and Encoding > Compression Engine (ECE) present on Nuvoton NPCM SoCs. As described in > the datasheet NPCM750D_DS_Rev_1.0, the VCD can capture a frame from > digital video input and compare two frames in memory, and then the ECE > can compress the frame data into HEXTITLE format. This driver implements > V4L2 interfaces and provides user controls to support KVM feature, also > tested with VNC Viewer ver.6.22.826 and openbmc/obmc-ikvm. > > Signed-off-by: Marvin Lin <milkfafa@gmail.com> > --- > MAINTAINERS | 12 + > drivers/media/platform/Kconfig | 1 + > drivers/media/platform/Makefile | 1 + > drivers/media/platform/nuvoton/Kconfig | 15 + > drivers/media/platform/nuvoton/Makefile | 2 + > drivers/media/platform/nuvoton/npcm-regs.h | 171 ++ > drivers/media/platform/nuvoton/npcm-video.c | 1816 +++++++++++++++++++ > 7 files changed, 2018 insertions(+) > create mode 100644 drivers/media/platform/nuvoton/Kconfig > create mode 100644 drivers/media/platform/nuvoton/Makefile > create mode 100644 drivers/media/platform/nuvoton/npcm-regs.h > create mode 100644 drivers/media/platform/nuvoton/npcm-video.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8a5c25c20d00..c32c1697df72 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2602,6 +2602,18 @@ F: drivers/rtc/rtc-nct3018y.c > F: include/dt-bindings/clock/nuvoton,npcm7xx-clock.h > F: include/dt-bindings/clock/nuvoton,npcm845-clk.h > > +ARM/NUVOTON NPCM VIDEO ENGINE DRIVER > +M: Joseph Liu <kwliu@nuvoton.com> > +M: Marvin Lin <kflin@nuvoton.com> > +L: linux-media@vger.kernel.org > +L: openbmc@lists.ozlabs.org (moderated for non-subscribers) > +S: Maintained > +F: Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml > +F: Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml > +F: Documentation/userspace-api/media/drivers/npcm-video.rst > +F: drivers/media/platform/nuvoton/ > +F: include/uapi/linux/npcm-video.h > + > ARM/NUVOTON WPCM450 ARCHITECTURE > M: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > L: openbmc@lists.ozlabs.org (moderated for non-subscribers) > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index ee579916f874..91e54215de3a 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -73,6 +73,7 @@ source "drivers/media/platform/intel/Kconfig" > source "drivers/media/platform/marvell/Kconfig" > source "drivers/media/platform/mediatek/Kconfig" > source "drivers/media/platform/microchip/Kconfig" > +source "drivers/media/platform/nuvoton/Kconfig" > source "drivers/media/platform/nvidia/Kconfig" > source "drivers/media/platform/nxp/Kconfig" > source "drivers/media/platform/qcom/Kconfig" > diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile > index 5453bb868e67..3296ec1ebe16 100644 > --- a/drivers/media/platform/Makefile > +++ b/drivers/media/platform/Makefile > @@ -16,6 +16,7 @@ obj-y += intel/ > obj-y += marvell/ > obj-y += mediatek/ > obj-y += microchip/ > +obj-y += nuvoton/ > obj-y += nvidia/ > obj-y += nxp/ > obj-y += qcom/ > diff --git a/drivers/media/platform/nuvoton/Kconfig b/drivers/media/platform/nuvoton/Kconfig > new file mode 100644 > index 000000000000..1dc8fa836821 > --- /dev/null > +++ b/drivers/media/platform/nuvoton/Kconfig > @@ -0,0 +1,15 @@ > +# SPDX-License-Identifier: GPL-2.0-only > + > +comment "Nuvoton media platform drivers" > + > +config VIDEO_NPCM_VCD_ECE > + tristate "Nuvoton NPCM Video Capture/Encode Engine driver" > + depends on V4L_PLATFORM_DRIVERS > + depends on VIDEO_DEV > + select VIDEOBUF2_DMA_CONTIG > + help > + Support for the Video Capture/Differentiation Engine (VCD) and > + Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs. > + The VCD can capture a frame from digital video input and compare > + two frames in memory, and then the ECE can compress the frame > + data into HEXTITLE format. > diff --git a/drivers/media/platform/nuvoton/Makefile b/drivers/media/platform/nuvoton/Makefile > new file mode 100644 > index 000000000000..74a4e3fc8555 > --- /dev/null > +++ b/drivers/media/platform/nuvoton/Makefile > @@ -0,0 +1,2 @@ > +# SPDX-License-Identifier: GPL-2.0-only > +obj-$(CONFIG_VIDEO_NPCM_VCD_ECE) += npcm-video.o > diff --git a/drivers/media/platform/nuvoton/npcm-regs.h b/drivers/media/platform/nuvoton/npcm-regs.h > new file mode 100644 > index 000000000000..f528f5726307 > --- /dev/null > +++ b/drivers/media/platform/nuvoton/npcm-regs.h > @@ -0,0 +1,171 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Register definition header for NPCM video driver > + * > + * Copyright (C) 2022 Nuvoton Technologies > + */ > + > +#ifndef _NPCM_REGS_H > +#define _NPCM_REGS_H > + > +/* VCD Registers */ > +#define VCD_DIFF_TBL 0x0000 > +#define VCD_FBA_ADR 0x8000 > +#define VCD_FBB_ADR 0x8004 > + > +#define VCD_FB_LP 0x8008 > +#define VCD_FBA_LP GENMASK(15, 0) > +#define VCD_FBB_LP GENMASK(31, 16) > + > +#define VCD_CAP_RES 0x800c > +#define VCD_CAP_RES_VERT_RES GENMASK(10, 0) > +#define VCD_CAP_RES_HOR_RES GENMASK(26, 16) > + > +#define VCD_MODE 0x8014 > +#define VCD_MODE_VCDE BIT(0) > +#define VCD_MODE_CM565 BIT(1) > +#define VCD_MODE_IDBC BIT(3) > +#define VCD_MODE_COLOR_CNVRT GENMASK(5, 4) > +#define VCD_MODE_COLOR_CNVRT_NO_CNVRT 0 > +#define VCD_MODE_COLOR_CNVRT_RGB_222 1 > +#define VCD_MODE_COLOR_CNVRT_666_MODE 2 > +#define VCD_MODE_COLOR_CNVRT_RGB_888 3 > +#define VCD_MODE_KVM_BW_SET BIT(16) > + > +#define VCD_CMD 0x8018 > +#define VCD_CMD_GO BIT(0) > +#define VCD_CMD_RST BIT(1) > +#define VCD_CMD_OPERATION GENMASK(6, 4) > +#define VCD_CMD_OPERATION_CAPTURE 0 > +#define VCD_CMD_OPERATION_COMPARE 2 > + > +#define VCD_STAT 0x801c > +#define VCD_STAT_DONE BIT(0) > +#define VCD_STAT_IFOT BIT(2) > +#define VCD_STAT_IFOR BIT(3) > +#define VCD_STAT_BUSY BIT(30) > +#define VCD_STAT_CLEAR 0x3fff > + > +#define VCD_INTE 0x8020 > +#define VCD_INTE_DONE_IE BIT(0) > +#define VCD_INTE_IFOT_IE BIT(2) > +#define VCD_INTE_IFOR_IE BIT(3) > + > +#define VCD_RCHG 0x8028 > +#define VCD_RCHG_TIM_PRSCL GENMASK(12, 9) > + > +#define VCD_FIFO 0x805c > +#define VCD_FIFO_TH 0x100350ff > + > +#define VCD_MAX_SRC_BUFFER_SIZE 0x500000 /* 1920 x 1200 x 2 bpp */ > +#define VCD_KVM_BW_PCLK 120000000UL > +#define VCD_BUSY_TIMEOUT_US 300000 > + > +/* ECE Registers */ > +#define ECE_DDA_CTRL 0x0000 > +#define ECE_DDA_CTRL_ECEEN BIT(0) > +#define ECE_DDA_CTRL_INTEN BIT(8) > + > +#define ECE_DDA_STS 0x0004 > +#define ECE_DDA_STS_CDREADY BIT(8) > +#define ECE_DDA_STS_ACDRDY BIT(10) > + > +#define ECE_FBR_BA 0x0008 > +#define ECE_ED_BA 0x000c > +#define ECE_RECT_XY 0x0010 > + > +#define ECE_RECT_DIMEN 0x0014 > +#define ECE_RECT_DIMEN_WR GENMASK(10, 0) > +#define ECE_RECT_DIMEN_WLTR GENMASK(14, 11) > +#define ECE_RECT_DIMEN_HR GENMASK(26, 16) > +#define ECE_RECT_DIMEN_HLTR GENMASK(30, 27) > + > +#define ECE_RESOL 0x001c > +#define ECE_RESOL_FB_LP_512 0 > +#define ECE_RESOL_FB_LP_1024 1 > +#define ECE_RESOL_FB_LP_2048 2 > +#define ECE_RESOL_FB_LP_2560 3 > +#define ECE_RESOL_FB_LP_4096 4 > + > +#define ECE_HEX_CTRL 0x0040 > +#define ECE_HEX_CTRL_ENCDIS BIT(0) > +#define ECE_HEX_CTRL_ENC_GAP GENMASK(12, 8) > + > +#define ECE_HEX_RECT_OFFSET 0x0048 > +#define ECE_HEX_RECT_OFFSET_MASK GENMASK(22, 0) > + > +#define ECE_TILE_W 16 > +#define ECE_TILE_H 16 > +#define ECE_POLL_TIMEOUT_US 300000 > + > +/* GCR Registers */ > +#define INTCR 0x3c > +#define INTCR_GFXIFDIS GENMASK(9, 8) > +#define INTCR_DEHS BIT(27) > + > +#define INTCR2 0x60 > +#define INTCR2_GIRST2 BIT(2) > +#define INTCR2_GIHCRST BIT(5) > +#define INTCR2_GIVCRST BIT(6) > + > +#define INTCR3 0x9c > +#define INTCR3_GMMAP GENMASK(10, 8) > +#define INTCR3_GMMAP_128MB 0 > +#define INTCR3_GMMAP_256MB 1 > +#define INTCR3_GMMAP_512MB 2 > +#define INTCR3_GMMAP_1GB 3 > +#define INTCR3_GMMAP_2GB 4 > + > +#define INTCR4 0xc0 > +#define INTCR4_GMMAP GENMASK(22, 16) > +#define INTCR4_GMMAP_512MB 0x1f > +#define INTCR4_GMMAP_512MB_ECC 0x1b > +#define INTCR4_GMMAP_1GB 0x3f > +#define INTCR4_GMMAP_1GB_ECC 0x37 > +#define INTCR4_GMMAP_2GB 0x7f > +#define INTCR4_GMMAP_2GB_ECC 0x6f > + > +#define ADDR_GMMAP_128MB 0x07000000 > +#define ADDR_GMMAP_256MB 0x0f000000 > +#define ADDR_GMMAP_512MB 0x1f000000 > +#define ADDR_GMMAP_512MB_ECC 0x1b000000 > +#define ADDR_GMMAP_1GB 0x3f000000 > +#define ADDR_GMMAP_1GB_ECC 0x37000000 > +#define ADDR_GMMAP_2GB 0x7f000000 > +#define ADDR_GMMAP_2GB_ECC 0x6f000000 > + > +#define GMMAP_LENGTH 0xc00000 /* 4MB preserved, total 16MB */ > + > +#define MFSEL1 0x0c > +#define MFSEL1_DVH1SEL BIT(27) > + > +/* GFXI Register */ > +#define DISPST 0x00 > +#define DISPST_HSCROFF BIT(1) > +#define DISPST_MGAMODE BIT(7) > + > +#define HVCNTL 0x10 > +#define HVCNTL_MASK GENMASK(7, 0) > + > +#define HVCNTH 0x14 > +#define HVCNTH_MASK GENMASK(2, 0) > + > +#define VVCNTL 0x20 > +#define VVCNTL_MASK GENMASK(7, 0) > + > +#define VVCNTH 0x24 > +#define VVCNTH_MASK GENMASK(2, 0) > + > +#define GPLLINDIV 0x40 > +#define GPLLINDIV_MASK GENMASK(5, 0) > +#define GPLLINDIV_GPLLFBDV8 BIT(7) > + > +#define GPLLFBDIV 0x44 > +#define GPLLFBDIV_MASK GENMASK(7, 0) > + > +#define GPLLST 0x48 > +#define GPLLST_PLLOTDIV1 GENMASK(2, 0) > +#define GPLLST_PLLOTDIV2 GENMASK(5, 3) > +#define GPLLST_GPLLFBDV109 GENMASK(7, 6) > + > +#endif /* _NPCM_REGS_H */ > diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/platform/nuvoton/npcm-video.c > new file mode 100644 > index 000000000000..739311d45e8b > --- /dev/null > +++ b/drivers/media/platform/nuvoton/npcm-video.c > @@ -0,0 +1,1816 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Driver for Video Capture/Differentiation Engine (VCD) and Encoding > + * Compression Engine (ECE) present on Nuvoton NPCM SoCs. > + * > + * Copyright (C) 2022 Nuvoton Technologies > + */ > + > +#include <linux/atomic.h> > +#include <linux/bitfield.h> > +#include <linux/bitmap.h> > +#include <linux/clk.h> > +#include <linux/delay.h> > +#include <linux/device.h> > +#include <linux/dma-mapping.h> > +#include <linux/interrupt.h> > +#include <linux/jiffies.h> > +#include <linux/mfd/syscon.h> > +#include <linux/module.h> > +#include <linux/mutex.h> > +#include <linux/of.h> > +#include <linux/of_irq.h> > +#include <linux/of_platform.h> > +#include <linux/of_reserved_mem.h> > +#include <linux/platform_device.h> > +#include <linux/regmap.h> > +#include <linux/reset.h> > +#include <linux/sched.h> > +#include <linux/spinlock.h> > +#include <linux/string.h> > +#include <linux/v4l2-controls.h> > +#include <linux/videodev2.h> > +#include <linux/wait.h> > +#include <linux/workqueue.h> > +#include <media/v4l2-ctrls.h> > +#include <media/v4l2-dev.h> > +#include <media/v4l2-device.h> > +#include <media/v4l2-dv-timings.h> > +#include <media/v4l2-event.h> > +#include <media/v4l2-ioctl.h> > +#include <media/videobuf2-dma-contig.h> > +#include <uapi/linux/npcm-video.h> > +#include "npcm-regs.h" > + > +#define DEVICE_NAME "npcm-video" > +#define MAX_FRAME_RATE 60 > +#define MAX_WIDTH 1920 > +#define MAX_HEIGHT 1200 > +#define MIN_WIDTH 320 > +#define MIN_HEIGHT 240 > +#define MIN_LP 512 > +#define MAX_LP 4096 > +#define RECT_W 16 > +#define RECT_H 16 > +#define BITMAP_SIZE 32 > + > +struct npcm_video_addr { > + size_t size; > + dma_addr_t dma; > + void *virt; > +}; > + > +struct npcm_video_buffer { > + struct vb2_v4l2_buffer vb; > + struct list_head link; > +}; > + > +#define to_npcm_video_buffer(x) \ > + container_of((x), struct npcm_video_buffer, vb) > + > +enum { > + VIDEO_STREAMING, > + VIDEO_FRAME_INPRG, > + VIDEO_STOPPED, > +}; > + > +struct rect_list { > + struct v4l2_clip clip; > + struct list_head list; > +}; > + > +struct rect_list_info { > + struct rect_list *list; > + struct rect_list *first; > + struct list_head *head; > + unsigned int index; > + unsigned int tile_perline; > + unsigned int tile_perrow; > + unsigned int offset_perline; > + unsigned int tile_size; > + unsigned int tile_cnt; > +}; > + > +struct npcm_ece { > + struct regmap *regmap; > + atomic_t clients; > + struct reset_control *reset; > +}; > + > +struct npcm_video { > + struct regmap *gcr_regmap; > + struct regmap *gfx_regmap; > + struct regmap *vcd_regmap; > + > + struct device *dev; > + struct v4l2_ctrl_handler ctrl_handler; > + struct v4l2_device v4l2_dev; > + struct v4l2_pix_format pix_fmt; > + struct v4l2_bt_timings active_timings; > + struct v4l2_bt_timings detected_timings; > + unsigned int v4l2_input_status; > + struct vb2_queue queue; > + struct video_device vdev; > + struct mutex video_lock; /* v4l2 and videobuf2 lock */ > + > + struct list_head buffers; > + spinlock_t lock; /* buffer list lock */ > + unsigned long flags; > + unsigned int sequence; > + > + size_t max_buffer_size; > + struct npcm_video_addr src; > + struct reset_control *reset; > + struct npcm_ece ece; > + > + unsigned int frame_rate; > + unsigned int vb_index; > + unsigned int bytesperline; > + unsigned int bytesperpixel; > + unsigned int rect_cnt; > + unsigned int num_buffers; > + struct list_head *list; > + unsigned int *rect; > + unsigned int ctrl_cmd; > + unsigned int op_cmd; > +}; > + > +#define to_npcm_video(x) container_of((x), struct npcm_video, v4l2_dev) > + > +static const struct v4l2_dv_timings_cap npcm_video_timings_cap = { > + .type = V4L2_DV_BT_656_1120, > + .bt = { > + .min_width = MIN_WIDTH, > + .max_width = MAX_WIDTH, > + .min_height = MIN_HEIGHT, > + .max_height = MAX_HEIGHT, > + .min_pixelclock = 6574080, /* 640 x 480 x 24Hz */ > + .max_pixelclock = 138240000, /* 1920 x 1200 x 60Hz */ > + .standards = V4L2_DV_BT_STD_CEA861 | V4L2_DV_BT_STD_DMT | > + V4L2_DV_BT_STD_CVT | V4L2_DV_BT_STD_GTF, > + .capabilities = V4L2_DV_BT_CAP_PROGRESSIVE | > + V4L2_DV_BT_CAP_REDUCED_BLANKING | > + V4L2_DV_BT_CAP_CUSTOM, > + }, > +}; > + > +static DECLARE_BITMAP(bitmap, BITMAP_SIZE); > + > +static void npcm_video_ece_prepend_rect_header(void *addr, u16 x, u16 y, u16 w, u16 h) > +{ > + __be16 x_pos = cpu_to_be16(x); > + __be16 y_pos = cpu_to_be16(y); > + __be16 width = cpu_to_be16(w); > + __be16 height = cpu_to_be16(h); > + __be32 encoding = cpu_to_be32(5); /* Hextile encoding */ > + > + memcpy(addr, &x_pos, 2); > + memcpy(addr + 2, &y_pos, 2); > + memcpy(addr + 4, &width, 2); > + memcpy(addr + 6, &height, 2); > + memcpy(addr + 8, &encoding, 4); > +} > + > +static unsigned int npcm_video_ece_get_ed_size(struct npcm_video *video, > + unsigned int offset, void *addr) > +{ > + struct regmap *ece = video->ece.regmap; > + unsigned int size, gap, val; > + int ret; > + > + ret = regmap_read_poll_timeout(ece, ECE_DDA_STS, val, > + (val & ECE_DDA_STS_CDREADY), 0, > + ECE_POLL_TIMEOUT_US); > + > + if (ret) { > + dev_warn(video->dev, "Wait for ECE_DDA_STS_CDREADY timeout\n"); > + return 0; > + } > + > + size = readl(addr + offset); > + regmap_read(ece, ECE_HEX_CTRL, &val); > + gap = FIELD_GET(ECE_HEX_CTRL_ENC_GAP, val); > + > + dev_dbg(video->dev, "offset = %u, ed_size = %u, gap = %u\n", offset, > + size, gap); > + > + return size + gap; > +} > + > +static void npcm_video_ece_enc_rect(struct npcm_video *video, > + unsigned int r_off_x, unsigned int r_off_y, > + unsigned int r_w, unsigned int r_h) > +{ > + struct regmap *ece = video->ece.regmap; > + unsigned int rect_offset = (r_off_y * video->bytesperline) + (r_off_x * 2); > + unsigned int w_size = ECE_TILE_W, h_size = ECE_TILE_H; > + unsigned int temp, w_tile, h_tile; > + > + regmap_update_bits(ece, ECE_DDA_CTRL, ECE_DDA_CTRL_ECEEN, 0); > + regmap_update_bits(ece, ECE_DDA_CTRL, ECE_DDA_CTRL_ECEEN, ECE_DDA_CTRL_ECEEN); > + regmap_write(ece, ECE_DDA_STS, ECE_DDA_STS_CDREADY | ECE_DDA_STS_ACDRDY); > + regmap_write(ece, ECE_RECT_XY, rect_offset); > + > + w_tile = r_w / ECE_TILE_W; > + h_tile = r_h / ECE_TILE_H; > + > + if (r_w % ECE_TILE_W) { > + w_tile += 1; > + w_size = r_w % ECE_TILE_W; > + } > + if (r_h % ECE_TILE_H || !h_tile) { > + h_tile += 1; > + h_size = r_h % ECE_TILE_H; > + } > + > + temp = FIELD_PREP(ECE_RECT_DIMEN_WLTR, w_size - 1) | > + FIELD_PREP(ECE_RECT_DIMEN_HLTR, h_size - 1) | > + FIELD_PREP(ECE_RECT_DIMEN_WR, w_tile - 1) | > + FIELD_PREP(ECE_RECT_DIMEN_HR, h_tile - 1); > + > + regmap_write(ece, ECE_RECT_DIMEN, temp); > +} > + > +static unsigned int npcm_video_ece_read_rect_offset(struct npcm_video *video) > +{ > + struct regmap *ece = video->ece.regmap; > + unsigned int offset; > + > + regmap_read(ece, ECE_HEX_RECT_OFFSET, &offset); > + return FIELD_GET(ECE_HEX_RECT_OFFSET_MASK, offset); > +} > + > +/* > + * Set the line pitch (in bytes) for the frame buffers. > + * Can be on of those values: 512, 1024, 2048, 2560 or 4096 bytes. > + */ > +static void npcm_video_ece_set_lp(struct npcm_video *video, unsigned int pitch) > +{ > + struct regmap *ece = video->ece.regmap; > + unsigned int lp; > + > + switch (pitch) { > + case 512: > + lp = ECE_RESOL_FB_LP_512; > + break; > + case 1024: > + lp = ECE_RESOL_FB_LP_1024; > + break; > + case 2048: > + lp = ECE_RESOL_FB_LP_2048; > + break; > + case 2560: > + lp = ECE_RESOL_FB_LP_2560; > + break; > + case 4096: > + lp = ECE_RESOL_FB_LP_4096; > + break; > + default: > + return; > + } > + > + regmap_write(ece, ECE_RESOL, lp); > +} > + > +static inline void npcm_video_ece_set_fb_addr(struct npcm_video *video, > + unsigned int buffer) > +{ > + struct regmap *ece = video->ece.regmap; > + > + regmap_write(ece, ECE_FBR_BA, buffer); > +} > + > +static inline void npcm_video_ece_set_enc_dba(struct npcm_video *video, > + unsigned int addr) > +{ > + struct regmap *ece = video->ece.regmap; > + > + regmap_write(ece, ECE_ED_BA, addr); > +} > + > +static inline void npcm_video_ece_clear_rect_offset(struct npcm_video *video) > +{ > + struct regmap *ece = video->ece.regmap; > + > + regmap_write(ece, ECE_HEX_RECT_OFFSET, 0); > +} > + > +static void npcm_video_ece_ctrl_reset(struct npcm_video *video) > +{ > + struct regmap *ece = video->ece.regmap; > + > + regmap_update_bits(ece, ECE_DDA_CTRL, ECE_DDA_CTRL_ECEEN, 0); > + regmap_update_bits(ece, ECE_HEX_CTRL, ECE_HEX_CTRL_ENCDIS, ECE_HEX_CTRL_ENCDIS); > + regmap_update_bits(ece, ECE_DDA_CTRL, ECE_DDA_CTRL_ECEEN, ECE_DDA_CTRL_ECEEN); > + regmap_update_bits(ece, ECE_HEX_CTRL, ECE_HEX_CTRL_ENCDIS, 0); > + > + npcm_video_ece_clear_rect_offset(video); > +} > + > +static void npcm_video_ece_ip_reset(struct npcm_video *video) > +{ > + /* > + * After resetting a module and clearing the reset bit, it should wait > + * at least 10 us before accessing the module. > + */ > + reset_control_assert(video->ece.reset); > + usleep_range(10, 20); > + reset_control_deassert(video->ece.reset); > + usleep_range(10, 20); > +} > + > +static inline void npcm_video_ece_init(struct npcm_video *video) > +{ > + npcm_video_ece_ip_reset(video); > + npcm_video_ece_ctrl_reset(video); > +} > + > +static void npcm_video_ece_stop(struct npcm_video *video) > +{ > + struct regmap *ece = video->ece.regmap; > + > + regmap_update_bits(ece, ECE_DDA_CTRL, ECE_DDA_CTRL_ECEEN, 0); > + regmap_update_bits(ece, ECE_DDA_CTRL, ECE_DDA_CTRL_INTEN, 0); > + regmap_update_bits(ece, ECE_HEX_CTRL, ECE_HEX_CTRL_ENCDIS, ECE_HEX_CTRL_ENCDIS); > + npcm_video_ece_clear_rect_offset(video); > +} > + > +static bool npcm_video_alloc_buf(struct npcm_video *video, > + struct npcm_video_addr *addr, size_t size) > +{ > + if (size > VCD_MAX_SRC_BUFFER_SIZE) > + size = VCD_MAX_SRC_BUFFER_SIZE; > + > + addr->virt = dma_alloc_coherent(video->dev, size, &addr->dma, GFP_KERNEL); > + if (!addr->virt) > + return false; > + > + addr->size = size; > + return true; > +} > + > +static void npcm_video_free_buf(struct npcm_video *video, > + struct npcm_video_addr *addr) > +{ > + dma_free_coherent(video->dev, addr->size, addr->virt, addr->dma); > + addr->size = 0; > + addr->dma = 0ULL; > + addr->virt = NULL; > +} > + > +static void npcm_video_free_diff_table(struct npcm_video *video) > +{ > + struct list_head *head, *pos, *nx; > + struct rect_list *tmp; > + unsigned int i; > + > + for (i = 0; i < video->num_buffers; i++) { > + head = &video->list[i]; > + list_for_each_safe(pos, nx, head) { > + tmp = list_entry(pos, struct rect_list, list); > + list_del(&tmp->list); > + kfree(tmp); > + } > + } > +} > + > +static unsigned int npcm_video_add_rect(struct npcm_video *video, unsigned int index, > + unsigned int x, unsigned int y, > + unsigned int w, unsigned int h) > +{ > + struct list_head *head = &video->list[index]; > + struct rect_list *list = NULL; > + struct v4l2_rect *r; > + > + list = kzalloc(sizeof(*list), GFP_KERNEL); > + if (!list) > + return 0; > + > + r = &list->clip.c; > + r->left = x; > + r->top = y; > + r->width = w; > + r->height = h; > + > + list_add_tail(&list->list, head); > + return 1; > +} > + > +static void npcm_video_merge_rect(struct npcm_video *video, > + struct rect_list_info *info) > +{ > + struct list_head *head = info->head; > + struct rect_list *list = info->list, *first = info->first; > + struct v4l2_rect *r = &list->clip.c, *f = &first->clip.c; > + > + if (!first) { > + first = list; > + info->first = first; > + list_add_tail(&list->list, head); > + video->rect_cnt++; > + } else { > + if ((r->left == (f->left + f->width)) && r->top == f->top) { > + f->width += r->width; > + kfree(list); > + } else if ((r->top == (f->top + f->height)) && > + (r->left == f->left)) { > + f->height += r->height; > + kfree(list); > + } else if (((r->top > f->top) && > + (r->top < (f->top + f->height))) && > + ((r->left > f->left) && > + (r->left < (f->left + f->width)))) { > + kfree(list); > + } else { > + list_add_tail(&list->list, head); > + video->rect_cnt++; > + info->first = list; > + } > + } > +} > + > +static struct rect_list *npcm_video_new_rect(struct npcm_video *video, > + unsigned int offset, > + unsigned int index) > +{ > + struct v4l2_bt_timings *act = &video->active_timings; > + struct rect_list *list = NULL; > + struct v4l2_rect *r; > + > + list = kzalloc(sizeof(*list), GFP_KERNEL); > + if (!list) > + return NULL; > + > + r = &list->clip.c; > + > + r->left = (offset << 4); > + r->top = (index >> 2); > + r->width = RECT_W; > + r->height = RECT_H; > + if ((r->left + RECT_W) > act->width) > + r->width = act->width - r->left; > + if ((r->top + RECT_H) > act->height) > + r->height = act->height - r->top; > + > + return list; > +} > + > +static int npcm_video_find_rect(struct npcm_video *video, > + struct rect_list_info *info, unsigned int offset) > +{ > + if (offset < info->tile_perline) { > + info->list = npcm_video_new_rect(video, offset, info->index); > + if (!info->list) { > + dev_err(video->dev, "Failed to allocate rect_list\n"); > + return -ENOMEM; > + } > + > + npcm_video_merge_rect(video, info); > + } > + return 0; > +} > + > +static int npcm_video_build_table(struct npcm_video *video, > + struct rect_list_info *info) > +{ > + struct regmap *vcd = video->vcd_regmap; > + unsigned int j, bit, value; > + int ret; > + > + for (j = 0; j < info->offset_perline; j += 4) { > + regmap_read(vcd, VCD_DIFF_TBL + (j + info->index), &value); > + > + bitmap_from_arr32(bitmap, &value, BITMAP_SIZE); > + > + for_each_set_bit(bit, bitmap, BITMAP_SIZE) { > + ret = npcm_video_find_rect(video, info, bit + (j << 3)); > + if (ret) > + return ret; > + } > + } > + info->index += 64; > + return info->tile_perline; > +} > + > +static void npcm_video_get_rect_list(struct npcm_video *video, unsigned int index) > +{ > + struct v4l2_bt_timings *act = &video->active_timings; > + struct rect_list_info info; > + unsigned int tile_cnt = 0, mod; > + int ret = 0; > + > + memset(&info, 0, sizeof(struct rect_list_info)); > + info.head = &video->list[index]; > + > + info.tile_perline = act->width >> 4; > + mod = act->width % RECT_W; > + if (mod != 0) > + info.tile_perline += 1; > + > + info.tile_perrow = act->height >> 4; > + mod = act->height % RECT_H; > + if (mod != 0) > + info.tile_perrow += 1; > + > + info.tile_size = info.tile_perrow * info.tile_perline; > + > + info.offset_perline = info.tile_perline >> 5; > + mod = info.tile_perline % 32; > + if (mod != 0) > + info.offset_perline += 1; > + > + info.offset_perline *= 4; > + > + do { > + ret = npcm_video_build_table(video, &info); > + if (ret < 0) > + return; > + > + tile_cnt += ret; > + } while (tile_cnt < info.tile_size); > +} > + > +static unsigned int npcm_video_is_mga(struct npcm_video *video) > +{ > + struct regmap *gfxi = video->gfx_regmap; > + unsigned int dispst; > + > + regmap_read(gfxi, DISPST, &dispst); > + return ((dispst & DISPST_MGAMODE) == DISPST_MGAMODE); > +} > + > +static unsigned int npcm_video_hres(struct npcm_video *video) > +{ > + struct regmap *gfxi = video->gfx_regmap; > + unsigned int hvcnth, hvcntl, apb_hor_res; > + > + regmap_read(gfxi, HVCNTH, &hvcnth); > + regmap_read(gfxi, HVCNTL, &hvcntl); > + apb_hor_res = (((hvcnth & HVCNTH_MASK) << 8) + (hvcntl & HVCNTL_MASK) + 1); > + > + return apb_hor_res; > +} > + > +static unsigned int npcm_video_vres(struct npcm_video *video) > +{ > + struct regmap *gfxi = video->gfx_regmap; > + unsigned int vvcnth, vvcntl, apb_ver_res; > + > + regmap_read(gfxi, VVCNTH, &vvcnth); > + regmap_read(gfxi, VVCNTL, &vvcntl); > + > + apb_ver_res = (((vvcnth & VVCNTH_MASK) << 8) + (vvcntl & VVCNTL_MASK)); > + > + return apb_ver_res; > +} > + > +static int npcm_video_capres(struct npcm_video *video, unsigned int hor_res, > + unsigned int vert_res) > +{ > + struct regmap *vcd = video->vcd_regmap; > + unsigned int res, cap_res; > + > + if (hor_res > MAX_WIDTH || vert_res > MAX_HEIGHT) > + return -EINVAL; > + > + res = FIELD_PREP(VCD_CAP_RES_VERT_RES, vert_res) | > + FIELD_PREP(VCD_CAP_RES_HOR_RES, hor_res); > + > + regmap_write(vcd, VCD_CAP_RES, res); > + regmap_read(vcd, VCD_CAP_RES, &cap_res); > + > + if (cap_res != res) > + return -EINVAL; > + > + return 0; > +} > + > +static void npcm_video_vcd_ip_reset(struct npcm_video *video) > +{ > + /* > + * After resetting a module and clearing the reset bit, it should wait > + * at least 10 us before accessing the module. > + */ > + reset_control_assert(video->reset); > + usleep_range(10, 20); > + reset_control_deassert(video->reset); > + usleep_range(10, 20); > +} > + > +static void npcm_video_vcd_state_machine_reset(struct npcm_video *video) > +{ > + struct regmap *vcd = video->vcd_regmap; > + unsigned int stat; > + int ret; > + > + regmap_update_bits(vcd, VCD_MODE, VCD_MODE_VCDE, 0); > + regmap_update_bits(vcd, VCD_MODE, VCD_MODE_IDBC, 0); > + regmap_update_bits(vcd, VCD_CMD, VCD_CMD_RST, VCD_CMD_RST); > + > + ret = regmap_read_poll_timeout(vcd, VCD_STAT, stat, (stat & VCD_STAT_DONE), > + 0, ECE_POLL_TIMEOUT_US); > + if (ret) { > + dev_warn(video->dev, "Wait for VCD_STAT_DONE timeout\n"); > + return; > + } > + > + regmap_write(vcd, VCD_STAT, VCD_STAT_CLEAR); > + regmap_update_bits(vcd, VCD_MODE, VCD_MODE_VCDE, VCD_MODE_VCDE); > + regmap_update_bits(vcd, VCD_MODE, VCD_MODE_IDBC, VCD_MODE_IDBC); > +} > + > +static void npcm_video_gfx_reset(struct npcm_video *video) > +{ > + struct regmap *gcr = video->gcr_regmap; > + > + regmap_update_bits(gcr, INTCR2, INTCR2_GIRST2, INTCR2_GIRST2); > + npcm_video_vcd_state_machine_reset(video); > + regmap_update_bits(gcr, INTCR2, INTCR2_GIRST2, 0); > +} > + > +static void npcm_video_kvm_bw(struct npcm_video *video, bool set_bw) > +{ > + struct regmap *vcd = video->vcd_regmap; > + > + if (set_bw || !npcm_video_is_mga(video)) > + regmap_update_bits(vcd, VCD_MODE, VCD_MODE_KVM_BW_SET, > + VCD_MODE_KVM_BW_SET); > + else > + regmap_update_bits(vcd, VCD_MODE, VCD_MODE_KVM_BW_SET, 0); > +} > + > +static unsigned int npcm_video_pclk(struct npcm_video *video) > +{ > + struct regmap *gfxi = video->gfx_regmap; > + unsigned int tmp, pllfbdiv, pllinotdiv, gpllfbdiv; > + unsigned int gpllfbdv109, gpllfbdv8, gpllindiv; > + unsigned int gpllst_pllotdiv1, gpllst_pllotdiv2; > + > + regmap_read(gfxi, GPLLST, &tmp); > + gpllfbdv109 = FIELD_GET(GPLLST_GPLLFBDV109, tmp); > + gpllst_pllotdiv1 = FIELD_GET(GPLLST_PLLOTDIV1, tmp); > + gpllst_pllotdiv2 = FIELD_GET(GPLLST_PLLOTDIV2, tmp); > + > + regmap_read(gfxi, GPLLINDIV, &tmp); > + gpllfbdv8 = FIELD_GET(GPLLINDIV_GPLLFBDV8, tmp); > + gpllindiv = FIELD_GET(GPLLINDIV_MASK, tmp); > + > + regmap_read(gfxi, GPLLFBDIV, &tmp); > + gpllfbdiv = FIELD_GET(GPLLFBDIV_MASK, tmp); > + > + pllfbdiv = (512 * gpllfbdv109 + 256 * gpllfbdv8 + gpllfbdiv); > + pllinotdiv = (gpllindiv * gpllst_pllotdiv1 * gpllst_pllotdiv2); > + if (pllfbdiv == 0 || pllinotdiv == 0) > + return 0; > + > + return ((pllfbdiv * 25000) / pllinotdiv) * 1000; > +} > + > +static unsigned int npcm_video_get_bpp(struct npcm_video *video) > +{ > + struct regmap *vcd = video->vcd_regmap; > + unsigned int mode, color_cnvr; > + > + regmap_read(vcd, VCD_MODE, &mode); > + color_cnvr = FIELD_GET(VCD_MODE_COLOR_CNVRT, mode); > + > + switch (color_cnvr) { > + case VCD_MODE_COLOR_CNVRT_NO_CNVRT: > + return 2; > + case VCD_MODE_COLOR_CNVRT_RGB_222: > + case VCD_MODE_COLOR_CNVRT_666_MODE: > + return 1; > + case VCD_MODE_COLOR_CNVRT_RGB_888: > + return 4; > + } > + return 0; > +} > + > +/* > + * Pitch must be a power of 2, >= linebytes, > + * at least 512, and no more than 4096. > + */ > +static void npcm_video_set_linepitch(struct npcm_video *video, unsigned int linebytes) > +{ > + struct regmap *vcd = video->vcd_regmap; > + unsigned int pitch = MIN_LP; > + > + while ((pitch < linebytes) && (pitch < MAX_LP)) > + pitch *= 2; > + > + regmap_write(vcd, VCD_FB_LP, FIELD_PREP(VCD_FBA_LP, pitch) | > + FIELD_PREP(VCD_FBB_LP, pitch)); > +} > + > +static unsigned int npcm_video_get_linepitch(struct npcm_video *video) > +{ > + struct regmap *vcd = video->vcd_regmap; > + unsigned int linepitch; > + > + regmap_read(vcd, VCD_FB_LP, &linepitch); > + return FIELD_GET(VCD_FBA_LP, linepitch); > +} > + > +static void npcm_video_command(struct npcm_video *video, unsigned int value) > +{ > + struct regmap *vcd = video->vcd_regmap; > + unsigned int cmd; > + > + regmap_write(vcd, VCD_STAT, VCD_STAT_CLEAR); > + regmap_read(vcd, VCD_CMD, &cmd); > + cmd |= FIELD_PREP(VCD_CMD_OPERATION, value); > + > + regmap_write(vcd, VCD_CMD, cmd); > + regmap_update_bits(vcd, VCD_CMD, VCD_CMD_GO, VCD_CMD_GO); > + video->op_cmd = value; > +} > + > +static void npcm_video_init_reg(struct npcm_video *video) > +{ > + struct regmap *gcr = video->gcr_regmap, *vcd = video->vcd_regmap; > + > + /* Selects Data Enable */ > + regmap_update_bits(gcr, INTCR, INTCR_DEHS, 0); > + > + /* Enable display of KVM GFX and access to memory */ > + regmap_update_bits(gcr, INTCR, INTCR_GFXIFDIS, 0); > + > + /* Active Vertical/Horizontal Counters Reset */ > + regmap_update_bits(gcr, INTCR2, INTCR2_GIHCRST | INTCR2_GIVCRST, > + INTCR2_GIHCRST | INTCR2_GIVCRST); > + > + /* Select KVM GFX input */ > + regmap_update_bits(gcr, MFSEL1, MFSEL1_DVH1SEL, 0); > + > + /* Reset video modules */ > + npcm_video_vcd_ip_reset(video); > + npcm_video_gfx_reset(video); > + > + /* Set the FIFO thresholds */ > + regmap_write(vcd, VCD_FIFO, VCD_FIFO_TH); > + > + /* Set video mode */ > + regmap_update_bits(vcd, VCD_MODE, 0xffffffff, > + VCD_MODE_VCDE | VCD_MODE_CM565 | > + VCD_MODE_IDBC | VCD_MODE_KVM_BW_SET); > + regmap_write(vcd, VCD_RCHG, FIELD_PREP(VCD_RCHG_TIM_PRSCL, 0xf)); > +} > + > +static int npcm_video_start_frame(struct npcm_video *video) > +{ > + struct npcm_video_buffer *buf; > + struct regmap *vcd = video->vcd_regmap; > + unsigned long flags; > + unsigned int val; > + int ret; > + > + if (video->v4l2_input_status) { > + dev_dbg(video->dev, "No video signal; skip capture frame\n"); > + return 0; > + } > + > + ret = regmap_read_poll_timeout(vcd, VCD_STAT, val, !(val & VCD_STAT_BUSY), > + 1000, VCD_BUSY_TIMEOUT_US); > + if (ret) { > + dev_err(video->dev, "Wait for VCD_STAT_BUSY timeout\n"); > + return -EBUSY; > + } > + > + spin_lock_irqsave(&video->lock, flags); > + buf = list_first_entry_or_null(&video->buffers, > + struct npcm_video_buffer, link); > + if (!buf) { > + spin_unlock_irqrestore(&video->lock, flags); > + dev_dbg(video->dev, "No empty buffers; skip capture frame\n"); > + return 0; > + } > + > + set_bit(VIDEO_FRAME_INPRG, &video->flags); > + spin_unlock_irqrestore(&video->lock, flags); > + > + npcm_video_vcd_state_machine_reset(video); > + regmap_update_bits(vcd, VCD_INTE, VCD_INTE_DONE_IE | VCD_INTE_IFOT_IE | > + VCD_INTE_IFOR_IE, VCD_INTE_DONE_IE | > + VCD_INTE_IFOT_IE | VCD_INTE_IFOR_IE); > + npcm_video_command(video, video->ctrl_cmd); > + > + return 0; > +} > + > +static void npcm_video_bufs_done(struct npcm_video *video, > + enum vb2_buffer_state state) > +{ > + struct npcm_video_buffer *buf; > + unsigned long flags; > + > + spin_lock_irqsave(&video->lock, flags); > + list_for_each_entry(buf, &video->buffers, link) > + vb2_buffer_done(&buf->vb.vb2_buf, state); > + > + INIT_LIST_HEAD(&video->buffers); > + spin_unlock_irqrestore(&video->lock, flags); > +} > + > +static void npcm_video_get_diff_rect(struct npcm_video *video, unsigned int index) > +{ > + unsigned int width = video->active_timings.width; > + unsigned int height = video->active_timings.height; > + > + if (video->op_cmd != VCD_CMD_OPERATION_CAPTURE) { > + video->rect_cnt = 0; > + npcm_video_get_rect_list(video, index); > + video->rect[index] = video->rect_cnt; > + } else { > + video->rect[index] = npcm_video_add_rect(video, index, 0, 0, > + width, height); > + } > +} > + > +static void npcm_video_clear_gmmap(struct npcm_video *video) > +{ > + struct regmap *gcr = video->gcr_regmap; > + unsigned int intcr, gmmap; > + void __iomem *baseptr = NULL; > + > + if (of_device_is_compatible(video->dev->of_node, "nuvoton,npcm750-vcd")) { > + regmap_read(gcr, INTCR3, &intcr); > + gmmap = FIELD_GET(INTCR3_GMMAP, intcr); > + > + switch (gmmap) { > + case INTCR3_GMMAP_128MB: > + baseptr = ioremap_wc(ADDR_GMMAP_128MB, GMMAP_LENGTH); > + break; > + case INTCR3_GMMAP_256MB: > + baseptr = ioremap_wc(ADDR_GMMAP_256MB, GMMAP_LENGTH); > + break; > + case INTCR3_GMMAP_512MB: > + baseptr = ioremap_wc(ADDR_GMMAP_512MB, GMMAP_LENGTH); > + break; > + case INTCR3_GMMAP_1GB: > + baseptr = ioremap_wc(ADDR_GMMAP_1GB, GMMAP_LENGTH); > + break; > + case INTCR3_GMMAP_2GB: > + baseptr = ioremap_wc(ADDR_GMMAP_2GB, GMMAP_LENGTH); > + break; > + } > + } else if (of_device_is_compatible(video->dev->of_node, "nuvoton,npcm845-vcd")) { > + regmap_read(gcr, INTCR4, &intcr); > + gmmap = FIELD_GET(INTCR4_GMMAP, intcr); > + > + switch (gmmap) { > + case INTCR4_GMMAP_512MB: > + baseptr = ioremap_wc(ADDR_GMMAP_512MB, GMMAP_LENGTH); > + break; > + case INTCR4_GMMAP_512MB_ECC: > + baseptr = ioremap_wc(ADDR_GMMAP_512MB_ECC, GMMAP_LENGTH); > + break; > + case INTCR4_GMMAP_1GB: > + baseptr = ioremap_wc(ADDR_GMMAP_1GB, GMMAP_LENGTH); > + break; > + case INTCR4_GMMAP_1GB_ECC: > + baseptr = ioremap_wc(ADDR_GMMAP_1GB_ECC, GMMAP_LENGTH); > + break; > + case INTCR4_GMMAP_2GB: > + baseptr = ioremap_wc(ADDR_GMMAP_2GB, GMMAP_LENGTH); > + break; > + case INTCR4_GMMAP_2GB_ECC: > + baseptr = ioremap_wc(ADDR_GMMAP_2GB_ECC, GMMAP_LENGTH); > + break; > + } > + } > + > + if (baseptr) { > + memset(baseptr, 0, GMMAP_LENGTH); > + iounmap(baseptr); > + } > +} > + > +static void npcm_video_get_resolution(struct npcm_video *video) I think 'ncpm_video_detect_resolution' might be a better name. > +{ > + struct v4l2_bt_timings *act = &video->active_timings; > + struct v4l2_bt_timings *det = &video->detected_timings; > + struct regmap *gfxi; > + unsigned int dispst; > + > + video->v4l2_input_status = 0; > + det->width = npcm_video_hres(video); > + det->height = npcm_video_vres(video); > + > + if (act->width != det->width || act->height != det->height) { > + dev_dbg(video->dev, "Resolution changed\n"); > + npcm_video_bufs_done(video, VB2_BUF_STATE_ERROR); Why return all buffers? You shouldn't have to do this. Right now this function is only called at start streaming and when query_dv_timings is called. Is it possible for the resolution to change while streaming? If so, do you get an interrupt or is there some other mechanism to detect this? Normally a resolution change will raise a V4L2_EVENT_SOURCE_CHANGE event, and userspace then decides what to do (typically stopping streaming and reconfiguring the video pipeline). What happens if you continue streaming when the resolution changes? Particularly when the new resolution is larger than the current buffer size. > + > + if (npcm_video_hres(video) > 0 && npcm_video_vres(video) > 0) { > + gfxi = video->gfx_regmap; > + > + if (test_bit(VIDEO_STREAMING, &video->flags)) { > + /* > + * Wait for resolution is available, > + * and it is also captured by host. > + */ > + do { > + mdelay(100); > + regmap_read(gfxi, DISPST, &dispst); > + } while (npcm_video_vres(video) < 100 || > + npcm_video_pclk(video) == 0 || > + (dispst & DISPST_HSCROFF)); > + } > + > + det->width = npcm_video_hres(video); > + det->height = npcm_video_vres(video); > + det->pixelclock = npcm_video_pclk(video); > + } > + } > + > + if (det->width == 0 || det->height == 0) { > + det->width = MIN_WIDTH; > + det->height = MIN_HEIGHT; > + npcm_video_clear_gmmap(video); This looks like a potentially dangerous side-effect. I would not expect this function to have any side effects: it just detects the new resolution. > + video->v4l2_input_status = V4L2_IN_ST_NO_SIGNAL; > + } > + > + dev_dbg(video->dev, "Got resolution[%dx%d] -> [%dx%d], status %d\n", > + act->width, act->height, det->width, det->height, > + video->v4l2_input_status); > +} > + > +static int npcm_video_set_resolution(struct npcm_video *video) > +{ > + struct v4l2_bt_timings *act = &video->active_timings; > + struct regmap *vcd = video->vcd_regmap; > + unsigned int mode; > + > + /* Set video frame physical address */ > + regmap_write(vcd, VCD_FBA_ADR, video->src.dma); > + regmap_write(vcd, VCD_FBB_ADR, video->src.dma); > + > + if (npcm_video_capres(video, act->width, act->height)) { > + dev_err(video->dev, "Failed to set VCD_CAP_RES\n"); > + return -EINVAL; > + } > + > + video->bytesperpixel = npcm_video_get_bpp(video); > + npcm_video_set_linepitch(video, act->width * video->bytesperpixel); > + video->bytesperline = npcm_video_get_linepitch(video); > + > + npcm_video_kvm_bw(video, act->pixelclock > VCD_KVM_BW_PCLK); > + npcm_video_gfx_reset(video); > + regmap_read(vcd, VCD_MODE, &mode); > + clear_bit(VIDEO_FRAME_INPRG, &video->flags); > + > + dev_dbg(video->dev, "VCD mode = 0x%x, %s mode\n", mode, > + npcm_video_is_mga(video) ? "Hi Res" : "VGA"); > + > + dev_dbg(video->dev, > + "Digital mode: %d x %d x %d, pixelclock %lld, bytesperline %d\n", > + act->width, act->height, video->bytesperpixel, act->pixelclock, > + video->bytesperline); > + > + return 0; > +} > + > +static void npcm_video_start(struct npcm_video *video) > +{ > + npcm_video_init_reg(video); > + npcm_video_get_resolution(video); > + video->active_timings = video->detected_timings; > + video->max_buffer_size = VCD_MAX_SRC_BUFFER_SIZE; > + > + if (!npcm_video_alloc_buf(video, &video->src, video->max_buffer_size)) { > + dev_err(video->dev, "Failed to allocate VCD buffer\n"); > + return; > + } > + > + if (npcm_video_set_resolution(video)) { > + dev_err(video->dev, "Failed to set resolution\n"); > + return; > + } > + > + video->pix_fmt.width = video->active_timings.width; > + video->pix_fmt.height = video->active_timings.height; > + video->pix_fmt.sizeimage = video->max_buffer_size; > + video->pix_fmt.bytesperline = video->bytesperline; > + > + if (atomic_inc_return(&video->ece.clients) == 1) { > + npcm_video_ece_init(video); > + npcm_video_ece_set_fb_addr(video, video->src.dma); > + npcm_video_ece_set_lp(video, video->bytesperline); > + > + dev_dbg(video->dev, "ECE open: client %d\n", > + atomic_read(&video->ece.clients)); > + } > +} > + > +static void npcm_video_stop(struct npcm_video *video) > +{ > + struct regmap *vcd = video->vcd_regmap; > + unsigned long flags; > + > + spin_lock_irqsave(&video->lock, flags); > + set_bit(VIDEO_STOPPED, &video->flags); > + spin_unlock_irqrestore(&video->lock, flags); > + > + regmap_write(vcd, VCD_INTE, 0); > + regmap_write(vcd, VCD_MODE, 0); > + regmap_write(vcd, VCD_RCHG, 0); > + regmap_write(vcd, VCD_STAT, VCD_STAT_CLEAR); > + > + if (video->src.size) > + npcm_video_free_buf(video, &video->src); > + > + if (video->list) > + npcm_video_free_diff_table(video); > + > + kfree(video->list); > + video->list = NULL; > + kfree(video->rect); > + video->rect = NULL; > + > + video->v4l2_input_status = V4L2_IN_ST_NO_SIGNAL; > + video->flags = 0; > + video->ctrl_cmd = VCD_CMD_OPERATION_CAPTURE; > + > + if (atomic_dec_return(&video->ece.clients) == 0) { > + npcm_video_ece_stop(video); > + dev_dbg(video->dev, "ECE close: client %d\n", > + atomic_read(&video->ece.clients)); > + } > +} > + > +static irqreturn_t npcm_video_irq(int irq, void *arg) > +{ > + struct npcm_video *video = arg; > + struct regmap *vcd = video->vcd_regmap; > + struct npcm_video_buffer *buf; > + struct rect_list *rect_list; > + struct v4l2_rect *rect; > + unsigned int index, ed_size, total_size, status, ed_offset; > + dma_addr_t vb_dma_addr; > + void *addr; > + > + regmap_read(vcd, VCD_STAT, &status); > + dev_dbg(video->dev, "VCD irq status 0x%x\n", status); > + > + regmap_write(vcd, VCD_INTE, 0); > + regmap_write(vcd, VCD_STAT, VCD_STAT_CLEAR); > + > + if (test_bit(VIDEO_STOPPED, &video->flags) || > + !test_bit(VIDEO_STREAMING, &video->flags)) { > + clear_bit(VIDEO_FRAME_INPRG, &video->flags); > + return IRQ_NONE; > + } > + > + if (status & VCD_STAT_DONE) { > + spin_lock(&video->lock); > + buf = list_first_entry_or_null(&video->buffers, > + struct npcm_video_buffer, link); > + if (!buf) { > + spin_unlock(&video->lock); > + clear_bit(VIDEO_FRAME_INPRG, &video->flags); > + return IRQ_NONE; > + } > + > + addr = vb2_plane_vaddr(&buf->vb.vb2_buf, 0); > + vb_dma_addr = vb2_dma_contig_plane_dma_addr(&buf->vb.vb2_buf, 0); > + index = buf->vb.vb2_buf.index; > + > + npcm_video_ece_ctrl_reset(video); > + npcm_video_ece_clear_rect_offset(video); > + npcm_video_ece_set_fb_addr(video, video->src.dma); > + > + /* Set base address of encoded data to video buffer */ > + npcm_video_ece_set_enc_dba(video, vb_dma_addr); > + > + npcm_video_ece_set_lp(video, video->bytesperline); > + npcm_video_get_diff_rect(video, index); > + > + total_size = 0; > + list_for_each_entry(rect_list, &video->list[index], list) { > + rect = &rect_list->clip.c; > + ed_offset = npcm_video_ece_read_rect_offset(video); > + npcm_video_ece_enc_rect(video, rect->left, rect->top, > + rect->width, rect->height); > + > + ed_size = npcm_video_ece_get_ed_size(video, ed_offset, addr); > + npcm_video_ece_prepend_rect_header(addr + ed_offset, > + rect->left, rect->top, > + rect->width, rect->height); > + total_size += ed_size; > + } > + > + vb2_set_plane_payload(&buf->vb.vb2_buf, 0, total_size); > + buf->vb.vb2_buf.timestamp = ktime_get_ns(); > + buf->vb.sequence = video->sequence++; > + buf->vb.field = V4L2_FIELD_NONE; > + > + vb2_buffer_done(&buf->vb.vb2_buf, VB2_BUF_STATE_DONE); > + list_del(&buf->link); > + spin_unlock(&video->lock); > + clear_bit(VIDEO_FRAME_INPRG, &video->flags); > + } > + > + if (status & VCD_STAT_IFOR || status & VCD_STAT_IFOT) { > + dev_warn(video->dev, "VCD FIFO overrun or over thresholds\n"); > + npcm_video_stop(video); > + npcm_video_start(video); > + if (npcm_video_start_frame(video)) > + dev_warn(video->dev, "Failed to recover from FIFO overrun\n"); > + } > + > + return IRQ_HANDLED; > +} > + > +static int npcm_video_querycap(struct file *file, void *fh, > + struct v4l2_capability *cap) > +{ > + strscpy(cap->driver, DEVICE_NAME, sizeof(cap->driver)); > + strscpy(cap->card, "NPCM Video Engine", sizeof(cap->card)); > + snprintf(cap->bus_info, sizeof(cap->bus_info), "platform:%s", DEVICE_NAME); > + > + return 0; > +} > + > +static int npcm_video_enum_format(struct file *file, void *fh, > + struct v4l2_fmtdesc *f) > +{ > + if (f->index) > + return -EINVAL; > + > + f->pixelformat = V4L2_PIX_FMT_HEXTILE; > + return 0; > +} > + > +static int npcm_video_get_format(struct file *file, void *fh, > + struct v4l2_format *f) > +{ > + struct npcm_video *video = video_drvdata(file); > + > + f->fmt.pix = video->pix_fmt; > + return 0; > +} > + > +static int npcm_video_enum_input(struct file *file, void *fh, > + struct v4l2_input *inp) > +{ > + struct npcm_video *video = video_drvdata(file); > + > + if (inp->index) > + return -EINVAL; > + You need to call npcm_video_get_resolution(video); here as well, to ensure inp->status is valid. Although ideally you know if there is a new resolution due to an interrupt or something like that. > + strscpy(inp->name, "Host VGA capture", sizeof(inp->name)); > + inp->type = V4L2_INPUT_TYPE_CAMERA; > + inp->capabilities = V4L2_IN_CAP_DV_TIMINGS; > + inp->status = video->v4l2_input_status; > + > + return 0; > +} > + > +static int npcm_video_get_input(struct file *file, void *fh, unsigned int *i) > +{ > + *i = 0; > + > + return 0; > +} > + > +static int npcm_video_set_input(struct file *file, void *fh, unsigned int i) > +{ > + if (i) > + return -EINVAL; > + > + return 0; > +} > + > +static int npcm_video_get_parm(struct file *file, void *fh, > + struct v4l2_streamparm *a) > +{ > + struct npcm_video *video = video_drvdata(file); > + > + a->parm.capture.capability = V4L2_CAP_TIMEPERFRAME; > + a->parm.capture.readbuffers = 3; > + a->parm.capture.timeperframe.numerator = 1; > + if (!video->frame_rate) > + a->parm.capture.timeperframe.denominator = MAX_FRAME_RATE; > + else > + a->parm.capture.timeperframe.denominator = video->frame_rate; > + > + return 0; > +} > + > +static int npcm_video_set_parm(struct file *file, void *fh, > + struct v4l2_streamparm *a) > +{ > + unsigned int frame_rate = 0; > + > + a->parm.capture.capability = V4L2_CAP_TIMEPERFRAME; > + a->parm.capture.readbuffers = 3; > + > + if (a->parm.capture.timeperframe.numerator) > + frame_rate = a->parm.capture.timeperframe.denominator / > + a->parm.capture.timeperframe.numerator; > + > + if (!frame_rate || frame_rate > MAX_FRAME_RATE) { > + frame_rate = 0; > + a->parm.capture.timeperframe.denominator = MAX_FRAME_RATE; > + a->parm.capture.timeperframe.numerator = 1; > + } > + > + return 0; > +} > + > +static int npcm_video_set_dv_timings(struct file *file, void *fh, > + struct v4l2_dv_timings *timings) > +{ > + struct npcm_video *video = video_drvdata(file); > + int rc; > + > + if (timings->bt.width == video->active_timings.width && > + timings->bt.height == video->active_timings.height) > + return 0; > + > + if (vb2_is_busy(&video->queue)) { > + dev_err(video->dev, "%s device busy\n", __func__); > + return -EBUSY; > + } > + > + video->active_timings = timings->bt; This updates the active_timings even if npcm_video_set_resolution fails. Is that what you would expect? > + rc = npcm_video_set_resolution(video); > + if (rc) > + return rc; > + > + video->pix_fmt.width = timings->bt.width; > + video->pix_fmt.height = timings->bt.height; > + video->pix_fmt.sizeimage = video->max_buffer_size; > + video->pix_fmt.bytesperline = video->bytesperline; > + timings->type = V4L2_DV_BT_656_1120; > + > + return 0; > +} > + > +static int npcm_video_get_dv_timings(struct file *file, void *fh, > + struct v4l2_dv_timings *timings) > +{ > + struct npcm_video *video = video_drvdata(file); > + > + timings->type = V4L2_DV_BT_656_1120; > + timings->bt = video->active_timings; > + > + return 0; > +} > + > +static int npcm_video_query_dv_timings(struct file *file, void *fh, > + struct v4l2_dv_timings *timings) > +{ > + struct npcm_video *video = video_drvdata(file); > + > + npcm_video_get_resolution(video); > + timings->type = V4L2_DV_BT_656_1120; > + timings->bt = video->detected_timings; > + > + return video->v4l2_input_status ? -ENOLINK : 0; > +} > + > +static int npcm_video_enum_dv_timings(struct file *file, void *fh, > + struct v4l2_enum_dv_timings *timings) > +{ > + return v4l2_enum_dv_timings_cap(timings, &npcm_video_timings_cap, > + NULL, NULL); > +} > + > +static int npcm_video_dv_timings_cap(struct file *file, void *fh, > + struct v4l2_dv_timings_cap *cap) > +{ > + *cap = npcm_video_timings_cap; > + > + return 0; > +} > + > +static int npcm_video_sub_event(struct v4l2_fh *fh, > + const struct v4l2_event_subscription *sub) > +{ > + switch (sub->type) { > + case V4L2_EVENT_SOURCE_CHANGE: > + return v4l2_src_change_event_subscribe(fh, sub); > + } This makes no sense unless you can actually detect resolution changes and raise this event. If there is no easy asynchronous way of telling the driver that the resolution changed, would it be possible to have a thread that periodically checks the current detected resolution? > + > + return v4l2_ctrl_subscribe_event(fh, sub); > +} > + > +static const struct v4l2_ioctl_ops npcm_video_ioctls = { > + .vidioc_querycap = npcm_video_querycap, > + > + .vidioc_enum_fmt_vid_cap = npcm_video_enum_format, > + .vidioc_g_fmt_vid_cap = npcm_video_get_format, > + .vidioc_s_fmt_vid_cap = npcm_video_get_format, > + .vidioc_try_fmt_vid_cap = npcm_video_get_format, > + > + .vidioc_reqbufs = vb2_ioctl_reqbufs, > + .vidioc_querybuf = vb2_ioctl_querybuf, > + .vidioc_qbuf = vb2_ioctl_qbuf, > + .vidioc_expbuf = vb2_ioctl_expbuf, > + .vidioc_dqbuf = vb2_ioctl_dqbuf, > + .vidioc_create_bufs = vb2_ioctl_create_bufs, > + .vidioc_prepare_buf = vb2_ioctl_prepare_buf, > + .vidioc_streamon = vb2_ioctl_streamon, > + .vidioc_streamoff = vb2_ioctl_streamoff, > + > + .vidioc_enum_input = npcm_video_enum_input, > + .vidioc_g_input = npcm_video_get_input, > + .vidioc_s_input = npcm_video_set_input, > + > + .vidioc_g_parm = npcm_video_get_parm, > + .vidioc_s_parm = npcm_video_set_parm, > + > + .vidioc_s_dv_timings = npcm_video_set_dv_timings, > + .vidioc_g_dv_timings = npcm_video_get_dv_timings, > + .vidioc_query_dv_timings = npcm_video_query_dv_timings, > + .vidioc_enum_dv_timings = npcm_video_enum_dv_timings, > + .vidioc_dv_timings_cap = npcm_video_dv_timings_cap, > + > + .vidioc_subscribe_event = npcm_video_sub_event, > + .vidioc_unsubscribe_event = v4l2_event_unsubscribe, > +}; > + > +static int npcm_video_set_ctrl(struct v4l2_ctrl *ctrl) > +{ > + struct npcm_video *video = container_of(ctrl->handler, struct npcm_video, > + ctrl_handler); > + > + switch (ctrl->id) { > + case V4L2_CID_NPCM_CAPTURE_MODE: > + if (ctrl->val == V4L2_NPCM_CAPTURE_MODE_COMPLETE) > + video->ctrl_cmd = VCD_CMD_OPERATION_CAPTURE; > + else if (ctrl->val == V4L2_NPCM_CAPTURE_MODE_DIFF) > + video->ctrl_cmd = VCD_CMD_OPERATION_COMPARE; > + break; > + default: > + return -EINVAL; > + } > + > + return 0; > +} > + > +static int npcm_video_get_volatile_ctrl(struct v4l2_ctrl *ctrl) > +{ > + struct npcm_video *video = container_of(ctrl->handler, struct npcm_video, > + ctrl_handler); > + > + switch (ctrl->id) { > + case V4L2_CID_NPCM_RECT_COUNT: > + ctrl->val = video->rect[video->vb_index]; Does this change per frame? This is not really a reliable way of passing this information to userspace. I also wonder if the number of rects isn't something that can be deduced from the payload size of the buffer. > + break; > + default: > + return -EINVAL; > + } > + > + return 0; > +} > + > +static const struct v4l2_ctrl_ops npcm_video_ctrl_ops = { > + .s_ctrl = npcm_video_set_ctrl, > + .g_volatile_ctrl = npcm_video_get_volatile_ctrl, > +}; > + > +static const struct v4l2_ctrl_config npcm_ctrl_capture_mode = { > + .ops = &npcm_video_ctrl_ops, > + .id = V4L2_CID_NPCM_CAPTURE_MODE, > + .name = "NPCM Video Capture Mode", > + .type = V4L2_CTRL_TYPE_INTEGER, > + .min = 0, > + .max = V4L2_NPCM_CAPTURE_MODE_DIFF, > + .step = 1, > + .def = 0, > +}; > + > +static const struct v4l2_ctrl_config npcm_ctrl_rect_count = { > + .ops = &npcm_video_ctrl_ops, > + .id = V4L2_CID_NPCM_RECT_COUNT, > + .name = "NPCM Compressed Hextile Rectangle Count", > + .type = V4L2_CTRL_TYPE_INTEGER, > + .flags = V4L2_CTRL_FLAG_VOLATILE, > + .min = 0, > + .max = (MAX_WIDTH / RECT_W) * (MAX_HEIGHT / RECT_H), > + .step = 1, > + .def = 0, > +}; > + > +static int npcm_video_open(struct file *file) > +{ > + struct npcm_video *video = video_drvdata(file); > + int rc; > + > + mutex_lock(&video->video_lock); > + rc = v4l2_fh_open(file); > + if (rc) { > + mutex_unlock(&video->video_lock); > + return rc; > + } > + > + if (v4l2_fh_is_singular_file(file)) > + npcm_video_start(video); > + > + mutex_unlock(&video->video_lock); > + return 0; > +} > + > +static int npcm_video_release(struct file *file) > +{ > + struct npcm_video *video = video_drvdata(file); > + int rc; > + > + mutex_lock(&video->video_lock); > + if (v4l2_fh_is_singular_file(file)) > + npcm_video_stop(video); > + > + rc = _vb2_fop_release(file, NULL); > + > + mutex_unlock(&video->video_lock); > + return rc; > +} > + > +static const struct v4l2_file_operations npcm_video_v4l2_fops = { > + .owner = THIS_MODULE, > + .read = vb2_fop_read, > + .poll = vb2_fop_poll, > + .unlocked_ioctl = video_ioctl2, > + .mmap = vb2_fop_mmap, > + .open = npcm_video_open, > + .release = npcm_video_release, > +}; > + > +static int npcm_video_queue_setup(struct vb2_queue *q, unsigned int *num_buffers, > + unsigned int *num_planes, unsigned int sizes[], > + struct device *alloc_devs[]) > +{ > + struct npcm_video *video = vb2_get_drv_priv(q); > + unsigned int i; > + > + if (*num_planes) { > + if (sizes[0] < video->max_buffer_size) > + return -EINVAL; > + > + return 0; > + } > + > + *num_planes = 1; > + sizes[0] = video->max_buffer_size; > + > + kfree(video->rect); > + video->rect = NULL; This line is not needed. > + > + video->rect = kcalloc(*num_buffers, sizeof(*video->rect), GFP_KERNEL); Possibly overkill to allocate this. It can be an array of size VIDEO_MAX_FRAME as well. Up to you, though. > + if (!video->rect) > + return -ENOMEM; > + > + if (video->list) { > + npcm_video_free_diff_table(video); > + kfree(video->list); > + video->list = NULL; > + } > + > + video->list = kzalloc(sizeof(*video->list) * *num_buffers, GFP_KERNEL); > + if (!video->list) { > + kfree(video->rect); > + return -ENOMEM; > + } > + > + for (i = 0; i < *num_buffers; i++) > + INIT_LIST_HEAD(&video->list[i]); > + > + video->num_buffers = *num_buffers; > + return 0; > +} > + > +static int npcm_video_buf_prepare(struct vb2_buffer *vb) > +{ > + struct npcm_video *video = vb2_get_drv_priv(vb->vb2_queue); > + > + if (vb2_plane_size(vb, 0) < video->max_buffer_size) > + return -EINVAL; > + > + return 0; > +} > + > +static int npcm_video_start_streaming(struct vb2_queue *q, unsigned int count) > +{ > + struct npcm_video *video = vb2_get_drv_priv(q); > + int rc; > + > + video->sequence = 0; > + rc = npcm_video_start_frame(video); > + if (rc) { > + npcm_video_bufs_done(video, VB2_BUF_STATE_QUEUED); > + return rc; > + } > + > + set_bit(VIDEO_STREAMING, &video->flags); > + return 0; > +} > + > +static void npcm_video_stop_streaming(struct vb2_queue *q) > +{ > + struct npcm_video *video = vb2_get_drv_priv(q); > + struct regmap *vcd = video->vcd_regmap; > + > + clear_bit(VIDEO_STREAMING, &video->flags); > + regmap_write(vcd, VCD_INTE, 0); > + regmap_write(vcd, VCD_STAT, VCD_STAT_CLEAR); > + npcm_video_gfx_reset(video); > + npcm_video_bufs_done(video, VB2_BUF_STATE_ERROR); > + video->ctrl_cmd = VCD_CMD_OPERATION_CAPTURE; > +} > + > +static void npcm_video_buf_queue(struct vb2_buffer *vb) > +{ > + struct npcm_video *video = vb2_get_drv_priv(vb->vb2_queue); > + struct vb2_v4l2_buffer *vbuf = to_vb2_v4l2_buffer(vb); > + struct npcm_video_buffer *nvb = to_npcm_video_buffer(vbuf); > + unsigned long flags; > + > + spin_lock_irqsave(&video->lock, flags); > + list_add_tail(&nvb->link, &video->buffers); > + spin_unlock_irqrestore(&video->lock, flags); > +} > + > +static void npcm_video_buf_finish(struct vb2_buffer *vb) > +{ > + struct npcm_video *video = vb2_get_drv_priv(vb->vb2_queue); > + struct list_head *head, *pos, *nx; > + struct rect_list *tmp; > + > + /* > + * When a video buffer is dequeued, free associated rect_list and > + * capture next frame. > + */ > + head = &video->list[video->vb_index]; > + list_for_each_safe(pos, nx, head) { > + tmp = list_entry(pos, struct rect_list, list); > + list_del(&tmp->list); > + kfree(tmp); > + } > + > + if (npcm_video_start_frame(video)) { > + dev_err(video->dev, "Failed to capture next frame\n"); > + return; > + } > + > + video->vb_index = vb->index; > +} > + > +static const struct vb2_ops npcm_video_vb2_ops = { > + .queue_setup = npcm_video_queue_setup, > + .wait_prepare = vb2_ops_wait_prepare, > + .wait_finish = vb2_ops_wait_finish, > + .buf_prepare = npcm_video_buf_prepare, > + .buf_finish = npcm_video_buf_finish, > + .start_streaming = npcm_video_start_streaming, > + .stop_streaming = npcm_video_stop_streaming, > + .buf_queue = npcm_video_buf_queue, > +}; > + > +static int npcm_video_setup_video(struct npcm_video *video) > +{ > + struct v4l2_device *v4l2_dev = &video->v4l2_dev; > + struct video_device *vdev = &video->vdev; > + struct vb2_queue *vbq = &video->queue; > + int rc; > + > + video->pix_fmt.pixelformat = V4L2_PIX_FMT_HEXTILE; > + video->pix_fmt.field = V4L2_FIELD_NONE; > + video->pix_fmt.colorspace = V4L2_COLORSPACE_SRGB; > + video->v4l2_input_status = V4L2_IN_ST_NO_SIGNAL; > + > + rc = v4l2_device_register(video->dev, v4l2_dev); > + if (rc) { > + dev_err(video->dev, "Failed to register v4l2 device\n"); > + return rc; > + } > + > + v4l2_ctrl_handler_init(&video->ctrl_handler, 2); > + v4l2_ctrl_new_custom(&video->ctrl_handler, &npcm_ctrl_capture_mode, NULL); > + v4l2_ctrl_new_custom(&video->ctrl_handler, &npcm_ctrl_rect_count, NULL); > + if (video->ctrl_handler.error) { > + dev_err(video->dev, "Failed to init controls: %d\n", > + video->ctrl_handler.error); > + > + rc = video->ctrl_handler.error; > + goto rel_ctrl_handler; > + } > + v4l2_dev->ctrl_handler = &video->ctrl_handler; > + > + vbq->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; > + vbq->io_modes = VB2_MMAP | VB2_READ | VB2_DMABUF; Does VB2_READ make sense? It can't really be used with a HEXTILE format since that has variable length payloads, and with read() you don't know the size of each compressed frame. > + vbq->dev = v4l2_dev->dev; > + vbq->lock = &video->video_lock; > + vbq->ops = &npcm_video_vb2_ops; > + vbq->mem_ops = &vb2_dma_contig_memops; > + vbq->drv_priv = video; > + vbq->buf_struct_size = sizeof(struct npcm_video_buffer); > + vbq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; > + vbq->min_buffers_needed = 3; > + > + rc = vb2_queue_init(vbq); > + if (rc) { > + dev_err(video->dev, "Failed to init vb2 queue\n"); > + goto rel_ctrl_handler; > + } > + vdev->queue = vbq; > + vdev->fops = &npcm_video_v4l2_fops; > + vdev->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_READWRITE | > + V4L2_CAP_STREAMING; > + vdev->v4l2_dev = v4l2_dev; > + strscpy(vdev->name, DEVICE_NAME, sizeof(vdev->name)); > + vdev->vfl_type = VFL_TYPE_VIDEO; > + vdev->vfl_dir = VFL_DIR_RX; > + vdev->release = video_device_release_empty; > + vdev->ioctl_ops = &npcm_video_ioctls; > + vdev->lock = &video->video_lock; > + > + video_set_drvdata(vdev, video); > + rc = video_register_device(vdev, VFL_TYPE_VIDEO, 0); > + if (rc) { > + dev_err(video->dev, "Failed to register video device\n"); > + goto rel_vb_queue; > + } > + > + return 0; > + > +rel_vb_queue: > + vb2_queue_release(vbq); > +rel_ctrl_handler: > + v4l2_ctrl_handler_free(&video->ctrl_handler); > + v4l2_device_unregister(v4l2_dev); > + > + return rc; > +} > + > +static int npcm_video_init(struct npcm_video *video) > +{ > + struct device *dev = video->dev; > + int irq, rc; > + > + irq = irq_of_parse_and_map(dev->of_node, 0); > + if (!irq) { > + dev_err(dev, "Failed to find VCD IRQ\n"); > + return -ENODEV; > + } > + > + rc = devm_request_threaded_irq(dev, irq, NULL, npcm_video_irq, > + IRQF_ONESHOT, DEVICE_NAME, video); > + if (rc < 0) { > + dev_err(dev, "Failed to request IRQ %d\n", irq); > + return rc; > + } > + > + of_reserved_mem_device_init(dev); > + rc = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)); > + if (rc) { > + dev_err(dev, "Failed to set DMA mask\n"); > + of_reserved_mem_device_release(dev); > + } > + > + return rc; > +} > + > +static const struct regmap_config npcm_video_regmap_cfg = { > + .reg_bits = 32, > + .reg_stride = 4, > + .val_bits = 32, > + .max_register = VCD_FIFO, > +}; > + > +static const struct regmap_config npcm_video_ece_regmap_cfg = { > + .reg_bits = 32, > + .reg_stride = 4, > + .val_bits = 32, > + .max_register = ECE_HEX_RECT_OFFSET, > +}; > + > +static int npcm_video_probe(struct platform_device *pdev) > +{ > + struct npcm_video *video = kzalloc(sizeof(*video), GFP_KERNEL); > + struct device_node *ece_node; > + struct platform_device *ece_pdev; > + int rc; > + void __iomem *regs; > + > + if (!video) > + return -ENOMEM; > + > + video->frame_rate = MAX_FRAME_RATE; > + video->dev = &pdev->dev; > + spin_lock_init(&video->lock); > + mutex_init(&video->video_lock); > + INIT_LIST_HEAD(&video->buffers); > + > + regs = devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(regs)) { > + dev_err(&pdev->dev, "Failed to parse VCD reg in DTS\n"); > + return PTR_ERR(regs); > + } > + > + video->vcd_regmap = devm_regmap_init_mmio(&pdev->dev, regs, > + &npcm_video_regmap_cfg); > + if (IS_ERR(video->vcd_regmap)) { > + dev_err(&pdev->dev, "Failed to initialize VCD regmap\n"); > + return PTR_ERR(video->vcd_regmap); > + } > + > + ece_node = of_parse_phandle(video->dev->of_node, "nuvoton,ece", 0); > + if (IS_ERR(ece_node)) { > + dev_err(&pdev->dev, "Failed to get ECE phandle in DTS\n"); > + return PTR_ERR(ece_node); > + } > + > + ece_pdev = of_find_device_by_node(ece_node); > + of_node_put(ece_node); > + if (IS_ERR(ece_pdev)) { > + dev_err(&pdev->dev, "Failed to find ECE device\n"); > + return PTR_ERR(ece_pdev); > + } > + > + regs = devm_platform_ioremap_resource(ece_pdev, 0); > + if (IS_ERR(regs)) { > + dev_err(&pdev->dev, "Failed to parse ECE reg in DTS\n"); > + return PTR_ERR(regs); > + } > + > + video->ece.regmap = devm_regmap_init_mmio(&pdev->dev, regs, > + &npcm_video_ece_regmap_cfg); > + if (IS_ERR(video->ece.regmap)) { > + dev_err(&pdev->dev, "Failed to initialize ECE regmap\n"); > + return PTR_ERR(video->ece.regmap); > + } > + > + video->reset = devm_reset_control_get(&pdev->dev, NULL); > + if (IS_ERR(video->reset)) { > + dev_err(&pdev->dev, "Failed to get VCD reset control in DTS\n"); > + return PTR_ERR(video->reset); > + } > + > + video->ece.reset = devm_reset_control_get(&ece_pdev->dev, NULL); > + if (IS_ERR(video->ece.reset)) { > + dev_err(&pdev->dev, "Failed to get ECE reset control in DTS\n"); > + return PTR_ERR(video->ece.reset); > + } > + > + video->gcr_regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, > + "nuvoton,sysgcr"); > + if (IS_ERR(video->gcr_regmap)) > + return PTR_ERR(video->gcr_regmap); > + > + video->gfx_regmap = syscon_regmap_lookup_by_phandle(pdev->dev.of_node, > + "nuvoton,sysgfxi"); > + if (IS_ERR(video->gfx_regmap)) > + return PTR_ERR(video->gfx_regmap); > + > + rc = npcm_video_init(video); > + if (rc) > + return rc; > + > + rc = npcm_video_setup_video(video); > + if (rc) > + return rc; > + > + dev_info(video->dev, "NPCM video driver probed\n"); > + return 0; > +} > + > +static int npcm_video_remove(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct v4l2_device *v4l2_dev = dev_get_drvdata(dev); > + struct npcm_video *video = to_npcm_video(v4l2_dev); > + > + video_unregister_device(&video->vdev); > + vb2_queue_release(&video->queue); > + v4l2_ctrl_handler_free(&video->ctrl_handler); > + v4l2_device_unregister(v4l2_dev); > + npcm_video_ece_stop(video); > + of_reserved_mem_device_release(dev); > + > + return 0; > +} > + > +static const struct of_device_id npcm_video_match[] = { > + { .compatible = "nuvoton,npcm750-vcd" }, > + { .compatible = "nuvoton,npcm845-vcd" }, > + {}, > +}; > + > +MODULE_DEVICE_TABLE(of, npcm_video_match); > + > +static struct platform_driver npcm_video_driver = { > + .driver = { > + .name = DEVICE_NAME, > + .of_match_table = npcm_video_match, > + }, > + .probe = npcm_video_probe, > + .remove = npcm_video_remove, > +}; > + > +module_platform_driver(npcm_video_driver); > + > +MODULE_AUTHOR("Joseph Liu <kwliu@nuvoton.com>"); > +MODULE_AUTHOR("Marvin Lin <kflin@nuvoton.com>"); > +MODULE_DESCRIPTION("Driver for Nuvoton NPCM Video Capture/Encode Engine"); > +MODULE_LICENSE("GPL v2"); Regards, Hans
Hi Hans, Sorry for the late response. > > I'll move it to Documentation/devicetree/bindings/soc/npcm/nuvoton,gfxi.yaml. > > v12 still has this in the old location, so it appears you forgot this. Thanks for the reminder, v13 will correct the path. Regards, Marvin
This patch series add DTS node, dt-bindings document and drivers for Video Capture/Differentiation Engine (VCD) and Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs. As described in the datasheet NPCM750D_DS_Rev_1.0, the VCD can capture a frame from digital video input and compare two frames in memory, then the ECE will compress the frame data into HEXTITLE format which is defined in Remote Framebuffer Protocol (RFC 6143, chapter 7.7.4. Hextile Encoding). The output of v4l2-compliance: v4l2-compliance 1.23.0-4965, 64 bits, 64-bit time_t v4l2-compliance SHA: d0964d133053 2022-11-06 14:46:45 Compliance test for npcm-video device /dev/video0: Driver Info: Driver name : npcm-video Card type : NPCM Video Engine Bus info : platform:npcm-video Driver version : 5.15.50 Capabilities : 0x85200001 Video Capture Read/Write Streaming Extended Pix Format Device Capabilities Device Caps : 0x05200001 Video Capture Read/Write Streaming Extended Pix Format Required ioctls: test VIDIOC_QUERYCAP: OK test invalid ioctls: OK Allow for multiple opens: test second /dev/video0 open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK test for unlimited opens: OK Debug ioctls: test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported) Input ioctls: test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 1 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK test VIDIOC_DV_TIMINGS_CAP: OK test VIDIOC_G/S_EDID: OK (Not Supported) Control ioctls (Input 0): test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK warn: /usr/src/debug/v4l-utils/1.22.1-r0/utils/v4l2-compliance/v4l2-test-controls.cpp(1070): V4L2_CID_DV_RX_POWER_PRESENT not found for input 0 test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 1 Private Controls: 2 Format ioctls (Input 0): test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK warn: /usr/src/debug/v4l-utils/1.22.1-r0/utils/v4l2-compliance/v4l2-test-formats.cpp(1411): S_PARM is supported for buftype 1, but not for ENUM_FRAMEINTERVALS test VIDIOC_G/S_PARM: OK test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK test VIDIOC_TRY_FMT: OK test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK (Not Supported) test Composing: OK (Not Supported) test Scaling: OK (Not Supported) Codec ioctls (Input 0): test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls (Input 0): test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) Total for npcm-video device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 2 Changes in v11: - Replace "u8/u16/u32" with "unsigned int" for generic local variables. - Correct subsystem prefixes, drop redundant words in commit subject, and add more information in commit message. Changes in v10: - drivers/media/platform/nuvoton/npcm-video.c * Let short functions to be inline function. * Correct return type of some functions, and properly handle return value by callers. * Correct the timing of removing rect_list and the flow of FIFO overrun case in irq. * Adjust line breaks, indentations, and style of variable declarations. Changes in v9: - Change ECE node name to "video-codec". - Drop redundant "bindings for" in commit subject of patch 2/7. - Refine the format of VCD/ECE dt-binding document. Changes in v8: - Let VCD/ECE to be 2 separate nodes and update dt-binding documents. - Move register definitions out to a local header file. - Driver refinements (add error handling for memory allocation, remove unnecessary condition check and introduce "goto"s to handle similar error recovery paths). - Correct properties and typo in GFXI dt-binding document. Changes in v7: - Add uapi documents for driver-specific controls. - Implement driver-specific controls for switching capture mode and getting the count of compressed HEXTILE rectangles. - Drop unnecessary "enum_framesizes" and "enum_frameintervals" functions. - Include the output of v4l2-compliance in cover letter. Changes in v6: - Support NPCM845 and add compatible "nuvoton,npcm845-video". - Correct pixel format to V4L2_PIX_FMT_HEXTILE which is newly added in this patch series. Changes in v5: - Simplify function prefix "nuvoton_" to "npcm_". - Increase VCD_BUSY_TIMEOUT_US and ECE_POLL_TIMEOUT_US to 300ms to prevent polling timeout when ECC is enabled or system is busy. Changes in v4: - Fix compile warning reported by kernel test robot. Changes in v3: - Add video driver entry in MAINTAINERS. - Change config name to CONFIG_VIDEO_NPCM_VCD_ECE. - Reduce the waiting time after resetting the VCD/ECE module. - Correct data types of some variables. Changes in v2: - Add Hextile document and locate with vendor formats. Marvin Lin (7): ARM: dts: nuvoton: Add node for NPCM VCD and ECE engine media: dt-bindings: nuvoton: Add NPCM VCD and ECE engine dt-bindings: arm: nuvoton: Add NPCM GFXI media: v4l: Add HEXTILE compressed format media: v4l2-ctrls: Add user control base for Nuvoton NPCM controls media: uapi: Add controls for NPCM video driver media: nuvoton: Add driver for NPCM video capture and encode engine .../bindings/arm/npcm/nuvoton,gfxi.yaml | 39 + .../bindings/media/nuvoton,npcm-ece.yaml | 43 + .../bindings/media/nuvoton,npcm-vcd.yaml | 72 + .../userspace-api/media/drivers/index.rst | 1 + .../media/drivers/npcm-video.rst | 67 + .../media/v4l/pixfmt-reserved.rst | 7 + MAINTAINERS | 12 + arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 23 + drivers/media/platform/Kconfig | 1 + drivers/media/platform/Makefile | 1 + drivers/media/platform/nuvoton/Kconfig | 15 + drivers/media/platform/nuvoton/Makefile | 2 + drivers/media/platform/nuvoton/npcm-regs.h | 171 ++ drivers/media/platform/nuvoton/npcm-video.c | 1816 +++++++++++++++++ drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/npcm-video.h | 41 + include/uapi/linux/v4l2-controls.h | 6 + include/uapi/linux/videodev2.h | 1 + 18 files changed, 2319 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/npcm/nuvoton,gfxi.yaml create mode 100644 Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml create mode 100644 Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml create mode 100644 Documentation/userspace-api/media/drivers/npcm-video.rst create mode 100644 drivers/media/platform/nuvoton/Kconfig create mode 100644 drivers/media/platform/nuvoton/Makefile create mode 100644 drivers/media/platform/nuvoton/npcm-regs.h create mode 100644 drivers/media/platform/nuvoton/npcm-video.c create mode 100644 include/uapi/linux/npcm-video.h