mbox series

[0/2] Add support for mono version of Sony IMX290 sensor

Message ID 20230131190700.3476796-1-dave.stevenson@raspberrypi.com
Headers show
Series Add support for mono version of Sony IMX290 sensor | expand

Message

Dave Stevenson Jan. 31, 2023, 7:06 p.m. UTC 
The IMX290 comes in both mono and colour variants, but has no runtime way
of determining which is connected.
These patches adds support for either option.

Dave Stevenson (2):
  media: dt-bindings: media: i2c: Add mono version to IMX290 bindings
  media: i2c: imx290: Add support for the mono sensor variant.

 .../bindings/media/i2c/sony,imx290.yaml       |  8 ++--
 drivers/media/i2c/imx290.c                    | 47 ++++++++++++-------
 2 files changed, 35 insertions(+), 20 deletions(-)

Comments

Rob Herring Feb. 1, 2023, 5:47 p.m. UTC | #1 
On Tue, 31 Jan 2023 19:06:59 +0000, Dave Stevenson wrote:
> The IMX290 module is available as either monochrome or colour and
> the variant is not detectable at runtime.
> 
> Add a new compatible string for the monochrome version.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
>  .../devicetree/bindings/media/i2c/sony,imx290.yaml        | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Laurent Pinchart Feb. 1, 2023, 11:59 p.m. UTC | #2 
Hi Dave,

Thank you for the patch.

On Tue, Jan 31, 2023 at 07:06:59PM +0000, Dave Stevenson wrote:
> The IMX290 module is available as either monochrome or colour and
> the variant is not detectable at runtime.
> 
> Add a new compatible string for the monochrome version.
> 
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
>  .../devicetree/bindings/media/i2c/sony,imx290.yaml        | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
> index 21377daae026..29ca4052591f 100644
> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx290.yaml
> @@ -12,15 +12,17 @@ maintainers:
>  
>  description: |-
>    The Sony IMX290 is a 1/2.8-Inch CMOS Solid-state image sensor with Square
> -  Pixel for Color Cameras. It is programmable through I2C and 4-wire
> -  interfaces. The sensor output is available via CMOS logic parallel SDR
> -  output, Low voltage LVDS DDR output and CSI-2 serial data output. The CSI-2
> +  Pixel, available in either mono or colour variants.
> +  It is programmable through I2C and 4-wire interfaces.
> +  The sensor output is available via CMOS logic parallel SDR output, Low
> +  voltage LVDS DDR output and CSI-2 serial data output. The CSI-2
>    bus is the default. No bindings have been defined for the other busses.

Nitpicking, could you reflow the text to the 80 columns limit, or add a
blank line between what you consider to be independent paragraphs ?

>  
>  properties:
>    compatible:
>      enum:
>        - sony,imx290
> +      - sony,imx290-mono

The monochrome version is called IMX290LLR, while the colour version is
the IMX290LQR. Could we use sony,imx290llr (or possibly sony,imx290ll)
as a compatible string instead of sony,imx290-mono ? We could also
deprecate sony,imx290 in favour of sony,imx290lqr (or sony,imx290lq) if
desired, and I can handle this on top.

>  
>    reg: