mbox series

[v1,0/6] media: nxp: imx7-media-csi: Move to subdev active state

Message ID 20230127022715.27234-1-laurent.pinchart@ideasonboard.com
Headers show
Series media: nxp: imx7-media-csi: Move to subdev active state | expand

Message

Laurent Pinchart Jan. 27, 2023, 2:27 a.m. UTC
Hello,

This small series moves the imx7-mipi-csi driver to use the subdev
active state. Patches 1/6 to 5/6 are small preparatory cleanups, with
the main change in 6/6.

I haven't tested the series yet as I need to dig up the hardware first.
Adam, you offered to test the similar imx-mipi-csis series I've sent
recently on the i.MX8MM, would you be able to test this one at the same
time ?

Laurent Pinchart (6):
  media: imx: imx7-media-csi: Drop imx7_csi.cc field
  media: imx: imx7-media-csi: Simplify imx7_csi_video_init_format()
  media: imx: imx7-media-csi: Drop unneeded check when starting
    streaming
  media: imx: imx7-media-csi: Drop unneeded src_sd check
  media: imx: imx7-media-csi: Drop unneeded pad checks
  media: imx: imx7-media-csi: Use V4L2 subdev active state

 drivers/media/platform/nxp/imx7-media-csi.c | 208 ++++++--------------
 1 file changed, 58 insertions(+), 150 deletions(-)


base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2

Comments

Laurent Pinchart Jan. 29, 2023, 2:35 a.m. UTC | #1
Hi Martin,

On Fri, Jan 27, 2023 at 12:41:26PM +0100, Martin Kepplinger wrote:
> Am Freitag, dem 27.01.2023 um 04:27 +0200 schrieb Laurent Pinchart:
> > Hello,
> > 
> > This small series moves the imx7-mipi-csi driver to use the subdev
> > active state. Patches 1/6 to 5/6 are small preparatory cleanups, with
> > the main change in 6/6.
> > 
> > I haven't tested the series yet as I need to dig up the hardware first.
> > Adam, you offered to test the similar imx-mipi-csis series I've sent
> > recently on the i.MX8MM, would you be able to test this one at the same
> > time ?
> 
> a first test of streaming frames on imx8mq with these patches + your
> inline fix works fine. just so you know. I can keep testing possible
> future revisions. thanks a lot!

Thank you for testing. I've just sent v2 and CC'ed you, could you please
test it too ? If it works, a Tested-by tag would be nice :-)

> ps. I know something similar needs to be done for the imx8mq mipi csi
> driver.

That would be nice. I won't have time to do so myself I'm afraid.

> > Laurent Pinchart (6):
> >   media: imx: imx7-media-csi: Drop imx7_csi.cc field
> >   media: imx: imx7-media-csi: Simplify imx7_csi_video_init_format()
> >   media: imx: imx7-media-csi: Drop unneeded check when starting
> >     streaming
> >   media: imx: imx7-media-csi: Drop unneeded src_sd check
> >   media: imx: imx7-media-csi: Drop unneeded pad checks
> >   media: imx: imx7-media-csi: Use V4L2 subdev active state
> > 
> >  drivers/media/platform/nxp/imx7-media-csi.c | 208 ++++++------------
> > --
> >  1 file changed, 58 insertions(+), 150 deletions(-)
> > 
> > 
> > base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2