mbox series

[v1,0/3] media: rkisp1: Convert to V4L2 subdev active state

Message ID 20230127003124.31685-1-laurent.pinchart@ideasonboard.com
Headers show
Series media: rkisp1: Convert to V4L2 subdev active state | expand

Message

Laurent Pinchart Jan. 27, 2023, 12:31 a.m. UTC
Hello,

This small patch series converts the three subdevs of the rkisp1 (CSI,
ISP and resizer) to use the V4L2 subdev active state. This simplifies
the implementation of the subdevs, as well as the locking scheme. There
isn't much else to add here, please see individual patches for details.

I have successfully tested this series on an i.MX8MP (Debix) and an
RK3399 (Rock Pi 4).

Laurent Pinchart (3):
  media: rkisp1: resizer: Use V4L2 subdev active state
  media: rkisp1: isp: Use V4L2 subdev active state
  media: rkisp1: csi: Use V4L2 subdev active state

 .../platform/rockchip/rkisp1/rkisp1-common.h  |  18 --
 .../platform/rockchip/rkisp1/rkisp1-csi.c     | 107 +++----
 .../platform/rockchip/rkisp1/rkisp1-isp.c     | 261 +++++++-----------
 .../platform/rockchip/rkisp1/rkisp1-resizer.c | 184 +++++-------
 4 files changed, 201 insertions(+), 369 deletions(-)

Comments

Laurent Pinchart Feb. 15, 2023, 11:53 p.m. UTC | #1
Hi Dafna,

Would you have time to review this series at some point ? There's still
plenty of time before v6.4, but I'd like to make sure not to miss that
version.

On Fri, Jan 27, 2023 at 02:31:21AM +0200, Laurent Pinchart wrote:
> Hello,
> 
> This small patch series converts the three subdevs of the rkisp1 (CSI,
> ISP and resizer) to use the V4L2 subdev active state. This simplifies
> the implementation of the subdevs, as well as the locking scheme. There
> isn't much else to add here, please see individual patches for details.
> 
> I have successfully tested this series on an i.MX8MP (Debix) and an
> RK3399 (Rock Pi 4).
> 
> Laurent Pinchart (3):
>   media: rkisp1: resizer: Use V4L2 subdev active state
>   media: rkisp1: isp: Use V4L2 subdev active state
>   media: rkisp1: csi: Use V4L2 subdev active state
> 
>  .../platform/rockchip/rkisp1/rkisp1-common.h  |  18 --
>  .../platform/rockchip/rkisp1/rkisp1-csi.c     | 107 +++----
>  .../platform/rockchip/rkisp1/rkisp1-isp.c     | 261 +++++++-----------
>  .../platform/rockchip/rkisp1/rkisp1-resizer.c | 184 +++++-------
>  4 files changed, 201 insertions(+), 369 deletions(-)