From patchwork Mon Jan 9 12:01:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 640773 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFFEAC5479D for ; Mon, 9 Jan 2023 12:01:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236710AbjAIMBs (ORCPT ); Mon, 9 Jan 2023 07:01:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233777AbjAIMBq (ORCPT ); Mon, 9 Jan 2023 07:01:46 -0500 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DA721A060 for ; Mon, 9 Jan 2023 04:01:45 -0800 (PST) Received: (Authenticated sender: jacopo@jmondi.org) by mail.gandi.net (Postfix) with ESMTPSA id BF1F920007; Mon, 9 Jan 2023 12:01:41 +0000 (UTC) From: Jacopo Mondi To: Nicholas Roth , Robert Mader Cc: Jacopo Mondi , Laurent Pinchart , Sakari Ailus , linux-media@vger.kernel.org Subject: [PATCH v2 0/2] media: i2c: Add driver for OmniVision OV8858 Date: Mon, 9 Jan 2023 13:01:27 +0100 Message-Id: <20230109120129.24519-1-jacopo@jmondi.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hello, this is a new version of Nicholas' first submission available at https://lore.kernel.org/all/20221106171129.166892-2-nicholas@rothemail.net/ This is a re-write of the previous version so I've restarted numeration from 0 even if in this version I have not changed the register tables. Functionally the most notable difference is the addition of support for binned mode in 4 data lanes mode. There is more space for optimization on top of this series, in example the register tables can be reworked to share more common settings between modes. I have started the effort, but as it is a tedious and error-prone work I would rather have this first version merged and the iterate on top. Programming of the analog crop rectangle and output size could also be made parametric, but the current modes have a few undocumented registers and I didn't feel like biting the bullet and see if the can be safely removed or not. Also, the BSP driver mentions a "not well supported" R1A version of the chip. I would be in favour of removing it if no one oppose. Images are still rather "dark" when tested with libcamera but preview is working as expected in both modes (full res and half-res binned mode) and with 2 and 4 data lanes. Nicholas could you let me know if things are fine with you here ? v3 -> v2: - Address Laurent's comments; most significant changes - Use v4l2_subdev_state everywhere and drop cur_mode - Simplify s_stream - Re-sort functions definition - Write analogue and digital gain as 16 bits registers - put fwnode in error path and remove function v1 -> v2: - Unified and simplified modes - Adjust blanking values to match FPS - Address Laurent's comment: - rework reg_write() function - move to subdev state - cosmetic change Jacopo Mondi (1): dt-bindings: media: Add OmniVision OV8858 Nicholas Roth (1): media: i2c: Add driver for OmniVision OV8858 .../bindings/media/i2c/ovti,ov8858.yaml | 106 + MAINTAINERS | 9 + drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov8858.c | 1993 +++++++++++++++++ 5 files changed, 2122 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov8858.yaml create mode 100644 drivers/media/i2c/ov8858.c --- 2.38.1