mbox series

[0/6] media: ti: cal: misc fixes

Message ID 20220421143449.552312-1-tomi.valkeinen@ideasonboard.com
Headers show
Series media: ti: cal: misc fixes | expand

Message

Tomi Valkeinen April 21, 2022, 2:34 p.m. UTC 
Hi,

Here are some fixes for CAL that I've been carrying in my streams
branch, but as they don't depend on the streams work they can be merged
separately.

 Tomi

Tomi Valkeinen (6):
  media: ti: cal: fix error paths in cal_camerarx_create()
  media: ti: cal: fix useless variable init
  media: ti: cal: rename sd_state to state
  media: ti: cal: use CSI-2 frame number for seq number
  media: ti: cal: combine wdma irq handling
  media: ti: cal: fix wdma irq for metadata

 drivers/media/platform/ti/cal/cal-camerarx.c |  46 +++---
 drivers/media/platform/ti/cal/cal-video.c    |   5 +-
 drivers/media/platform/ti/cal/cal.c          | 139 ++++++++++++++-----
 drivers/media/platform/ti/cal/cal.h          |   7 +-
 4 files changed, 136 insertions(+), 61 deletions(-)

Comments

Tomi Valkeinen April 22, 2022, 6:50 a.m. UTC | #1 
On 21/04/2022 23:01, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Thu, Apr 21, 2022 at 05:34:44PM +0300, Tomi Valkeinen wrote:
>> The error paths are not correct: media_entity_cleanup() should not be
>> called unless media_entity_pads_init() has been called. Fix this.
> 
> See commit 443bf23d0048 ("media: media-entity: Clarify
> media_entity_cleanup() usage") :-)

Ok, I'll drop this.

  Tomi