| Message ID | 20210625082309.24944-1-dafna.hirschfeld@collabora.com |
|---|---|
| Headers | show |
| Series | rkisp1: Two small fixes | expand |
Hi Dafna, On Fri, 2021-06-25 at 11:23 +0300, Dafna Hirschfeld wrote: > The virtual address can be accessed using vb2_plane_vaddr > therefore there is no need to save it in an extra field in > 'rkisp1_buffer'. Remove it. > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com> -- Kindly, Ezequiel
On Fri, Jun 25, 2021 at 11:23:07AM +0300, Dafna Hirschfeld wrote: > Two small fixes to rkisp1 > 1. remove useless vaddr field > 2. set the dma address of the capture buffers only once in 'buf_init' callabck > instead of each time the buffer is queued > > Dafna Hirschfeld (2): > media: rkisp1: remove field 'vaddr' from 'rkisp1_buffer' > media: rkisp1: cap: initialize dma buf address in 'buf_init' cb > > .../media/platform/rockchip/rkisp1/rkisp1-capture.c | 12 +++++++++++- > .../media/platform/rockchip/rkisp1/rkisp1-common.h | 6 +----- > .../media/platform/rockchip/rkisp1/rkisp1-params.c | 3 +-- > .../media/platform/rockchip/rkisp1/rkisp1-stats.c | 6 ++---- > 4 files changed, 15 insertions(+), 12 deletions(-) For both patches: Reviewed-by; Tomasz Figa <tfiga@chromium.org> Best regards, Tomasz