From patchwork Mon Jun 14 10:34:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 459797 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp3161326jae; Mon, 14 Jun 2021 03:44:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9bOAMQlCM4w0rwH91g048BQ5R3hqeeL5E6UscKfDHcWQPZxYArV/qLW2pq/3BLi3adGdh X-Received: by 2002:aa7:dd81:: with SMTP id g1mr16301990edv.274.1623667478682; Mon, 14 Jun 2021 03:44:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623667478; cv=none; d=google.com; s=arc-20160816; b=E4K6SMl8+M0Y310WYR9pGgJuPR2RFTxVJClBfbNNHRumX7xucflbeF7Ysz2F8Yb5Sq XAFDZmDmxzgGl2hQR7HReGd3XpN4AiFBX/BQM6v3+HVussCMNEhkEReiEnC9Jas3bX5Q oi530g/jHZMn+qQB2Cph/Nfg+XOlelGRnKkzie7aN3boOfkqunVFNWEUcGqLgVr/Bij4 d1D0B1ct8/MzYJSMxUMEpvn3xVTpVr/NHfGjVfWiDACEmrV/f5sxgXZGIzSd56qa2rA5 KHsoBvO8LqxWPVrntIcYOMK7eZYNUSfC5Wb43hnm1M+9vPiOALwdLNiu+vjg/tfxpD2E iDfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MP5IWE65Cr6YrmPIUwycjNRx5TFXYOnhBdeCLkkRlCI=; b=iV9wEGnNgpwtdzGPbJnszEEHMRFyaovOANf7zJiLDeNqKK3Iy5pzQIB2TwJwcKc+xx Z414SxQpf1m3DcQUV0xhzRbbBWJUzPyHLHN0beT227P3XAsylEGqC1TWZ/hbM1xlmsSR spM14ZtE1vWFXKypVtbBY8TTyD5l8DBRtB1V7LhsDKOTnvS0dVPMm6RwQcMJ2S1N7BoW tHQ8O/vDL99wTDgiPHgqMd1uptWaa2Kgaqhkfm0Gb+EoaQBZC1guRqw6nTTy7XmLODJy fSxN77ASOnBhhh5Wv3mMAUJn3YbqxCTfia0qEUC6fKulKlsxlFkKY6f9jjijbTkt4Kqw y0tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Xizi1Cfi; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w19si10609433edc.458.2021.06.14.03.44.38; Mon, 14 Jun 2021 03:44:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Xizi1Cfi; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233843AbhFNKqN (ORCPT + 4 others); Mon, 14 Jun 2021 06:46:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:50316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233563AbhFNKnz (ORCPT ); Mon, 14 Jun 2021 06:43:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 123DF613FF; Mon, 14 Jun 2021 10:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623666967; bh=JPZ5zj3IxD3FR5sU3ObVpGn5WX3fiepB/VsQBEhqAYk=; h=From:To:Cc:Subject:Date:From; b=Xizi1Cfi7uzc+y8ytgZAVcH2DMxZ4vsuIfZG43hqDIPabjS6HSXVyDvBVXXg6wzHv O2YOuGTurGxte+isxXYsj4j8348mQ3xmVJDyJIGwfLZijHFFMjej9MtZsBAJe9R2kL 88dHpVPUS110dDyHuJ0FYLd17haxpSmjGF+73n7tnfAxMcO0KMDk/EygWpR/5irOAM rjkrbKjrB+g3jFuym8dvBZLFYKtK0XT4oJEuR9vkEOci2GCLv2B8f8w0loGw//z8O8 kCN3BFVgRq245aaToXfsUpB9exojN64K7k057UyZuyIXQOQfDCoi3jpyS8HjzKWiaQ OQphDq5rokEdg== From: Arnd Bergmann To: Hans Verkuil , Mauro Carvalho Chehab Cc: Arnd Bergmann , "Lad, Prabhakar" , Eduardo Valentin , Sakari Ailus , Greg Kroah-Hartman , Vaibhav Gupta , Liu Shixin , Laurent Pinchart , Jacopo Mondi , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v3 0/7] media: v4l2: compat ioctl fixes Date: Mon, 14 Jun 2021 12:34:01 +0200 Message-Id: <20210614103409.3154127-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Arnd Bergmann There was a report from Syzbot a while ago that I tried fixed earlier, but my fix did not get picked up because of a merge conflict with another patch I had in my tree. I finally managed to take a close enough look at the merge conflict to figure out that the subdev driver handling for VIDIOC_DQEVENT_TIME32 was wrong in all combinations of the patches and just needs to be removed. In the process I also came across a couple of other issues, so the series has now grown to seven patches. I have done randconfig build testing and found no compile time issues, but the driver specific patches have not been tested so far. Arnd Link: https://patchwork.linuxtv.org/project/linux-media/patch/20210318134334.2933141-1-arnd@kernel.org/ Link: https://patchwork.linuxtv.org/project/linux-media/list/?series=5655 Arnd Bergmann (8): media: v4l2-core: ignore native time32 ioctls on 64-bit media: v4l2-core: explicitly clear ioctl input data media: v4l2-core: fix whitespace damage in video_get_user() media: subdev: remove VIDIOC_DQEVENT_TIME32 handling media: v4l2-core: return -ENODEV from ioctl when not registered media: atomisp: remove compat_ioctl32 code media: subdev: fix compat_ioctl32 media: subdev: disallow ioctl for saa6588/davinci drivers/media/i2c/adv7842.c | 3 + drivers/media/i2c/saa6588.c | 4 +- drivers/media/pci/bt8xx/bttv-driver.c | 6 +- drivers/media/pci/saa7134/saa7134-video.c | 6 +- drivers/media/platform/davinci/vpbe_display.c | 2 +- drivers/media/platform/davinci/vpbe_venc.c | 6 +- drivers/media/radio/si4713/si4713.c | 3 + drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 3 + drivers/media/v4l2-core/v4l2-ioctl.c | 32 +- drivers/media/v4l2-core/v4l2-subdev.c | 43 +- drivers/staging/media/atomisp/Makefile | 1 - drivers/staging/media/atomisp/TODO | 5 + .../atomisp/pci/atomisp_compat_ioctl32.c | 1202 ----------------- .../staging/media/atomisp/pci/atomisp_fops.c | 8 +- include/media/v4l2-subdev.h | 7 +- 15 files changed, 66 insertions(+), 1265 deletions(-) delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_compat_ioctl32.c -- 2.29.2 Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: "Lad, Prabhakar" Cc: Eduardo Valentin Cc: Sakari Ailus Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: Vaibhav Gupta Cc: Liu Shixin Cc: Laurent Pinchart Cc: Jacopo Mondi Cc: Andy Shevchenko Cc: linux-kernel@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: linux-staging@lists.linux.dev