From patchwork Thu Jun 10 21:42:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 457870 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp13455jae; Thu, 10 Jun 2021 14:44:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwX3RdKFudpy7V/zX6niPZsKLjdmM6DtzYAc7sySWVxvYktDwpfYiBw9LSPN7nLL5Nmxtvk X-Received: by 2002:a50:d54c:: with SMTP id f12mr478802edj.301.1623361496079; Thu, 10 Jun 2021 14:44:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623361496; cv=none; d=google.com; s=arc-20160816; b=crkwZ2cVPJ7St4bj/ZNYZ+hU9W5vyTxSjK3iZ5MjGscEtFgEz7OBjeWTjw+EUFqDm0 RHLRO/6XfL/WsSE1p7NDaN7/g+UgPQFBpbg3KE2U1vIVjx7bfURkIERP5/OhXMeHKqKT PwwsVuMH1IahdNoo7kRI0fMItxHNhNViMRFkYDIjDkHA/7hl4K7ytztyVBaSko0WtJC9 uZ3DSIbmnYJrJCF1WKCRpTbaUvtk/GG87jp63X9q5YVkXuWHpl3QIUWmjPwRPpDttaJ4 hO2lHI5vzV8IFA50nf0G1eruU8LW0I/ys1Iors6DUcVBR+QU6XVF4w6zhJPy3l4Pt7MV OMsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=BDwmCmIB/ugwIJjpaxMdRZndlxjFyvOLAQ7C+kSJub0=; b=IsYW4QVGSHsrUDdPyoqB+GWWlhZ/FJiFIlvveE/MX5ekkBQzdsJu1LfCwvUS0bzYSz 1zFr3ti3glaqB7UmcNWeCPpX4dstFAqVGtuhHrbh4Z+BK7L+0MtMG0Ez69mDzhP0sZZX ga+dU2as4B1V9qb37wXIotTATcjU6y3wJMPEa+KHffbck62WvfwqcZjXVCh6Wz5olvpD zazYQq6MM9RX25CBVRPRgnmPEM57gidChnGrnoKzsCDVjM2O/AhzpMGlNPSbijRxOrL/ Ct6tOzO63wIMN5y1m8qCtEUCixZKAnOXIv7WRhkhIdJhaErnz410YPr+PxDQYossSFwM o6xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XrdweSX5; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n2si3268404edi.195.2021.06.10.14.44.55; Thu, 10 Jun 2021 14:44:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XrdweSX5; spf=pass (google.com: domain of linux-media-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230374AbhFJVqs (ORCPT + 4 others); Thu, 10 Jun 2021 17:46:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:53862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbhFJVqs (ORCPT ); Thu, 10 Jun 2021 17:46:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C5305613CA; Thu, 10 Jun 2021 21:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623361491; bh=ZWd349hON24nbsKTW/zSfU0MgSTsBzl5Ei1e0dljQpc=; h=From:To:Cc:Subject:Date:From; b=XrdweSX5RuIhdapW4UDwutKy6U8reEUNfOVi/K8VoNtI3fANRcna+OwGH7p34Nyrw NaVpVIUt8XQcjci2sXuS9wh0dKC0IeqZNPV3eYIjesCmGhHWGhaFmSvgPUISHlu0V4 auCaJDracLWjsVIzeo0l/a2sHqw9ramXcR8iMPOSOwmBIOnBRB5i3jjaL9IuFRb8HJ WdrsiBw4VWUp3nmahYkWApbvgkLWRaTMT+L0FR/7ZwvOP2vW7sBNb8JYSNb4zbcbC3 v2y/GTQOjJz12hs/VPZh659Se9MXW9BLOaD+Gv81UBMISwY6cnjJ2tWhkWwyktPbFy U5iJcO7e51QLA== From: Arnd Bergmann To: Hans Verkuil , Mauro Carvalho Chehab Cc: Arnd Bergmann , "Lad, Prabhakar" , Eduardo Valentin , Sakari Ailus , Greg Kroah-Hartman , Vaibhav Gupta , Liu Shixin , Laurent Pinchart , Jacopo Mondi , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH v2 0/7] media: v4l2: compat ioctl fixes Date: Thu, 10 Jun 2021 23:42:58 +0200 Message-Id: <20210610214305.4170835-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Arnd Bergmann There was a report from Syzbot a while ago that I tried fixed earlier, but my fix did not get picked up because of a merge conflict with another patch I had in my tree. I finally managed to take a close enough look at the merge conflict to figure out that the subdev driver handling for VIDIOC_DQEVENT_TIME32 was wrong in all combinations of the patches and just needs to be removed. In the process I also came across a couple of other issues, so the series has now grown to seven patches. I have done randconfig build testing and found no compile time issues, but the driver specific patches have not been tested so far. Arnd Link: https://patchwork.linuxtv.org/project/linux-media/patch/20210318134334.2933141-1-arnd@kernel.org/ Arnd Bergmann (7): media: v4l2-core: ignore native time32 ioctls on 64-bit media: v4l2-core: explicitly clear ioctl input data media: subdev: remove VIDIOC_DQEVENT_TIME32 handling media: v4l2-core: return -ENODEV from ioctl when not registered media: atomisp: remove compat_ioctl32 code media: subdev: fix compat_ioctl32 media: subdev: disallow ioctl for saa6588/davinci drivers/media/i2c/adv7842.c | 3 + drivers/media/i2c/saa6588.c | 4 +- drivers/media/pci/bt8xx/bttv-driver.c | 6 +- drivers/media/pci/saa7134/saa7134-video.c | 6 +- drivers/media/platform/davinci/vpbe_display.c | 2 +- drivers/media/platform/davinci/vpbe_venc.c | 6 +- drivers/media/radio/si4713/si4713.c | 3 + drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 3 + drivers/media/v4l2-core/v4l2-ioctl.c | 57 +- drivers/media/v4l2-core/v4l2-subdev.c | 43 +- drivers/staging/media/atomisp/Makefile | 1 - drivers/staging/media/atomisp/TODO | 5 + .../atomisp/pci/atomisp_compat_ioctl32.c | 1202 ----------------- .../staging/media/atomisp/pci/atomisp_fops.c | 8 +- include/media/v4l2-subdev.h | 7 +- 15 files changed, 81 insertions(+), 1275 deletions(-) delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_compat_ioctl32.c -- 2.29.2 Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Cc: "Lad, Prabhakar" Cc: Eduardo Valentin Cc: Sakari Ailus Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: Vaibhav Gupta Cc: Liu Shixin Cc: Laurent Pinchart Cc: Jacopo Mondi Cc: Andy Shevchenko Cc: linux-kernel@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: linux-staging@lists.linux.dev