| Message ID | 20201123111919.233376-1-lee.jones@linaro.org |
|---|---|
| Headers | show |
| Series | Rid W=1 warnings from GPU | expand |
Only skimmed over them, but over all looks sane to me. Series is Acked-by: Christian König <christian.koenig@amd.com> Thanks, Christian. Am 23.11.20 um 12:18 schrieb Lee Jones: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Only 900 (from 5000) to go! > > Lee Jones (40): > drm/radeon/radeon_device: Consume our own header where the prototypes > are located > drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags' > drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s > 'job' param > drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot > misnaming issue > drm/amd/amdgpu/cik_ih: Supply description for 'ih' in > 'cik_ih_{get,set}_wptr()' > drm/amd/amdgpu/uvd_v4_2: Fix some kernel-doc misdemeanours > drm/amd/amdgpu/dce_v8_0: Supply description for 'async' > drm/amd/amdgpu/cik_sdma: Supply some missing function param > descriptions > drm/amd/amdgpu/gfx_v7_0: Clean-up a bunch of kernel-doc related issues > drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues > drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra > param description > drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header > drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of > 'max_linewidth' > drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place > they are used > drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc > drm/amd/amdgpu/si_dma: Fix a bunch of function documentation issues > drm/amd/amdgpu/gfx_v6_0: Supply description for > 'gfx_v6_0_ring_test_ib()'s 'timeout' param > drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting > issues > drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx' > drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse > drm/amd/amdgpu/uvd_v3_1: Fix-up some documentation issues > drm/amd/amdgpu/dce_v6_0: Fix formatting and missing parameter > description issues > drm/amd/include/vega20_ip_offset: Mark top-level IP_BASE definition as > __maybe_unused > drm/amd/include/navi10_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/arct_ip_offset: Mark top-level IP_BASE definition as > __maybe_unused > drm/amd/include/navi14_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/navi12_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/sienna_cichlid_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/vangogh_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/dimgrey_cavefish_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply > 'global_state' description > drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param > descriptions > drm/amd/amdgpu/cik_sdma: Add one and remove another function param > description > drm/amd/amdgpu/uvd_v4_2: Add one and remove another function param > description > drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing function > param descriptions > drm/amd/amdgpu/gmc_v7_0: Add some missing kernel-doc descriptions > drm/amd/amdgpu/gmc_v8_0: Fix more issues attributed to copy/paste > drm/msm/msm_drv: Make '_msm_ioremap()' static > drm/amd/amdgpu/gmc_v9_0: Remove unused table > 'ecc_umc_mcumc_status_addrs' > drm/amd/amdgpu/gmc_v9_0: Suppy some missing function doc descriptions > > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12 +- > drivers/gpu/drm/amd/amdgpu/cik_ih.c | 2 + > drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 18 ++- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 33 +++-- > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 7 +- > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 5 + > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 38 +---- > drivers/gpu/drm/amd/amdgpu/si_dma.c | 14 +- > drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 10 +- > drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 10 +- > drivers/gpu/drm/amd/include/arct_ip_offset.h | 4 +- > .../amd/include/dimgrey_cavefish_ip_offset.h | 2 +- > .../gpu/drm/amd/include/navi10_ip_offset.h | 2 +- > .../gpu/drm/amd/include/navi12_ip_offset.h | 2 +- > .../gpu/drm/amd/include/navi14_ip_offset.h | 2 +- > .../amd/include/sienna_cichlid_ip_offset.h | 2 +- > .../gpu/drm/amd/include/vangogh_ip_offset.h | 2 +- > .../gpu/drm/amd/include/vega20_ip_offset.h | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 +-- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 2 +- > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 75 +++++++++- > .../drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 88 ------------ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 4 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 5 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 2 +- > drivers/gpu/drm/msm/msm_drv.c | 4 +- > .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++--------- > drivers/gpu/drm/radeon/radeon_device.c | 1 + > 37 files changed, 277 insertions(+), 268 deletions(-) > delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h > > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: amd-gfx@lists.freedesktop.org > Cc: Ben Skeggs <bskeggs@redhat.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: David Airlie <airlied@linux.ie> > Cc: Drew Davenport <ddavenport@chromium.org> > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: Fritz Koenig <frkoenig@google.com> > Cc: Hawking Zhang <Hawking.Zhang@amd.com> > Cc: Huang Rui <ray.huang@amd.com> > Cc: Jerome Glisse <glisse@freedesktop.org> > Cc: Jiansong Chen <Jiansong.Chen@amd.com> > Cc: Jonathan Marek <jonathan@marek.ca> > Cc: Kalyan Thota <kalyan_t@codeaurora.org> > Cc: Likun Gao <Likun.Gao@amd.com> > Cc: linaro-mm-sig@lists.linaro.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-media@vger.kernel.org > Cc: Luben Tuikov <luben.tuikov@amd.com> > Cc: nouveau@lists.freedesktop.org > Cc: Qinglang Miao <miaoqinglang@huawei.com> > Cc: Rob Clark <robdclark@gmail.com> > Cc: Sean Paul <sean@poorly.run> > Cc: Sonny Jiang <sonny.jiang@amd.com> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Tao Zhou <tao.zhou1@amd.com>
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones <lee.jones@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1214: warning: Function parameter or member 'page_flags' not described in 'amdgpu_ttm_tt_create' > > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Jerome Glisse <glisse@freedesktop.org> > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > index 5fcdd67e5a913..debbcef961dd5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -1199,6 +1199,7 @@ static void amdgpu_ttm_backend_destroy(struct ttm_bo_device *bdev, > * amdgpu_ttm_tt_create - Create a ttm_tt object for a given BO > * > * @bo: The buffer object to create a GTT ttm_tt object around > + * @page_flags: Page flags to be added to the ttm_tt object > * > * Called by ttm_tt_create(). > */ > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones <lee.jones@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:226: warning: Function parameter or member 'job' not described in 'cik_sdma_ring_emit_ib' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:226: warning: Function parameter or member 'flags' not described in 'cik_sdma_ring_emit_ib' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:278: warning: Function parameter or member 'addr' not described in 'cik_sdma_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:278: warning: Function parameter or member 'seq' not described in 'cik_sdma_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:278: warning: Function parameter or member 'flags' not described in 'cik_sdma_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:278: warning: Excess function parameter 'fence' description in 'cik_sdma_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:663: warning: Function parameter or member 'timeout' not described in 'cik_sdma_ring_test_ib' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:808: warning: Function parameter or member 'ring' not described in 'cik_sdma_ring_pad_ib' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:859: warning: Function parameter or member 'vmid' not described in 'cik_sdma_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:859: warning: Function parameter or member 'pd_addr' not described in 'cik_sdma_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:859: warning: Excess function parameter 'vm' description in 'cik_sdma_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:1315: warning: Function parameter or member 'ib' not described in 'cik_sdma_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:1315: warning: Function parameter or member 'tmz' not described in 'cik_sdma_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:1315: warning: Excess function parameter 'ring' description in 'cik_sdma_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:1339: warning: Function parameter or member 'ib' not described in 'cik_sdma_emit_fill_buffer' > drivers/gpu/drm/amd/amdgpu/cik_sdma.c:1339: warning: Excess function parameter 'ring' description in 'cik_sdma_emit_fill_buffer' > > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied with minor changes. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c > index 1a6494ea50912..f1e9966e7244e 100644 > --- a/drivers/gpu/drm/amd/amdgpu/cik_sdma.c > +++ b/drivers/gpu/drm/amd/amdgpu/cik_sdma.c > @@ -215,7 +215,9 @@ static void cik_sdma_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count) > * cik_sdma_ring_emit_ib - Schedule an IB on the DMA engine > * > * @ring: amdgpu ring pointer > + * @job: job to retrive vmid from > * @ib: IB object to schedule > + * @flags: unused > * > * Schedule an IB in the DMA ring (CIK). > */ > @@ -267,6 +269,8 @@ static void cik_sdma_ring_emit_hdp_flush(struct amdgpu_ring *ring) > * cik_sdma_ring_emit_fence - emit a fence on the DMA ring > * > * @ring: amdgpu ring pointer > + * @addr: address > + * @seq: sequence number > * @fence: amdgpu fence object > * > * Add a DMA fence packet to the ring to write > @@ -655,6 +659,7 @@ static int cik_sdma_ring_test_ring(struct amdgpu_ring *ring) > * cik_sdma_ring_test_ib - test an IB on the DMA engine > * > * @ring: amdgpu_ring structure holding ring information > + * @timeout: timeout value in jiffies, or MAX_SCHEDULE_TIMEOUT > * > * Test a simple IB in the DMA ring (CIK). > * Returns 0 on success, error on failure. > @@ -801,6 +806,7 @@ static void cik_sdma_vm_set_pte_pde(struct amdgpu_ib *ib, uint64_t pe, > /** > * cik_sdma_vm_pad_ib - pad the IB to the required number of dw > * > + * @ring: amdgpu_ring structure holding ring information > * @ib: indirect buffer to fill with padding > * > */ > @@ -849,7 +855,8 @@ static void cik_sdma_ring_emit_pipeline_sync(struct amdgpu_ring *ring) > * cik_sdma_ring_emit_vm_flush - cik vm flush using sDMA > * > * @ring: amdgpu_ring pointer > - * @vm: amdgpu_vm pointer > + * @vmid: vmid number to use > + * @pd_addr: address > * > * Update the page table base and flush the VM TLB > * using sDMA (CIK). > @@ -1298,10 +1305,11 @@ static void cik_sdma_set_irq_funcs(struct amdgpu_device *adev) > /** > * cik_sdma_emit_copy_buffer - copy buffer using the sDMA engine > * > - * @ring: amdgpu_ring structure holding ring information > + * @ib: indirect buffer to copy to > * @src_offset: src GPU address > * @dst_offset: dst GPU address > * @byte_count: number of bytes to xfer > + * @tmz: unused > * > * Copy GPU buffers using the DMA engine (CIK). > * Used by the amdgpu ttm implementation to move pages if > @@ -1325,7 +1333,7 @@ static void cik_sdma_emit_copy_buffer(struct amdgpu_ib *ib, > /** > * cik_sdma_emit_fill_buffer - fill buffer using the sDMA engine > * > - * @ring: amdgpu_ring structure holding ring information > + * @ib: indirect buffer to fill > * @src_data: value to write to buffer > * @dst_offset: dst GPU address > * @byte_count: number of bytes to xfer > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones <lee.jones@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/si_dma.c:92: warning: Function parameter or member 'addr' not described in 'si_dma_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/si_dma.c:92: warning: Function parameter or member 'seq' not described in 'si_dma_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/si_dma.c:92: warning: Function parameter or member 'flags' not described in 'si_dma_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/si_dma.c:92: warning: Excess function parameter 'fence' description in 'si_dma_ring_emit_fence' > drivers/gpu/drm/amd/amdgpu/si_dma.c:252: warning: Function parameter or member 'timeout' not described in 'si_dma_ring_test_ib' > drivers/gpu/drm/amd/amdgpu/si_dma.c:408: warning: Function parameter or member 'ring' not described in 'si_dma_ring_pad_ib' > drivers/gpu/drm/amd/amdgpu/si_dma.c:446: warning: Function parameter or member 'vmid' not described in 'si_dma_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/si_dma.c:446: warning: Function parameter or member 'pd_addr' not described in 'si_dma_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/si_dma.c:446: warning: Excess function parameter 'vm' description in 'si_dma_ring_emit_vm_flush' > drivers/gpu/drm/amd/amdgpu/si_dma.c:781: warning: Function parameter or member 'ib' not described in 'si_dma_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/si_dma.c:781: warning: Function parameter or member 'tmz' not described in 'si_dma_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/si_dma.c:781: warning: Excess function parameter 'ring' description in 'si_dma_emit_copy_buffer' > drivers/gpu/drm/amd/amdgpu/si_dma.c:804: warning: Function parameter or member 'ib' not described in 'si_dma_emit_fill_buffer' > drivers/gpu/drm/amd/amdgpu/si_dma.c:804: warning: Excess function parameter 'ring' description in 'si_dma_emit_fill_buffer' > > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied with minor changes. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/si_dma.c | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/si_dma.c b/drivers/gpu/drm/amd/amdgpu/si_dma.c > index 7d2bbcbe547b2..540dced190f33 100644 > --- a/drivers/gpu/drm/amd/amdgpu/si_dma.c > +++ b/drivers/gpu/drm/amd/amdgpu/si_dma.c > @@ -81,7 +81,9 @@ static void si_dma_ring_emit_ib(struct amdgpu_ring *ring, > * si_dma_ring_emit_fence - emit a fence on the DMA ring > * > * @ring: amdgpu ring pointer > - * @fence: amdgpu fence object > + * @addr: address > + * @seq: sequence number > + * @flags: fence related flags > * > * Add a DMA fence packet to the ring to write > * the fence seq number and DMA trap packet to generate > @@ -244,6 +246,7 @@ static int si_dma_ring_test_ring(struct amdgpu_ring *ring) > * si_dma_ring_test_ib - test an IB on the DMA engine > * > * @ring: amdgpu_ring structure holding ring information > + * @timeout: timeout value in jiffies, or MAX_SCHEDULE_TIMEOUT > * > * Test a simple IB in the DMA ring (VI). > * Returns 0 on success, error on failure. > @@ -401,6 +404,7 @@ static void si_dma_vm_set_pte_pde(struct amdgpu_ib *ib, > /** > * si_dma_pad_ib - pad the IB to the required number of dw > * > + * @ring: amdgpu_ring pointer > * @ib: indirect buffer to fill with padding > * > */ > @@ -436,7 +440,8 @@ static void si_dma_ring_emit_pipeline_sync(struct amdgpu_ring *ring) > * si_dma_ring_emit_vm_flush - cik vm flush using sDMA > * > * @ring: amdgpu_ring pointer > - * @vm: amdgpu_vm pointer > + * @vmid: vmid number to use > + * @pd_addr: address > * > * Update the page table base and flush the VM TLB > * using sDMA (VI). > @@ -764,10 +769,11 @@ static void si_dma_set_irq_funcs(struct amdgpu_device *adev) > /** > * si_dma_emit_copy_buffer - copy buffer using the sDMA engine > * > - * @ring: amdgpu_ring structure holding ring information > + * @ib: indirect buffer to copy to > * @src_offset: src GPU address > * @dst_offset: dst GPU address > * @byte_count: number of bytes to xfer > + * @tmz: unused > * > * Copy GPU buffers using the DMA engine (VI). > * Used by the amdgpu ttm implementation to move pages if > @@ -790,7 +796,7 @@ static void si_dma_emit_copy_buffer(struct amdgpu_ib *ib, > /** > * si_dma_emit_fill_buffer - fill buffer using the sDMA engine > * > - * @ring: amdgpu_ring structure holding ring information > + * @ib: indirect buffer to copy to > * @src_data: value to write to buffer > * @dst_offset: dst GPU address > * @byte_count: number of bytes to xfer > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Mon, Nov 23, 2020 at 6:19 AM Lee Jones <lee.jones@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c:1903: warning: Function parameter or member 'timeout' not described in 'gfx_v6_0_ring_test_ib' > > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c > index 671c46ebeced9..ca74638dec9b7 100644 > --- a/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c > @@ -1894,6 +1894,7 @@ static void gfx_v6_0_ring_emit_ib(struct amdgpu_ring *ring, > * gfx_v6_0_ring_test_ib - basic ring IB test > * > * @ring: amdgpu_ring structure holding ring information > + * @timeout: timeout value in jiffies, or MAX_SCHEDULE_TIMEOUT > * > * Allocate an IB and execute it on the gfx ring (SI). > * Provides a basic gfx ring test to verify that IBs are working. > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Only 900 (from 5000) to go! Lee Jones (40): drm/radeon/radeon_device: Consume our own header where the prototypes are located drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags' drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s 'job' param drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot misnaming issue drm/amd/amdgpu/cik_ih: Supply description for 'ih' in 'cik_ih_{get,set}_wptr()' drm/amd/amdgpu/uvd_v4_2: Fix some kernel-doc misdemeanours drm/amd/amdgpu/dce_v8_0: Supply description for 'async' drm/amd/amdgpu/cik_sdma: Supply some missing function param descriptions drm/amd/amdgpu/gfx_v7_0: Clean-up a bunch of kernel-doc related issues drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra param description drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of 'max_linewidth' drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place they are used drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc drm/amd/amdgpu/si_dma: Fix a bunch of function documentation issues drm/amd/amdgpu/gfx_v6_0: Supply description for 'gfx_v6_0_ring_test_ib()'s 'timeout' param drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting issues drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx' drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse drm/amd/amdgpu/uvd_v3_1: Fix-up some documentation issues drm/amd/amdgpu/dce_v6_0: Fix formatting and missing parameter description issues drm/amd/include/vega20_ip_offset: Mark top-level IP_BASE definition as __maybe_unused drm/amd/include/navi10_ip_offset: Mark top-level IP_BASE as __maybe_unused drm/amd/include/arct_ip_offset: Mark top-level IP_BASE definition as __maybe_unused drm/amd/include/navi14_ip_offset: Mark top-level IP_BASE as __maybe_unused drm/amd/include/navi12_ip_offset: Mark top-level IP_BASE as __maybe_unused drm/amd/include/sienna_cichlid_ip_offset: Mark top-level IP_BASE as __maybe_unused drm/amd/include/vangogh_ip_offset: Mark top-level IP_BASE as __maybe_unused drm/amd/include/dimgrey_cavefish_ip_offset: Mark top-level IP_BASE as __maybe_unused drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply 'global_state' description drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param descriptions drm/amd/amdgpu/cik_sdma: Add one and remove another function param description drm/amd/amdgpu/uvd_v4_2: Add one and remove another function param description drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing function param descriptions drm/amd/amdgpu/gmc_v7_0: Add some missing kernel-doc descriptions drm/amd/amdgpu/gmc_v8_0: Fix more issues attributed to copy/paste drm/msm/msm_drv: Make '_msm_ioremap()' static drm/amd/amdgpu/gmc_v9_0: Remove unused table 'ecc_umc_mcumc_status_addrs' drm/amd/amdgpu/gmc_v9_0: Suppy some missing function doc descriptions drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12 +- drivers/gpu/drm/amd/amdgpu/cik_ih.c | 2 + drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 18 ++- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 1 + drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 1 + drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 33 +++-- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 7 +- drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 5 + drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 38 +---- drivers/gpu/drm/amd/amdgpu/si_dma.c | 14 +- drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 10 +- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 10 +- drivers/gpu/drm/amd/include/arct_ip_offset.h | 4 +- .../amd/include/dimgrey_cavefish_ip_offset.h | 2 +- .../gpu/drm/amd/include/navi10_ip_offset.h | 2 +- .../gpu/drm/amd/include/navi12_ip_offset.h | 2 +- .../gpu/drm/amd/include/navi14_ip_offset.h | 2 +- .../amd/include/sienna_cichlid_ip_offset.h | 2 +- .../gpu/drm/amd/include/vangogh_ip_offset.h | 2 +- .../gpu/drm/amd/include/vega20_ip_offset.h | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 +-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 +- drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 2 +- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 75 +++++++++- .../drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 88 ------------ drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 4 +- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 ++- drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 5 +- drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 2 +- drivers/gpu/drm/msm/msm_drv.c | 4 +- .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++--------- drivers/gpu/drm/radeon/radeon_device.c | 1 + 37 files changed, 277 insertions(+), 268 deletions(-) delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h Cc: Alex Deucher <alexander.deucher@amd.com> Cc: amd-gfx@lists.freedesktop.org Cc: Ben Skeggs <bskeggs@redhat.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: David Airlie <airlied@linux.ie> Cc: Drew Davenport <ddavenport@chromium.org> Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Cc: Fritz Koenig <frkoenig@google.com> Cc: Hawking Zhang <Hawking.Zhang@amd.com> Cc: Huang Rui <ray.huang@amd.com> Cc: Jerome Glisse <glisse@freedesktop.org> Cc: Jiansong Chen <Jiansong.Chen@amd.com> Cc: Jonathan Marek <jonathan@marek.ca> Cc: Kalyan Thota <kalyan_t@codeaurora.org> Cc: Likun Gao <Likun.Gao@amd.com> Cc: linaro-mm-sig@lists.linaro.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: Luben Tuikov <luben.tuikov@amd.com> Cc: nouveau@lists.freedesktop.org Cc: Qinglang Miao <miaoqinglang@huawei.com> Cc: Rob Clark <robdclark@gmail.com> Cc: Sean Paul <sean@poorly.run> Cc: Sonny Jiang <sonny.jiang@amd.com> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: Tao Zhou <tao.zhou1@amd.com>