From patchwork Sat Nov 21 04:49:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Stultz X-Patchwork-Id: 330512 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2AAEC63697 for ; Sat, 21 Nov 2020 04:50:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8498C21D40 for ; Sat, 21 Nov 2020 04:50:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dWZndGYY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726738AbgKUEuD (ORCPT ); Fri, 20 Nov 2020 23:50:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726719AbgKUEuD (ORCPT ); Fri, 20 Nov 2020 23:50:03 -0500 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8C2CC0613CF for ; Fri, 20 Nov 2020 20:50:01 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id i13so9132514pgm.9 for ; Fri, 20 Nov 2020 20:50:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1dCpwtABCBAjt0w8Zd+Ad9bD2W4r2bOOZVX2c+Uu5fs=; b=dWZndGYY+uUFnjhTHmwgKC5kbCrdYmubSee+8hTXlbn/lIbOxvZ5Ttleyy46be1rVp qkjr2mvMwk7LjJWmsfxi3Q4PR6eFA0UA3aAUKtM4P2ZPe+0LcvmlhQcOgYPLkEdCIIzz wNJSVJ0EXPQ/HxHgOwIoeCjJqHxvAtGHQ7F4d2xt/aZfo3mkP4hHGzWSvOr7iTEJHtAj z93hcZeMjn9tZGTzsGiq6KvXp61nQQynOsvheETm4xBNBIa2RT0/JqqAsRTb3j63Rqx/ EMV0tlo39IeO6+VXs+9xIUNUCyxfoLQCYVohHcREV5xp0jF1u+vbO4uW4WRMeIFG5ZTl vHhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1dCpwtABCBAjt0w8Zd+Ad9bD2W4r2bOOZVX2c+Uu5fs=; b=dOe/fQsNRszoJtCIXbsik5eY9cBEb+3+aw0Deafwn9pJYq49OaER/KAu01CwwGHwZ+ jg3n4cDvQYZIWFZv7iZ6mgoADKpYAsX2RU8Ov2bCdxSxSBh++k1KFyoINZ8dQvP+tYpM gKP6dnJPm74hNqQpSO3ZBYV18pm5eVjOmLHkCZKMwCQEPu7l/nfFnjnnIvVVaqznisn7 qIWTfp7eSS9bOLn38PKRCQemzhY6U6oSdaYWS1GCfC55vvorLHgxDQ2TPEBeDu73bR33 a0Zjst5IQW3bTkUAGTefPGP1nVA/nvUQniCrqfA7q2kgvg2Lom8W+8j1bhMkmanU3hn5 LtnA== X-Gm-Message-State: AOAM533nBpQxpdFjZtgmQhypzIUIVDAQe1aJtl2UL5xmFzvIQ/5ZForN LMSlSppVQCcBeSRlVpL0Xe3VsQ== X-Google-Smtp-Source: ABdhPJyRE/0jIW/09/jq9G1nAs4OeW/5voPWRhKLPi853CLU1nhono7tAJRPn8bBZ4NkUjbxQj1OVQ== X-Received: by 2002:a17:90a:c003:: with SMTP id p3mr13414860pjt.221.1605934200086; Fri, 20 Nov 2020 20:50:00 -0800 (PST) Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id w196sm5407692pfd.177.2020.11.20.20.49.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 20:49:59 -0800 (PST) From: John Stultz To: lkml Cc: John Stultz , Sumit Semwal , Liam Mark , Laura Abbott , Brian Starkey , Hridya Valsaraju , Suren Baghdasaryan , Sandeep Patil , Daniel Mentz , Chris Goldsworthy , =?utf-8?q?=C3=98rjan_Eide?= , Robin Murphy , Ezequiel Garcia , Simon Ser , James Jones , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH v6 0/5] dma-buf: Code rework and performance improvements for system heap Date: Sat, 21 Nov 2020 04:49:50 +0000 Message-Id: <20201121044955.58215-1-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hey All, So just wanted to send another revision of my patch series of performance optimizations to the dma-buf system heap, this time against drm-misc-next. This series reworks the system heap to use sgtables, and then consolidates the pagelist method from the heap-helpers into the CMA heap. After which the heap-helpers logic is removed (as it is unused). I'd still like to find a better way to avoid some of the logic duplication in implementing the entire dma_buf_ops handlers per heap. But unfortunately that code is tied somewhat to how the buffer's memory is tracked. As more heaps show up I think we'll have a better idea how to best share code, so for now I think this is ok. After this, the series introduces an optimization that Ørjan Eide implemented for ION that avoids calling sync on attachments that don't have a mapping. Finally, an optimization to use larger order pages for the system heap. This change brings us closer to the current performance of the ION allocation code (though there still is a gap due to ION using a mix of deferred-freeing and page pools, I'll be looking at integrating those eventually). This version of the series does not include the system-uncached heap as Daniel wanted further demonstration that it is useful with devices that use the mesa stack. I'm working on such a justification but I don't want to hold up these rework patches in the meantime. thanks -john New in v6: * Dropped the system-uncached heap submission for now * Rebased onto drm-misc-next Cc: Sumit Semwal Cc: Liam Mark Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren Baghdasaryan Cc: Sandeep Patil Cc: Daniel Mentz Cc: Chris Goldsworthy Cc: Ørjan Eide Cc: Robin Murphy Cc: Ezequiel Garcia Cc: Simon Ser Cc: James Jones Cc: linux-media@vger.kernel.org Cc: dri-devel@lists.freedesktop.org John Stultz (5): dma-buf: system_heap: Rework system heap to use sgtables instead of pagelists dma-buf: heaps: Move heap-helper logic into the cma_heap implementation dma-buf: heaps: Remove heap-helpers code dma-buf: heaps: Skip sync if not mapped dma-buf: system_heap: Allocate higher order pages if available drivers/dma-buf/heaps/Makefile | 1 - drivers/dma-buf/heaps/cma_heap.c | 325 +++++++++++++++++---- drivers/dma-buf/heaps/heap-helpers.c | 274 ------------------ drivers/dma-buf/heaps/heap-helpers.h | 53 ---- drivers/dma-buf/heaps/system_heap.c | 411 ++++++++++++++++++++++++--- 5 files changed, 640 insertions(+), 424 deletions(-) delete mode 100644 drivers/dma-buf/heaps/heap-helpers.c delete mode 100644 drivers/dma-buf/heaps/heap-helpers.h