From patchwork Wed Nov 4 19:35:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 318165 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78978C55179 for ; Wed, 4 Nov 2020 19:35:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 173D12151B for ; Wed, 4 Nov 2020 19:35:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tPpnG9Xq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727001AbgKDTf5 (ORCPT ); Wed, 4 Nov 2020 14:35:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726604AbgKDTf4 (ORCPT ); Wed, 4 Nov 2020 14:35:56 -0500 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DBFAC0613D4 for ; Wed, 4 Nov 2020 11:35:56 -0800 (PST) Received: by mail-wm1-x32b.google.com with SMTP id p19so2555737wmg.0 for ; Wed, 04 Nov 2020 11:35:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jxJovM8uDqxzTsn9dVqfv0BrrWZVdtSmY0ZF8ZUveX8=; b=tPpnG9Xq0fL6ljrah9eqo6gIO+7EFirJIIvgiced9ycP88Q8KlHpshTpZKcvgizvJN DqVDEBLns8yBcUkmpYWgGUSuOeuHwc3TbeagV22ul0tUT7FGEaANe6mr2M3zH1Ec6Z05 dCH6ia3+OS223SMvWzLLHuXpDFCNLMIVdigWev4DmGI1eXmNginogEzXPeMA79X1yVLV 0qxxtJRnjyHJLEc/h2eBmqyGiNydmzfE3+aZSxanbJKMIY8u2keejYT051xW+oj82BfS wy+JhFXK6BjGfUjjwLP8W/PJD/RldyJXs3gJlou3nOdWUM0pUSiSA9aD3ga+L1YtZxim i6TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jxJovM8uDqxzTsn9dVqfv0BrrWZVdtSmY0ZF8ZUveX8=; b=MUGsq8IWT8o4Wr2BHzjRB3pGd+RA9iwqZIRltl5Tg8ccU5ibt2js9nIFobHqbbtMVb 1Dp4w64TPmPoANm7zK1Ktr7aX4sE+EDqwNNtdvhiO9Ncfek5wOp2rCA88un+qdRf/AdA oIGepJmM1/uG7u4ueYc9Sd6tkt03AtAje4wkm+hUsg67SF8IdKKq1P7cKUUtRqKYQV24 GHYeEXdh7jkvYI9oE51jMrpPeKJyIvD3zUGY4q5lvQSmPSqGYZ7gVKacqguOV9EMGko5 i0aMbThAL1qF+0Hxeg5XTXRUbHvQ6DYwIENb5MfQtEt+E4GkcD4jgXypWqjeBkEzT+wW NX+Q== X-Gm-Message-State: AOAM5323GwMXoNIOSFF4Pk6IJ4Ikd2TYCKaNXiqjCF94tzeNm3//aMFO ZEma8PSgVjpCJewDBzj+IMMGGw== X-Google-Smtp-Source: ABdhPJwDg2lxqbHlNGOB+b3ejFgNnWIzk2D54Jbj3ObyHrWkPcl/d3c3TSyNOcinZAfD1+eqPp2ICw== X-Received: by 2002:a1c:4e1a:: with SMTP id g26mr6283218wmh.98.1604518554550; Wed, 04 Nov 2020 11:35:54 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id x10sm4034444wrp.62.2020.11.04.11.35.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 11:35:53 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Alexandre Torgue , "Andrew J. Kroll" , Andrew Morton , Andy Gross , Benjamin Herrenschmidt , Bill Hawes , Bjorn Andersson , =?utf-8?q?Christian_K=C3=B6nig?= , Colin Ian King , "C. Scott Ananian" , "David A. Hinds" , dri-devel@lists.freedesktop.org, Filip Aben , Gerald Baeza , Greg Kroah-Hartman , Jakub Jelinek , Jan Dumon , Jiri Slaby , Jonathan Hunter , Joseph Barrow , -- , Kevin Wells , Laxman Dewangan , linaro-mm-sig@lists.linaro.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, Marko Kohtala , Maxime Coquelin , Michael Ellerman , Michal Simek , Mike Hudson , Miloslav Trmac , Nick Holloway , Palmer Dabbelt , paulkf@microgate.com, Paul Mackerras , Paul Walmsley , Philipp Zabel , processes-Sapan Bhatia , Robert Love , Rob Herring , Roland Stigge , Russell King , Russell King , Russ Gorby , Stanislav Voronyi , Sumit Semwal , Sylvain Lemieux , Thierry Reding , Vladimir Zapolskiy Subject: [PATCH 00/36] Rid W=1 issues from TTY Date: Wed, 4 Nov 2020 19:35:13 +0000 Message-Id: <20201104193549.4026187-1-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (36): tty: serdev: core: Remove unused variable 'dummy' tty: serdev: core: Provide missing description for 'owner' tty: tty_baudrate: Add missing description for 'tty' tty: tty_io: Move 'tty_sysctl_init's prototype to shared space tty: tty_buffer: Add missing description for 'limit' tty: tty_port: Demote obvious abuse of kernel-doc formatting tty: tty_jobctrl: Add missing function parameter descriptions tty: tty_ldisc: Fix some kernel-doc related misdemeanours tty: vt: consolemap: Demote weakly documented function header tty: n_tty: Add 2 missing parameter descriptions tty: serial: jsm: jsm_cls: Remove unused variable 'discard' tty: tty_io: Fix some kernel-doc issues tty: serial: 8250: 8250_port: Staticify functions referenced by pointers tty: serial: 8250: serial_cs: Remove unused/unchecked variable 'err' tty: tty_audit: Demote non-conformant kernel-doc headers tty: pty: Provide descriptions for the 'file' parameters tty: serial: amba-pl011: Mark 'sbsa_uart_acpi_match' as __maybe_unused tty: n_gsm: Demote obvious abuse of kernel-doc and supply other missing docss tty: serial: lpc32xx_hs: Remove unused variable 'tmp' tty: serial: msm_serial: Remove set but unused variable 'status' tty: serial: ifx6x60: Fix function documentation headers tty: serial: xilinx_uartps: Supply description for missing member 'cts_override' tty: synclink_gt: Demote one kernel-doc header and repair another tty: serial: serial-tegra: Struct headers should start with 'struct ' tty: serial: sifive: Struct headers should start with 'struct ' tty: synclinkmp: Add missing description for function param 'txqueue' tty: synclinkmp: Mark never checked 'readval' as __always_unused tty: serial: stm32-usart: Remove set but unused 'cookie' variables tty: tty_ldisc: Supply missing description for 'tty_ldisc_get's 'tty' param tty: serial: serial-tegra: Provide some missing struct member descriptions powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location tty: hvc: hvc_vio: Staticify function invoked only by reference tty: hvc: hvc_opal: Staticify function invoked by reference tty: serial: pmac_zilog: Make disposable variable __always_unused tty: synclink: Mark disposable variables as __always_unused tty: synclink: Provide missing description for 'hdlcdev_tx_timeout's 'txqueue' param arch/powerpc/include/asm/hvconsole.h | 3 +++ arch/powerpc/platforms/pseries/pseries.h | 3 --- arch/powerpc/platforms/pseries/setup.c | 1 + drivers/tty/hvc/hvc_opal.c | 2 +- drivers/tty/hvc/hvc_vio.c | 2 +- drivers/tty/n_gsm.c | 4 +++- drivers/tty/n_tty.c | 2 ++ drivers/tty/pty.c | 2 ++ drivers/tty/serdev/core.c | 6 ++---- drivers/tty/serial/8250/8250_port.c | 4 ++-- drivers/tty/serial/8250/serial_cs.c | 9 +++------ drivers/tty/serial/amba-pl011.c | 2 +- drivers/tty/serial/ifx6x60.c | 3 ++- drivers/tty/serial/jsm/jsm_cls.c | 4 +--- drivers/tty/serial/lpc32xx_hs.c | 3 +-- drivers/tty/serial/msm_serial.c | 3 +-- drivers/tty/serial/pmac_zilog.h | 2 +- drivers/tty/serial/serial-tegra.c | 7 ++++++- drivers/tty/serial/sifive.c | 3 ++- drivers/tty/serial/stm32-usart.c | 6 ++---- drivers/tty/serial/xilinx_uartps.c | 1 + drivers/tty/synclink.c | 5 +++-- drivers/tty/synclink_gt.c | 3 ++- drivers/tty/synclinkmp.c | 3 ++- drivers/tty/tty_audit.c | 12 ++++++------ drivers/tty/tty_baudrate.c | 1 + drivers/tty/tty_buffer.c | 1 + drivers/tty/tty_io.c | 12 +++++++----- drivers/tty/tty_jobctrl.c | 3 +++ drivers/tty/tty_ldisc.c | 11 ++++++----- drivers/tty/tty_port.c | 4 ++-- drivers/tty/vt/consolemap.c | 3 +-- include/linux/tty.h | 1 + 33 files changed, 73 insertions(+), 58 deletions(-) Cc: Alexandre Torgue Cc: "Andrew J. Kroll" Cc: Andrew Morton Cc: Andy Gross Cc: Benjamin Herrenschmidt Cc: Bill Hawes Cc: Bjorn Andersson Cc: "Christian König" Cc: Colin Ian King Cc: "C. Scott Ananian" Cc: "David A. Hinds" Cc: dri-devel@lists.freedesktop.org Cc: Filip Aben Cc: Gerald Baeza Cc: Greg Kroah-Hartman Cc: Jakub Jelinek Cc: Jan Dumon Cc: Jiri Slaby Cc: Jonathan Hunter Cc: Joseph Barrow Cc: -- Cc: Kevin Wells Cc: Laxman Dewangan Cc: linaro-mm-sig@lists.linaro.org Cc: linux-arm-msm@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-riscv@lists.infradead.org Cc: linux-serial@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-tegra@vger.kernel.org Cc: Marko Kohtala Cc: Maxime Coquelin Cc: Michael Ellerman Cc: Michal Simek Cc: Mike Hudson Cc: Miloslav Trmac Cc: Nick Holloway Cc: Palmer Dabbelt Cc: paulkf@microgate.com Cc: Paul Mackerras Cc: Paul Walmsley Cc: Philipp Zabel Cc: processes-Sapan Bhatia Cc: Robert Love Cc: Rob Herring Cc: Roland Stigge Cc: Russell King Cc: Russell King Cc: Russ Gorby Cc: Stanislav Voronyi Cc: Sumit Semwal Cc: Sylvain Lemieux Cc: Thierry Reding Cc: Vladimir Zapolskiy