mbox series

[0/2] zoran: sparse/smatch fixes

Message ID 20200928132831.1587872-1-hverkuil-cisco@xs4all.nl
Headers show
Series zoran: sparse/smatch fixes | expand

Message

Hans Verkuil Sept. 28, 2020, 1:28 p.m. UTC 
Two patches on top of Corentine's patch series:

'[PATCH RFT/RFC v2 00/47] staging: media: bring back zoran driver'

This fixes smatch and sparse warnings and will be added to the
upcoming PR.

Regards,

	Hans

Hans Verkuil (2):
  zoran: fix smatch warning
  zoran: fix sparse warnings

 drivers/staging/media/zoran/zoran_device.c |  8 ++++----
 drivers/staging/media/zoran/zoran_driver.c | 15 +++++++--------
 2 files changed, 11 insertions(+), 12 deletions(-)

Comments

Corentin Labbe Oct. 2, 2020, 7:29 a.m. UTC | #1 
On Mon, Sep 28, 2020 at 03:28:30PM +0200, Hans Verkuil wrote:
> drivers/staging/media/zoran/zoran_device.c:941 zoran_irq() warn: inconsistent indenting
> 
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> ---
>  drivers/staging/media/zoran/zoran_device.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/media/zoran/zoran_device.c b/drivers/staging/media/zoran/zoran_device.c
> index 1fe91e16658b..ecd6c5293a87 100644
> --- a/drivers/staging/media/zoran/zoran_device.c
> +++ b/drivers/staging/media/zoran/zoran_device.c
> @@ -938,10 +938,10 @@ irqreturn_t zoran_irq(int irq, void *dev_id)
>  				pci_err(zr->pci_dev, "JPG IRQ when not in good mode\n");
>  				return IRQ_HANDLED;
>  			}
> -		zr->frame_num++;
> -		zoran_reap_stat_com(zr);
> -		zoran_feed_stat_com(zr);
> -		return IRQ_HANDLED;
> +			zr->frame_num++;
> +			zoran_reap_stat_com(zr);
> +			zoran_feed_stat_com(zr);
> +			return IRQ_HANDLED;
>  		}
>  		/* unused interrupts */
>  	}
> -- 
> 2.28.0
> 

Hello

Acked-by: Corentin Labbe <clabbe@baylibre.com>

Thanks