mbox series

[v14,0/2] media: i2c: Add support for OV02A10 sensor

Message ID 20200902120122.24456-1-dongchun.zhu@mediatek.com
Headers show
Series media: i2c: Add support for OV02A10 sensor | expand

Message

Dongchun Zhu Sept. 2, 2020, 12:01 p.m. UTC 
Hello,

This series adds YAML DT binding and V4L2 sub-device driver for Omnivision's
OV02A10 2-megapixel 10-bit RAW CMOS 1/5" sensor, which has a single MIPI lane
interface and uses the I2C bus for control and the CSI-2 bus for data.

The driver is implemented with V4L2 framework.
 - Async registered as a V4L2 sub-device.
 - As the first component of camera system including Seninf, ISP pipeline.
 - A media entity that provides one source pad in common and two for dual-cam.

Also this driver supports following features:
 - Manual exposure and analog gain control support
 - Vertical blanking control support
 - Test pattern support
 - Media controller support
 - Runtime PM support
 - Support resolution: 1600x1200 at 30FPS
 
Previous versions of this patch-set can be found here:
 v13: https://lore.kernel.org/linux-media/20200710101850.4604-1-dongchun.zhu@mediatek.com/
 v12: https://lore.kernel.org/linux-media/20200702115223.21507-1-dongchun.zhu@mediatek.com/
 v11: https://lore.kernel.org/linux-media/20200630024942.20891-1-dongchun.zhu@mediatek.com/
 v10: https://lore.kernel.org/linux-media/20200615122937.18965-3-dongchun.zhu@mediatek.com/
 v09: https://lore.kernel.org/linux-media/20200523084103.31276-1-dongchun.zhu@mediatek.com/
 v08: https://lore.kernel.org/linux-media/20200509080627.23222-1-dongchun.zhu@mediatek.com/
 v07: https://lore.kernel.org/linux-media/20200430080924.1140-1-dongchun.zhu@mediatek.com/
 v06: https://lore.kernel.org/linux-media/20191211112849.16705-1-dongchun.zhu@mediatek.com/
 v05: https://lore.kernel.org/linux-media/20191104105713.24311-1-dongchun.zhu@mediatek.com/
 v04: https://lore.kernel.org/linux-media/20190907092728.23897-1-dongchun.zhu@mediatek.com/
 v03: https://lore.kernel.org/linux-media/20190819034331.13098-1-dongchun.zhu@mediatek.com/
 v02: https://lore.kernel.org/linux-media/20190704084651.3105-1-dongchun.zhu@mediatek.com/
 v01: https://lore.kernel.org/linux-media/20190523102204.24112-1-dongchun.zhu@mediatek.com/

Changes of v14 mainly address comments from Tomasz and Sakari.
Compared to v13:
 - Fix imperfections in DT
 - Use an array property "ovti,mipi-clock-voltage" to indicate MIPI TX speed
 - Add the handler to the optional property "ovti,mipi-clock-voltage" in driver

Please help to review this patch.
Thanks.

Dongchun Zhu (2):
  media: dt-bindings: media: i2c: Document OV02A10 bindings
  media: i2c: Add OV02A10 image sensor driver

 .../bindings/media/i2c/ovti,ov02a10.yaml           |  161 +++
 MAINTAINERS                                        |    8 +
 drivers/media/i2c/Kconfig                          |   13 +
 drivers/media/i2c/Makefile                         |    1 +
 drivers/media/i2c/ov02a10.c                        | 1083 ++++++++++++++++++++
 5 files changed, 1266 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
 create mode 100644 drivers/media/i2c/ov02a10.c

-- 
2.9.2

Comments

Rob Herring (Arm) Sept. 3, 2020, 4:13 p.m. UTC | #1 
On Wed, 02 Sep 2020 20:01:21 +0800, Dongchun Zhu wrote:
> Add YAML device tree binding for OV02A10 CMOS image sensor,
> and the relevant MAINTAINERS entries.
> 
> Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> ---
>  .../bindings/media/i2c/ovti,ov02a10.yaml           | 161 +++++++++++++++++++++
>  MAINTAINERS                                        |   7 +
>  2 files changed, 168 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml
> 


My bot found errors running 'make dt_binding_check' on your patch:

Error: Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.example.dts:28.45-46 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1366: dt_binding_check] Error 2


See https://patchwork.ozlabs.org/patch/1355723

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.
Dongchun Zhu Sept. 4, 2020, 3:24 a.m. UTC | #2 
Hello Rob,

Thanks for the review.

On Thu, 2020-09-03 at 10:13 -0600, Rob Herring wrote:
> On Wed, 02 Sep 2020 20:01:21 +0800, Dongchun Zhu wrote:

> > Add YAML device tree binding for OV02A10 CMOS image sensor,

> > and the relevant MAINTAINERS entries.

> > 

> > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>

> > ---

> >  .../bindings/media/i2c/ovti,ov02a10.yaml           | 161 +++++++++++++++++++++

> >  MAINTAINERS                                        |   7 +

> >  2 files changed, 168 insertions(+)

> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml

> > 

> 

> 

> My bot found errors running 'make dt_binding_check' on your patch:

> 

> Error: Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.example.dts:28.45-46 syntax error

> FATAL ERROR: Unable to parse input tree

> make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.example.dt.yaml] Error 1

> make[1]: *** Waiting for unfinished jobs....

> make: *** [Makefile:1366: dt_binding_check] Error 2

> 

> 

> See https://patchwork.ozlabs.org/patch/1355723

> 

> If you already ran 'make dt_binding_check' and didn't see the above

> error(s), then make sure dt-schema is up to date:

> 

> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

> 

> Please check and re-submit.

> 


So much sorry for the mistake I've made.
I forgot to include the header file 'dt-bindings/gpio/gpio.h'.
This would be fixed in next release :-)