| Message ID | 20200629065754.26621-1-dafna.hirschfeld@collabora.com |
|---|---|
| Headers | show |
| Series | media: staging: rkisp1: document rkisp1-common.h | expand |
On 6/29/20 3:57 AM, Dafna Hirschfeld wrote: > The field ctrl_handler in struct rkisp1_device is not used. > This patch removes it. > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Acked-by: Helen Koike <helen.koike@collabora.com> Thanks > --- > drivers/staging/media/rkisp1/rkisp1-common.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-common.h b/drivers/staging/media/rkisp1/rkisp1-common.h > index 45e554169224..eb0dbc42d09c 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-common.h > +++ b/drivers/staging/media/rkisp1/rkisp1-common.h > @@ -250,7 +250,6 @@ struct rkisp1_device { > unsigned int clk_size; > struct clk_bulk_data clks[RKISP1_MAX_BUS_CLK]; > struct v4l2_device v4l2_dev; > - struct v4l2_ctrl_handler ctrl_handler; > struct media_device media_dev; > struct v4l2_async_notifier notifier; > struct rkisp1_sensor_async *active_sensor; >
On 6/29/20 3:57 AM, Dafna Hirschfeld wrote: > The field alloc_ctx in struct rkisp1_device is not used. > This patch removes it. > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Acked-by: Helen Koike <helen.koike@collabora.com> Thanks > --- > drivers/staging/media/rkisp1/rkisp1-common.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/media/rkisp1/rkisp1-common.h b/drivers/staging/media/rkisp1/rkisp1-common.h > index eb0dbc42d09c..b7dc523dd8f0 100644 > --- a/drivers/staging/media/rkisp1/rkisp1-common.h > +++ b/drivers/staging/media/rkisp1/rkisp1-common.h > @@ -259,7 +259,6 @@ struct rkisp1_device { > struct rkisp1_stats stats; > struct rkisp1_params params; > struct media_pipeline pipe; > - struct vb2_alloc_ctx *alloc_ctx; > struct mutex stream_lock; > struct rkisp1_debug debug; > }; >
This patchset extends the documentation of rkisp1-common.h. It adds a line description of every struct and every field, and also a line description of every lock. Three minor fixes found during documentation are also in this set. This patchset solves the TODO item: 'Document rkisp1-common.h' NOTE: This patchset is rebased on top of v2 of the patchset "media: staging: rkisp1: move stats reading to irq handler" https://patchwork.kernel.org/project/linux-media/list/?series=308787 This is because that patchset changes the lock fields in the rkisp1-stats struct. Dafna Hirschfeld (4): media: staging: rkisp1: remove unused field ctrl_handler from struct rkisp1_device media: staging: rkisp1: remove unused field alloc_ctx from struct rkisp1_device media: staging: rkisp1: set pads array of the resizer to size 2 media: staging: rkisp1: improve documentation of rkisp1-common.h drivers/staging/media/rkisp1/TODO | 1 - drivers/staging/media/rkisp1/rkisp1-common.h | 140 ++++++++++++++---- drivers/staging/media/rkisp1/rkisp1-resizer.c | 2 +- 3 files changed, 110 insertions(+), 33 deletions(-)