| Message ID | 1690631575-15124-1-git-send-email-wentong.wu@intel.com |
|---|---|
| Headers | show |
| Series | media: pci: intel: ivsc: Add driver of Intel Visual Sensing Controller(IVSC) | expand |
On Sat, Jul 29, 2023 at 11:44 PM Sakari Ailus <sakari.ailus@linux.intel.com> wrote: > > Hi Rafael, > > On Sat, Jul 29, 2023 at 07:52:55PM +0800, Wentong Wu wrote: > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > > index 2743444..59c92a9 100644 > > --- a/drivers/acpi/scan.c > > +++ b/drivers/acpi/scan.c > > @@ -796,6 +796,9 @@ static const char * const acpi_ignore_dep_ids[] = { > > /* List of HIDs for which we honor deps of matching ACPI devs, when checking _DEP lists. */ > > static const char * const acpi_honor_dep_ids[] = { > > "INT3472", /* Camera sensor PMIC / clk and regulator info */ > > + "INTC1059", /* IVSC (TGL) driver must be loaded to allow i2c access to camera sensors */ > > + "INTC1095", /* IVSC (ADL) driver must be loaded to allow i2c access to camera sensors */ > > + "INTC100A", /* IVSC (RPL) driver must be loaded to allow i2c access to camera sensors */ > > NULL > > }; > > > > Could this patch be merged via the ACPI tree? There's no direct dependency > to the two other patches in the set. > > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com> Applied (under a slightly edited subject) as 6.6 material, thanks!
On Thu, Aug 17, 2023 at 06:30:54PM +0200, Rafael J. Wysocki wrote: > On Sat, Jul 29, 2023 at 11:44 PM Sakari Ailus > <sakari.ailus@linux.intel.com> wrote: > > > > Hi Rafael, > > > > On Sat, Jul 29, 2023 at 07:52:55PM +0800, Wentong Wu wrote: > > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > > > index 2743444..59c92a9 100644 > > > --- a/drivers/acpi/scan.c > > > +++ b/drivers/acpi/scan.c > > > @@ -796,6 +796,9 @@ static const char * const acpi_ignore_dep_ids[] = { > > > /* List of HIDs for which we honor deps of matching ACPI devs, when checking _DEP lists. */ > > > static const char * const acpi_honor_dep_ids[] = { > > > "INT3472", /* Camera sensor PMIC / clk and regulator info */ > > > + "INTC1059", /* IVSC (TGL) driver must be loaded to allow i2c access to camera sensors */ > > > + "INTC1095", /* IVSC (ADL) driver must be loaded to allow i2c access to camera sensors */ > > > + "INTC100A", /* IVSC (RPL) driver must be loaded to allow i2c access to camera sensors */ > > > NULL > > > }; > > > > > > > Could this patch be merged via the ACPI tree? There's no direct dependency > > to the two other patches in the set. > > > > Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com> > > Applied (under a slightly edited subject) as 6.6 material, thanks! Thanks, Rafael!
Intel Visual Sensing Controller (IVSC), codenamed "Clover Falls", is a companion chip designed to provide secure and low power vision capability to IA platforms. IVSC is available in existing commercial platforms from multiple OEMs. The primary use case of IVSC is to bring in context awareness. IVSC interfaces directly with the platform main camera sensor via a CSI-2 link and processes the image data with the embedded AI engine. The detected events are sent over I2C to ISH (Intel Sensor Hub) for additional data fusion from multiple sensors. The fusion results are used to implement advanced use cases like: - Face detection to unlock screen - Detect user presence to manage backlight setting or waking up system Since the Image Processing Unit(IPU) used on the host processor needs to configure the CSI-2 link in normal camera usages, the CSI-2 link and camera sensor can only be used in mutually-exclusive ways by host IPU and IVSC. By default the IVSC owns the CSI-2 link and camera sensor. The IPU driver can take ownership of the CSI-2 link and camera sensor using the interfaces exported via v4l2 sub-device. Switching ownership requires an interface with two different hardware modules inside IVSC. The software interface to these modules is via Intel MEI (The Intel Management Engine) commands. These two hardware modules have two different MEI UUIDs to enumerate. These hardware modules are: - ACE (Algorithm Context Engine): This module is for algorithm computing when IVSC owns camera sensor. Also ACE module controls camera sensor's ownership. This hardware module is used to set ownership of camera sensor. - CSI (Camera Serial Interface): This module is used to route camera sensor data either to IVSC or to host for IPU driver and application. IVSC also provides a privacy mode. When privacy mode is turned on, camera sensor can't be used. This means that both ACE and host IPU can't get image data. And when this mode is turned on, users are informed via v4l2 control API. In summary, to acquire ownership of camera by IPU driver, first ACE module needs to be informed of ownership and then to setup MIPI CSI-2 link for the camera sensor and IPU. Implementation: There are two different drivers to handle ACE and CSI hardware modules inside IVSC. - ivsc_csi: MEI client driver to send commands and receive notifications from CSI module. - ivsc_ace: MEI client driver to send commands and get status from ACE module. Interface is exposed via v4l2 sub-devcie APIs to acquire and release camera sensor and CSI-2 link. Below diagram shows connections of IVSC/ISH/IPU/Camera sensor. ----------------------------------------------------------------------------- | Host Processor | | | | ----------------- ----------------- --------------- | | | | | | | | I2C | | | IPU | | ISH | |camera driver|--| | | | | | | | | | | | ----------------- ----------------- --------------- | | | | | | | | | | | --------------- | | | | | | | | | | | | | IVSC driver | | | | | | | | | | | | | --------------- | | | | | | | | ----------------|-----------------------|----------------------|---------|--- | CSI | I2C |SPI | | | | | ----------------|-----------------------|---------------- | | | IVSC | | | | | | | | | | ----------------- ----------------- | | | | | | | | | | | | | CSI | | ACE | |------| | | | | | | | | | ----------------- ----------------- | | | | | I2C | | ----------------|-----------------------|---------------- | | CSI | | | | | -------------------------------- | | | I2C | | camera sensor |-----------------------------| | | -------------------------------- The drivers have been tested with IPU6 and ov01a1s by below commands: media-ctl -v -V "\"Intel IVSC CSI\":0 [fmt:SGRBG10/1296x798]" media-ctl -v -V "\"Intel IVSC CSI\":1 [fmt:SGRBG10/1296x798]" media-ctl -v -V "\"Intel IPU6 CSI2 1\":0 [fmt:SGRBG10/1296x798]" media-ctl -v -V "\"Intel IPU6 CSI2 1\":1 [fmt:SGRBG10/1296x798]" media-ctl -l "\"Intel IVSC CSI\":0 -> \"Intel IPU6 CSI2 1\":0[1]" media-ctl -v -l "\"Intel IPU6 CSI2 1\":1 -> \"Intel IPU6 ISYS Capture 0\":0[5]" yavta -c100 -n5 -I -s 1296x798 --file=/tmp/frame-CSI1.bin -f SGRBG10 /dev/video0 --- v10: - use v4l2_ctrl_new_int_menu for mei_csi frequency control - add sub dev name for mei_csi - add post_probe_work for mei_ace to probe sensor after mei_ace v9: - revert v8's change because it is not suitable for MEI framework v8: - use new uuid structure and macro v7: - add more comments for IVSC ACPI dev v6: - add V4L2_SUBDEV_FL_HAS_EVENTS flag for csi subdev - add the LINK FREQUENCY volatile control - query sensor link frequency with v4l2_get_link_freq api - add error handling for creating device link - fix coding style issues v5: - probe mei_csi only after software node has been setup v4: - call v4l2_ctrl_handler_free() if setting up the handler failed - set V4L2_CTRL_FLAG_READ_ONLY for privacy_ctrl - add dev_warn if failed to switch CSI-2 link to IVSC - use v4l2_fwnode_endpoint_alloc_parse to get num_data_lanes - add document about how sensor connected to IVSC is powered - move lock to mei_ace_send - check return value for device_link_add Wentong Wu (3): media: pci: intel: ivsc: Add CSI submodule media: pci: intel: ivsc: Add ACE submodule ACPI: delay enumeration of devices with a _DEP pointing to IVSC device drivers/acpi/scan.c | 3 + drivers/media/pci/Kconfig | 1 + drivers/media/pci/intel/Makefile | 2 + drivers/media/pci/intel/ivsc/Kconfig | 12 + drivers/media/pci/intel/ivsc/Makefile | 9 + drivers/media/pci/intel/ivsc/mei_ace.c | 579 +++++++++++++++++++++++ drivers/media/pci/intel/ivsc/mei_csi.c | 825 +++++++++++++++++++++++++++++++++ 7 files changed, 1431 insertions(+) create mode 100644 drivers/media/pci/intel/ivsc/Kconfig create mode 100644 drivers/media/pci/intel/ivsc/Makefile create mode 100644 drivers/media/pci/intel/ivsc/mei_ace.c create mode 100644 drivers/media/pci/intel/ivsc/mei_csi.c