mbox series

[RESEND,v2,0/4] Venus - change clk enable, disable order and change bw values

Message ID 1600305963-7659-1-git-send-email-mansur@codeaurora.org
Headers show
Series Venus - change clk enable, disable order and change bw values | expand

Message

Mansur Alisha Shaik Sept. 17, 2020, 1:25 a.m. UTC 
The intention of this patchset is to correct clock enable and disable
order and vote for venus-ebi and cpucfg paths with average bandwidth
instad of peak bandwidth since with current implementation we are seeing
clock related warning during XO-SD and suspend device while video playback
---
Resending as all patches not updated properly because
of some mailing issues

Mansur Alisha Shaik (4):
  venus: core: change clk enable and disable order in resume and suspend
  venus: core: vote for video-mem path
  venus: core: vote with average bandwidth and peak bandwidth as zero
  venus: put dummy vote on video-mem path after last session release

 drivers/media/platform/qcom/venus/core.c       | 29 +++++++++++++++++++-------
 drivers/media/platform/qcom/venus/pm_helpers.c |  3 +++
 2 files changed, 25 insertions(+), 7 deletions(-)

Comments

Stephen Boyd Sept. 17, 2020, 7:20 a.m. UTC | #1 
Quoting Mansur Alisha Shaik (2020-09-16 18:26:01)
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c

> index 52a3886..064b6c8 100644

> --- a/drivers/media/platform/qcom/venus/core.c

> +++ b/drivers/media/platform/qcom/venus/core.c

> @@ -363,8 +363,16 @@ static __maybe_unused int venus_runtime_suspend(struct device *dev)

>  

>         ret = icc_set_bw(core->cpucfg_path, 0, 0);

>         if (ret)

> -               return ret;

> +               goto err_poweron_core;

> +

> +       ret = icc_set_bw(core->video_path, 0, 0);

> +       if (ret)

> +               goto err_poweron_core;

> +

> +       return ret;

>  

> +err_poweron_core:

> +       pm_ops->core_power(dev, POWER_ON);


Don't we need to put back the bandwidth from before suspend was entered
if the video_path fails?

>         return ret;

>  }

>
Stephen Boyd Sept. 17, 2020, 7:20 a.m. UTC | #2 
Quoting Mansur Alisha Shaik (2020-09-16 18:26:00)
> Currently video driver is voting after clk enable and un voting
> before clk disable. Basically we should vote before clk enable
> and un vote after clk disable.
> 
> Corrected this by changing the order of clk enable and clk disable.
> 
> Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
> ---

Reviewed-by: Stephen Boyd <swboyd@chromium.org>