From patchwork Sat Aug 4 16:51:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 143447 Delivered-To: patch@linaro.org Received: by 2002:a2e:9754:0:0:0:0:0 with SMTP id f20-v6csp1460836ljj; Sat, 4 Aug 2018 09:52:20 -0700 (PDT) X-Google-Smtp-Source: AAOMgpePhF9sHB4QkVL1W45iyCIk3n7wJKY2wecxQXYoLpSfT1zWXxLpV7wYmDZA+jNGnnbNSbEt X-Received: by 2002:a17:902:76c5:: with SMTP id j5-v6mr7808196plt.296.1533401539968; Sat, 04 Aug 2018 09:52:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1533401539; cv=none; d=google.com; s=arc-20160816; b=BlVGAN4Jmet4ruF8EDez0NSVNlXYhOVfTKAP4l95qTWXHA0BxPCeyzLybw1fFIPkfI G238VyTuxpJb6QU7orMsCxait+W7dKoNNZRflHkBBAltZpUHrqi08NHzFiX/S1sX/5g7 b1A/wo+QUV+DEowWEcHT0gv3liyfWFlCwyRth9fnHN8wqEv9nGUTRvfaaPdRzCF0cqmX hX7QdN2bkHV7UNuJ+QXEO6KieyG+7SZQznG3w8e81TRdPe6AnASqABjoGyA3YETzqoFN KPZuK63ey2mqiTrsQ9Ubh34DG97MaElw3mRcQqZvX9vM1hW/NyUqlAOSkNDL0xqHGacv nc2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=b+z7hcd0XQf78yOCKizJRDtrskWFR2izhC34atWh1k0=; b=VncoaYWfvzVValm97inpNaDCrwGVcUtjQ6LaFVc19RxmzPlKx2+CYpevWm6DREbNQg ad3N+xXdcqDyxKl53EpstomJze0egesJnvntDi+We/h8g7gtse0zV+Wp41xqNYyVlhFI GvPwEgvqG7CNs4toV3xLoohDkBhCDH2eiOluSLgb88dkjhWXs2HftH1i6gEaSK1nELtB fZj4Fsw7xPFLmRLeXkU8NWxb0jNiLk0mspc1LePUw+xbK7a5n7trglPKcBeNNrm87uNU FKc9CUTga8cBkoDlHZAzM+7FDJIuhZqnv8UrXQqqu+W1yI7N5Ic+P42LTN547L0LwsYg l0BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NILlhvW5; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t191-v6si7045661pgc.481.2018.08.04.09.52.19; Sat, 04 Aug 2018 09:52:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=NILlhvW5; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729693AbeHDSxe (ORCPT + 1 other); Sat, 4 Aug 2018 14:53:34 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:34458 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729690AbeHDSxd (ORCPT ); Sat, 4 Aug 2018 14:53:33 -0400 Received: by mail-pf1-f194.google.com with SMTP id k19-v6so4826037pfi.1 for ; Sat, 04 Aug 2018 09:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=b+z7hcd0XQf78yOCKizJRDtrskWFR2izhC34atWh1k0=; b=NILlhvW5PPvGcRTekeH6VmMdsFFyTH6qULH5PlAUFh1Aru2hmWtr6GtINouTxfDJqV VAPRa0yenEeYHpgbPs5x3RLFTz4dOG1RpD6iZhHQQ3ar6Wg4zWiNLElBiQgLInGuCHCg dSn1dQGqZGlbD9X//8zs/Ho8nkn5yS1chEwuc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=b+z7hcd0XQf78yOCKizJRDtrskWFR2izhC34atWh1k0=; b=pHAMrjr1r/tGf1fK6ZUGQqjB0UCH7SwyZO3eKv60xUUtAqfnqSduTerj/42i4vCM5Z UR2MveN9LLxkPTkYRp2Hlo35xQfUFH4sYfzp/M5WLD5ieTwpz6R7CNJkaT7K+1lk7v6N SSFErmx1fndDtmn6ZwrC2FkLT5SG0dfnPKewyqKztRkLa58qNVeVZ4zKlPPqWlr5fz+f 62bMiyg5IFoFe3C0geFBk2y+898TWczm37e/TynFiBUO7IEoBqnstufFwVdy/GKhusKM RqSphihjsrC11Ixx5xZVyhMHWw6ZTGER0fZKYqvw6KsRrKavavivBu8vLAuoJ4oarchh ywTg== X-Gm-Message-State: AOUpUlFzug7G9THgoJUgbiXSNYE1gSPYVSvBz3b/vt7VUNt5OTUqS6KX sGD0RS8o4AJJv3fVNipL9WYZ1w== X-Received: by 2002:aa7:86d7:: with SMTP id h23-v6mr9761365pfo.132.1533401536877; Sat, 04 Aug 2018 09:52:16 -0700 (PDT) Received: from ubuntu.localdomain ([45.56.155.8]) by smtp.gmail.com with ESMTPSA id x80-v6sm17880733pfe.129.2018.08.04.09.52.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 04 Aug 2018 09:52:16 -0700 (PDT) From: Baolin Wang To: jacek.anaszewski@gmail.com, pavel@ucw.cz Cc: rteysseyre@gmail.com, bjorn.andersson@linaro.org, baolin.wang@linaro.org, broonie@kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller Date: Sat, 4 Aug 2018 09:51:37 -0700 Message-Id: X-Mailer: git-send-email 1.9.1 In-Reply-To: <66b08912a2f9f9f013913162f65abc8f94c066cf.1533400193.git.baolin.wang@linaro.org> References: <66b08912a2f9f9f013913162f65abc8f94c066cf.1533400193.git.baolin.wang@linaro.org> In-Reply-To: <66b08912a2f9f9f013913162f65abc8f94c066cf.1533400193.git.baolin.wang@linaro.org> References: <66b08912a2f9f9f013913162f65abc8f94c066cf.1533400193.git.baolin.wang@linaro.org> Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org This patch implements the 'pattern_set'and 'pattern_clear' interfaces to support SC27XX LED breathing mode. Signed-off-by: Baolin Wang --- Changes from v2: - None. Changes from v1: - Remove pattern_get interface. --- drivers/leds/leds-sc27xx-bltc.c | 94 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 94 insertions(+) -- 1.9.1 diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers/leds/leds-sc27xx-bltc.c index 9d9b7aa..297dd43 100644 --- a/drivers/leds/leds-sc27xx-bltc.c +++ b/drivers/leds/leds-sc27xx-bltc.c @@ -32,8 +32,13 @@ #define SC27XX_DUTY_MASK GENMASK(15, 0) #define SC27XX_MOD_MASK GENMASK(7, 0) +#define SC27XX_CURVE_SHIFT 8 +#define SC27XX_CURVE_L_MASK GENMASK(7, 0) +#define SC27XX_CURVE_H_MASK GENMASK(15, 8) + #define SC27XX_LEDS_OFFSET 0x10 #define SC27XX_LEDS_MAX 3 +#define SC27XX_LEDS_PATTERN_CNT 4 struct sc27xx_led { char name[LED_MAX_NAME_SIZE]; @@ -122,6 +127,91 @@ static int sc27xx_led_set(struct led_classdev *ldev, enum led_brightness value) return err; } +static int sc27xx_led_pattern_clear(struct led_classdev *ldev) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + struct regmap *regmap = leds->priv->regmap; + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + int err; + + mutex_lock(&leds->priv->lock); + + /* Reset the rise, high, fall and low time to zero. */ + regmap_write(regmap, base + SC27XX_LEDS_CURVE0, 0); + regmap_write(regmap, base + SC27XX_LEDS_CURVE1, 0); + + err = regmap_update_bits(regmap, ctrl_base, + (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift, 0); + + mutex_unlock(&leds->priv->lock); + + return err; +} + +static int sc27xx_led_pattern_set(struct led_classdev *ldev, + struct led_pattern *pattern, + int len, u32 repeat) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + struct regmap *regmap = leds->priv->regmap; + int err; + + /* + * Must contain 4 patterns to configure the rise time, high time, fall + * time and low time to enable the breathing mode. + */ + if (len != SC27XX_LEDS_PATTERN_CNT) + return -EINVAL; + + mutex_lock(&leds->priv->lock); + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_L_MASK, pattern[0].delta_t); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_L_MASK, pattern[1].delta_t); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_H_MASK, + pattern[2].delta_t << SC27XX_CURVE_SHIFT); + if (err) + goto out; + + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_H_MASK, + pattern[3].delta_t << SC27XX_CURVE_SHIFT); + if (err) + goto out; + + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_DUTY, + SC27XX_DUTY_MASK, + (pattern[0].brightness << SC27XX_DUTY_SHIFT) | + SC27XX_MOD_MASK); + if (err) + goto out; + + /* Enable the LED breathing mode */ + err = regmap_update_bits(regmap, ctrl_base, + SC27XX_LED_RUN << ctrl_shift, + SC27XX_LED_RUN << ctrl_shift); + +out: + mutex_unlock(&leds->priv->lock); + + return err; +} + static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) { int i, err; @@ -140,6 +230,9 @@ static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) led->priv = priv; led->ldev.name = led->name; led->ldev.brightness_set_blocking = sc27xx_led_set; + led->ldev.pattern_set = sc27xx_led_pattern_set; + led->ldev.pattern_clear = sc27xx_led_pattern_clear; + led->ldev.default_trigger = "pattern"; err = devm_led_classdev_register(dev, &led->ldev); if (err) @@ -241,4 +334,5 @@ static int sc27xx_led_remove(struct platform_device *pdev) MODULE_DESCRIPTION("Spreadtrum SC27xx breathing light controller driver"); MODULE_AUTHOR("Xiaotong Lu "); +MODULE_AUTHOR("Baolin Wang "); MODULE_LICENSE("GPL v2");