From patchwork Fri Jan 17 23:40:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Manuel Fombuena X-Patchwork-Id: 858709 Received: from GBR01-CWX-obe.outbound.protection.outlook.com (mail-cwxgbr01olkn2023.outbound.protection.outlook.com [40.92.112.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D311B1DE8A0; Fri, 17 Jan 2025 23:40:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.92.112.23 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157243; cv=fail; b=E6rIwJyuLNZXUxg2M6Cn4VwDjXw3YiQJWuPSnp7x0/vbZGQoGgte1/F/B9O/WJuoglrfuJFcSKHKTJuXXkTmESHaOYM97qRfb9HBeHXKv0MIAHt5SRlCwZSeV5RnUvIhFOpFxVFNdkuLGGv/BB2eNaKckZl8tgmmwc5hVWXU8ls= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737157243; c=relaxed/simple; bh=D4K9r6e8+Sk1BS+2VGhIrg5v2AEBsDv5XXQuSlnTfiY=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=emuWfFYv3/rZaZ2iKrEYdX8w6Ier/LFbR5j/lUOwefLG+F8krJbmPd4VoxhszIrLdEM9YZIYK88s+WErTn0JxMQ8AeD3uD2aCnP9pYitjb4nDKofzMgF7s0aTmGB7wwumvUeOenkxppBTjZC6ood1veCtABuZc3KmwGgOclYWrE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com; spf=pass smtp.mailfrom=outlook.com; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b=syYHg4IS; arc=fail smtp.client-ip=40.92.112.23 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=outlook.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=outlook.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=outlook.com header.i=@outlook.com header.b="syYHg4IS" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cu8AqyX543K7dXIVlfYF13iOswLXullxrkYOhmTc7ZRCmhity/nrB5syjkBrm6SRUpfwVmHaRB9i6TJze53V1/1QnOxZWlEDQGiw58Vl6Baq1PYD9USaTiGgfgmk04+9DkrgTWg/CZAXEteLLBvFUUrpOusWCdnfdlaZtAwYzOQuS5yYdM5FIfGRSHQVZd5KcTh/7gPs/tQP3fmqQ3BbhvP4gHABWUVRW55curLVX0PL9FVRfx1d3gjCFc/4VrEGeBNs7FlyNWhKedJJnCa+MByroy0jVgJNJgXEp7+61by1dsPwEVUOvktVBu2HtB50Yi3ARQRj08H8j9+Lj1K6pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ogS6YfdqA8BdxG9LAhhchBsCc1A0frBaELQUTCigOQE=; b=cIJZcgXHm7n6bzs9O/LR8InCojqjTctkSWWzEHr80Jw9kIfO45nNC6J4+QUvTgpIb89vu9yo8Oosw9pFVsNC//SPP4a7L85s677TeY1ajy5JNbwtm/V1M9RJEu2RHugzr2SCUqHOtJs5Pv/f4B4BgUsansfG4zFHkafDMKRiEqMUY6GLVbdmqLu6LTgf868tKkKr+D8GQ4I3It6b3szruHBGamIYom4f3bLN0pXTQ0CJhF/axAPeCx3FscmWQU/jR7CKz5eI/M85x5g+8oH4+M+wFRr66/EGcf/QNYFSQMQ/C0Kg+DXdxWOOpxbMlq3NfqBAGPjv1TdwNVBZEqvvwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ogS6YfdqA8BdxG9LAhhchBsCc1A0frBaELQUTCigOQE=; b=syYHg4ISn/HJzDxnogfMmUf2N8PUAt5t2dRKGPvYU3cOm/THCxpMAtn7Xg8MmkL9K0K0LDpvTqdINpZXQvX2m/TnIoOofyzGjwoCICJXcztKhgxewbBMk/WgrziOP9RbK5vA8APuHZwc6qitEPVKUS6KY3W3/pKMn3rDDQeZaTSaKwYYDvZYWlL5IbUJBTquLGr6X5jt4W/djJxnM7K0oI9t1y8Ax6s9ZDsQlNHmbvomOEy8OW9CdszZewnt5mgjM/tWBtCvpfREcFUIv7w+ZFf5P7UEE+23R1h9CKe1CAklxu27SLvlAKJDDPH470UU8wkG+QKvocQ8l5Y/zpxETw== Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) by CWXP123MB4166.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:b4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.17; Fri, 17 Jan 2025 23:40:36 +0000 Received: from CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb]) by CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM ([fe80::c0fe:9ff5:51fd:3fdb%6]) with mapi id 15.20.8356.014; Fri, 17 Jan 2025 23:40:36 +0000 From: Manuel Fombuena To: pavel@ucw.cz, lee@kernel.org, corbet@lwn.net, linux-leds@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] leds: leds-st1202: spacing and proofreading editing Date: Fri, 17 Jan 2025 23:40:29 +0000 Message-ID: X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250117234034.670794-1-fombuena@outlook.com> References: <20250117234034.670794-1-fombuena@outlook.com> X-ClientProxiedBy: CWLP123CA0273.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1d5::20) To CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:160::13) X-Microsoft-Original-Message-ID: <20250117234034.670794-4-fombuena@outlook.com> Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB5473:EE_|CWXP123MB4166:EE_ X-MS-Office365-Filtering-Correlation-Id: f5e7cdbd-ffcd-4378-c258-08dd375057ac X-Microsoft-Antispam: BCL:0; ARA:14566002|8060799006|15080799006|5072599009|461199028|7092599003|6090799003|19110799003|440099028|3412199025|41001999003; X-Microsoft-Antispam-Message-Info: =?utf-8?q?RV7yPdotspndY1EHhVUBpD9LLG8a1Ds?= =?utf-8?q?AOW51M8jIzX27/rDsC2xhSkroXJ2tKPDA6P7QfACoPDCtg6aX/R5PUsDaVRLTwfnm?= =?utf-8?q?KRvWeb+WkquM1at41/qft0AxVg0Okxbu33IeuugIFe/m+136J80QbUb+PxVF2p25Q?= =?utf-8?q?2OjIw7v85VJ1KXnizO/eJp3QKLS9Go9FvGA73MLymc7cGkQJc0i9T9cwhWTaz+sNx?= =?utf-8?q?Y4nHNvpFRhNgisD0mzjtk0W24gGIJqU6TKURaWxy1bcdQrQUr51wohzcdZ7jMZ1/V?= =?utf-8?q?weurCGBszaT56gjueIw11lMQbPVrQJn6wl84vz2ll1vfLBXQmSm/4qnhFmQYkbqOB?= =?utf-8?q?+O7OKhjR8JWCzDc8iMiPRurHXKhC7BHPjYqLjr1hZiwpuNwAzQ4rnYfyPYSdOvdtd?= =?utf-8?q?N9g8nLMFH5BwosVif4TotY/+FUpUlsgcZEcbLiF/r22OQRUKqHBvCXXVcN0iVG3AS?= =?utf-8?q?kbEX7rfi2COdsIIWNnOm51Eb3SEborxOhZQ0U8heX29bK5+1O0urkDxNK0EcNAuET?= =?utf-8?q?yEWTyzb+IXRqjpFXpTFhDR0mOo9ubxkMUelAsO107zfyZT2Mmpn7z2fZ8yeUHxgIR?= =?utf-8?q?U5flmPwAaQonItHCxv8Y5RGNikZX0m6TzHRzZbVfkKboDZK5XJjWpzqG+wZn83s+w?= =?utf-8?q?HftFrNOpV+5U7DV0O+oklBSyhNFO3jjDW1hhu0yYZqy5JUCV9Ck8SQomrXp/hjxZj?= =?utf-8?q?KdadvnO3rzZ9AN57cjDz3IXmUrD2b5Lz6JHreB6RkcWqu9pO4ki3ljqQeR8v53dxh?= =?utf-8?q?QoM5F3jfAg56knFeAM5632ue9kGfm9Qnxx3nWAdnis0RirTOcJSH9CfOg/5zKT/UH?= =?utf-8?q?0uaxG8Afu8/hVVEPCMRSiMTkX3AKN7LZqAqDvwF/dXncGSDtnVb0k5uZGfwTh5C+m?= =?utf-8?q?5oWmwiOQMOst8MYBXij2DpQSbPVfhkdMjOFaiwo02sBl8kD5hATXYZ5zWV7xbxuxd?= =?utf-8?q?LL/7oVyIm249hrbhy9QUOF3Plkm0KFgf0zx/6QdnRCPeB2iXIKGfQ5ti92G+qbnvP?= =?utf-8?q?ntOoOHyNPEdNsDbK5U8XXjNMfLd29Ae4SxB110i3jfPJEAly5is3nDEwSK9yL56p5?= =?utf-8?q?OS9veC6XxjW00+kTOcDcsNxYoBXczHnGyOU9wQ=3D=3D?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?PCy7CPpTMyeTLHc6WavFiorRQLac?= =?utf-8?q?+3OUGkeQ4rWgAKYZv/EKbtZCPcbJlSYRS9n3LTjrBQQz2NTYFq06mzy8y9W65KzEU?= =?utf-8?q?vceIM4FA1IbUDRtpEl//31XneVR/bsUw9qsGzI7vVYVDhJ/r5jpKnTT15wFA5Pkmd?= =?utf-8?q?wgWQY7X4TNInazGwuan+/fUz22AeGY9K6SdDWZA/77RiWqST+EHrk1MZZAIvVFbQt?= =?utf-8?q?T2H22gd/z6r9CYpzOlXymY5GUZGoaEL60DUX22Nc0xN2ZNvM6TXxgrWOOV5VU8+3t?= =?utf-8?q?f+7A0gXle+lNunrHtYQLGDwMR2jHy9sjz6s1nE3ez/GGj12P8Y63eiQfc+Bf+D4M1?= =?utf-8?q?xYE3fqMeHiqAMt/dg6Y1DMuCSC0KnvncbysBVb8OahMpd55KUxTl1zw8RwUTdXQTm?= =?utf-8?q?lqV39OpjqcCVZ56c0dua4s/iZ3DC7mYRY2eHzAvHYitIuIlm9Lk7+yzoiShLl9/8/?= =?utf-8?q?FwYLg8mEbP/+1yKYIubaAPT17sO2G4z8b/ml67W6XJC8STrwBAqrjHNFk3Eb3tlVh?= =?utf-8?q?NGuJ3xB5Xa3FJMfvlHMlRMuA9VMTwGGZQ1pXikg/A9KjfyxlaEmgzYxyiQJh6tF2A?= =?utf-8?q?5rZnM4PuXtTMPJNF/JBoMuiw4OG1jeE0ZmUres7sZRtiEQHUr458owFxay+kWYlFy?= =?utf-8?q?m+N3I1tms2OBM5lGajHZD8a77nRe6xSjRKmr8T9kWu7f08CkUvZ6ID9VRNaeTUa46?= =?utf-8?q?8dGyw7AmPeM3D4L36RJ3hqCXb9PQ0Dc6NRkKXuSGVhmThQ/araPrTyRzp3Sd9Pqlp?= =?utf-8?q?yty+sNoRgfxmj7AVejDguxccGkOOmybJ92THFL24q9kBFdYNkwhb+OWMAE+UU4XvP?= =?utf-8?q?kgdKFovduQRwXel1IoSsXNKsDWW34/j9YkeNtocLKB7n/oULv1ryiWcDgbhhVBSXC?= =?utf-8?q?04cWqsnWFERXDKbWgW2XzJZG49+9fnysLePkqHBL8e8uoky5oaebXga6Zk5YWs67c?= =?utf-8?q?yMV+D8biZurVwDs5C8fiQessDgCoOWN6Tgott+2/7MuebWmafJCQ4SF3EfHk+cSZz?= =?utf-8?q?4z4BFq16OEAk6CEut/vxFOp1h/ymhYsZ+AggJzOpmKhtZnZ9MRRXTuxre/O1pojvW?= =?utf-8?q?nJUCac78YBwXkUBYaqlEoDUwkZhjsbPInsiT/QNG3zutKjmDu4JUPB2uOLCgissMB?= =?utf-8?q?cBj99gU+jScgiWfLIkJxL7uIxA0eNapC+R8u0sxYa0qlbdupseoJDqE2A3Zgy5QiH?= =?utf-8?q?2l3Y2Eo1P4xIwI00djbm+yMLtnyLMuZl48qeQUL3a4FJ1XiP2QuJvi7NowJM=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5e7cdbd-ffcd-4378-c258-08dd375057ac X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jan 2025 23:40:36.7556 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP123MB4166 Minor edits regarding use of spacing and proofreading. Signed-off-by: Manuel Fombuena --- drivers/leds/leds-st1202.c | 48 +++++++++++++++++++------------------- 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index 927874f20839..cb4797ea8f3a 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -16,27 +16,27 @@ #include #include -#define ST1202_CHAN_DISABLE_ALL 0x00 -#define ST1202_CHAN_ENABLE_HIGH 0x03 -#define ST1202_CHAN_ENABLE_LOW 0x02 -#define ST1202_CONFIG_REG 0x04 +#define ST1202_CHAN_DISABLE_ALL 0x00 +#define ST1202_CHAN_ENABLE_HIGH 0x03 +#define ST1202_CHAN_ENABLE_LOW 0x02 +#define ST1202_CONFIG_REG 0x04 /* PATS: Pattern sequence feature enable */ -#define ST1202_CONFIG_REG_PATS BIT(7) +#define ST1202_CONFIG_REG_PATS BIT(7) /* PATSR: Pattern sequence runs (self-clear when sequence is finished) */ -#define ST1202_CONFIG_REG_PATSR BIT(6) -#define ST1202_CONFIG_REG_SHFT BIT(3) -#define ST1202_DEV_ENABLE 0x01 -#define ST1202_DEV_ENABLE_ON BIT(0) -#define ST1202_DEV_ENABLE_RESET BIT(7) -#define ST1202_DEVICE_ID 0x00 -#define ST1202_ILED_REG0 0x09 -#define ST1202_MAX_LEDS 12 -#define ST1202_MAX_PATTERNS 8 -#define ST1202_MILLIS_PATTERN_DUR_MAX 5660 -#define ST1202_MILLIS_PATTERN_DUR_MIN 22 -#define ST1202_PATTERN_DUR 0x16 -#define ST1202_PATTERN_PWM 0x1E -#define ST1202_PATTERN_REP 0x15 +#define ST1202_CONFIG_REG_PATSR BIT(6) +#define ST1202_CONFIG_REG_SHFT BIT(3) +#define ST1202_DEV_ENABLE 0x01 +#define ST1202_DEV_ENABLE_ON BIT(0) +#define ST1202_DEV_ENABLE_RESET BIT(7) +#define ST1202_DEVICE_ID 0x00 +#define ST1202_ILED_REG0 0x09 +#define ST1202_MAX_LEDS 12 +#define ST1202_MAX_PATTERNS 8 +#define ST1202_MILLIS_PATTERN_DUR_MAX 5660 +#define ST1202_MILLIS_PATTERN_DUR_MIN 22 +#define ST1202_PATTERN_DUR 0x16 +#define ST1202_PATTERN_PWM 0x1E +#define ST1202_PATTERN_REP 0x15 struct st1202_led { struct fwnode_handle *fwnode; @@ -99,9 +99,9 @@ static int st1202_pwm_pattern_write(struct st1202_chip *chip, int led_num, value_h = (u8)(value >> 8); /* - * Datasheet: Register address low = 1Eh + 2*(xh) + 18h*(yh), - * where x is the channel number (led number) in hexadecimal (x = 00h .. 0Bh) - * and y is the pattern number in hexadecimal (y = 00h .. 07h) + * Datasheet: Register address low = 1Eh + 2*(xh) + 18h*(yh), + * where x is the channel number (led number) in hexadecimal (x = 00h .. 0Bh) + * and y is the pattern number in hexadecimal (y = 00h .. 07h) */ ret = st1202_write_reg(chip, (ST1202_PATTERN_PWM + (led_num * 2) + 0x18 * pattern), value_l); @@ -288,8 +288,8 @@ static int st1202_setup(struct st1202_chip *chip) guard(mutex)(&chip->lock); /* - * Once the supply voltage is applied, the LED1202 executes some internal checks, - * afterwords it stops the oscillator and puts the internal LDO in quiescent mode. + * Once the supply voltage is applied, the LED1202 executes some internal checks. + * Afterwards, it stops the oscillator and puts the internal LDO in quiescent mode. * To start the device, EN bit must be set inside the “Device Enable” register at * address 01h. As soon as EN is set, the LED1202 loads the adjustment parameters * from the internal non-volatile memory and performs an auto-calibration procedure