From patchwork Thu Sep 6 02:37:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "\(Exiting\) Baolin Wang" X-Patchwork-Id: 146062 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp68830ljw; Wed, 5 Sep 2018 19:38:25 -0700 (PDT) X-Google-Smtp-Source: ANB0VdZCckSvxL2ZHG3QEYBvvnIjSd4q56ZYNWqLm+Bctio8HRy+s00hI357zaZeW3Y/WJC+eLnU X-Received: by 2002:a63:731b:: with SMTP id o27-v6mr630673pgc.216.1536201505707; Wed, 05 Sep 2018 19:38:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1536201505; cv=none; d=google.com; s=arc-20160816; b=cDkxCLQjESGTFQnGkkfWhR9nTPJWUJ8zcuNQRTHIxsCnPXPNmAslzqNrzrB+YeiqgT 0rE5sYQkyWBic+u415Xdi01GeGVPi2hRDrcTIig0hN0G6ydO/V43yxGSOnsXyH6dHruI gmzoJVEwUbkbl5QeBmzcLF0T6XKTk7mC+jiwQ6dvgZCwao6qmNwEbBw4pDH0+Jut96vL /ZsoiZMFcoMOuGBVgaHK+b+FH64G+vmVH/G5mcBCFYAITHKvSMcv+VAtahStQe2wdAat zjLN1wMFyDEJX+f1C+b4qsS5c8T5VOAfMDw00QYCH7877nKs3xsLTgfMHWE9VA2WnxHd p6VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=gPboSrlXdIzLgvl4Chn/fhusL/z1wvAcqa5/SUBDf4s=; b=yCZCRd4Rx7IfLCNPvQTXk67nS9+Z7sPNnnlrkzx7tfcrn/K3KI+R+3jA8AS3Xvyfxf 7uSdtEpNppZx6/AJCNz8e/wz362eLh4SxACtcqHGFgwUhdl/K2aR+y4L7GXS4HcAi7he oN8sO5MgF2vh/8hP+Z82njPuL5k1D0638CoX+iNXAi/kh3luiYISWZv7JjGXfIjsmCZX h4sgHACRUmLddQeQrpRpi8l0dX2D0Zb0Yw/3FO4HAS+HyyD41SEjvg/mikWCL+tM/i7e SbwheC6rdL21Chw2DJnsRgtEC9VWjSFZhyyw8sqiaSJ/XCclEHAr6my0FkNI9MGaD2/R mxLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QpLBuSh4; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a31-v6si3762508pgm.114.2018.09.05.19.38.25; Wed, 05 Sep 2018 19:38:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=QpLBuSh4; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726252AbeIFHL2 (ORCPT + 1 other); Thu, 6 Sep 2018 03:11:28 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46023 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725781AbeIFHL2 (ORCPT ); Thu, 6 Sep 2018 03:11:28 -0400 Received: by mail-pf1-f193.google.com with SMTP id i26-v6so4453382pfo.12 for ; Wed, 05 Sep 2018 19:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gPboSrlXdIzLgvl4Chn/fhusL/z1wvAcqa5/SUBDf4s=; b=QpLBuSh4O6hCasgd+hnAb+X0EzDT5HMGMvA/Y22ATTftE36Isd2/rTATkgz1AndTg4 uk4v4a2KgNSZUf2imccGoNISgNz3LCOWuMbDsLlrweescfhaYpAuEoP47xPzmkFnpOib p+LQhtcjOrQPqsQsUivAvVJZ+IcOcxj80JR/A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gPboSrlXdIzLgvl4Chn/fhusL/z1wvAcqa5/SUBDf4s=; b=MfxxVEGVSvE7v+Zbk2NR4Lq1MmJh1V6QEcVxq5+3k0bU5w2yNKOCbQFPtnRWS8/3E0 sC/zIcTCNlGMbDTbBurfTf87ffHho+EJyQbTIre9F9YgAkjUFrFWRIjwTOryCJ8L//An tDfS9qN4Ke8SB2+/v3eAqg5g70o7tMSZwvp5E8ENomqECxrjvF7OvQ271WhcTfu8YWiY mwj7+XHvWJDlQRWP+r1wCnn93rTMez8pNpqid2xljWHEx5VYJX+6ctaL8yN/1CdeMGUc blrtFvaoC52DVueLYsZm3yZFcahii3WZdXVXGk5VKKgLWhUyNNmpFuyj7UTWs++q+XSv eRRg== X-Gm-Message-State: APzg51DSd7D8bAL4G8T3kKAW8r0XWsOoxilB6JWpcWPOViA73q0l8Fuv Lux8KjxO46/xErDDdSv5aydAeg== X-Received: by 2002:a63:e516:: with SMTP id r22-v6mr659805pgh.170.1536201503976; Wed, 05 Sep 2018 19:38:23 -0700 (PDT) Received: from baolinwangubtpc.spreadtrum.com ([117.18.48.102]) by smtp.gmail.com with ESMTPSA id h7-v6sm6637450pfd.155.2018.09.05.19.38.21 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 05 Sep 2018 19:38:23 -0700 (PDT) From: Baolin Wang To: jacek.anaszewski@gmail.com, pavel@ucw.cz Cc: rteysseyre@gmail.com, bjorn.andersson@linaro.org, baolin.wang@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller Date: Thu, 6 Sep 2018 10:37:52 +0800 Message-Id: <975a9570c75fb4469c0cef55cc9ed42266f933af.1536200860.git.baolin.wang@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <5a502ec29251c019ddad8f3314ab45fc0f6feaf7.1536200860.git.baolin.wang@linaro.org> References: <5a502ec29251c019ddad8f3314ab45fc0f6feaf7.1536200860.git.baolin.wang@linaro.org> Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org This patch implements the 'pattern_set'and 'pattern_clear' interfaces to support SC27XX LED breathing mode. Signed-off-by: Baolin Wang --- Changes from v9: - Optimize the ABI documentation file. - Update the brightness value in hardware pattern mode. Changes from v8: - Optimize the ABI documentation file. Changes from v7: - Add its own ABI documentation file. Changes from v6: - None. Changes from v5: - None. Changes from v4: - None. Changes from v3: - None. Changes from v2: - None. Changes from v1: - Remove pattern_get interface. --- .../ABI/testing/sysfs-class-led-driver-sc27xx | 22 +++++ drivers/leds/leds-sc27xx-bltc.c | 103 ++++++++++++++++++++ 2 files changed, 125 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-led-driver-sc27xx -- 1.7.9.5 Acked-by: Pavel Machek diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx new file mode 100644 index 0000000..d8056d5 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx @@ -0,0 +1,22 @@ +What: /sys/class/leds//hw_pattern +Date: September 2018 +KernelVersion: 4.20 +Description: + Specify a hardware pattern for the SC27XX LED. For the SC27XX + LED controller, it only supports 4 stages to make a single + hardware pattern, which is used to configure the rise time, + high time, fall time and low time for the breathing mode. + + For the breathing mode, the SC27XX LED only expects one brightness + for the high stage. To be compatible with the hardware pattern + format, we should set brightness as 0 for rise stage, fall + stage and low stage. + + Min stage duration: 125 ms + Max stage duration: 31875 ms + + Since the stage duration step is 125 ms, the duration must be + a multiplier of 125, like 125ms, 250ms, 375ms, 500ms ... 31875ms. + + Thus the format of the hardware pattern values should be: + "0 rise_duration brightness high_duration 0 fall_duration 0 low_duration". diff --git a/drivers/leds/leds-sc27xx-bltc.c b/drivers/leds/leds-sc27xx-bltc.c index 9d9b7aa..558a325 100644 --- a/drivers/leds/leds-sc27xx-bltc.c +++ b/drivers/leds/leds-sc27xx-bltc.c @@ -32,8 +32,15 @@ #define SC27XX_DUTY_MASK GENMASK(15, 0) #define SC27XX_MOD_MASK GENMASK(7, 0) +#define SC27XX_CURVE_SHIFT 8 +#define SC27XX_CURVE_L_MASK GENMASK(7, 0) +#define SC27XX_CURVE_H_MASK GENMASK(15, 8) + #define SC27XX_LEDS_OFFSET 0x10 #define SC27XX_LEDS_MAX 3 +#define SC27XX_LEDS_PATTERN_CNT 4 +/* Stage duration step, in milliseconds */ +#define SC27XX_LEDS_STEP 125 struct sc27xx_led { char name[LED_MAX_NAME_SIZE]; @@ -122,6 +129,98 @@ static int sc27xx_led_set(struct led_classdev *ldev, enum led_brightness value) return err; } +static int sc27xx_led_pattern_clear(struct led_classdev *ldev) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + struct regmap *regmap = leds->priv->regmap; + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + int err; + + mutex_lock(&leds->priv->lock); + + /* Reset the rise, high, fall and low time to zero. */ + regmap_write(regmap, base + SC27XX_LEDS_CURVE0, 0); + regmap_write(regmap, base + SC27XX_LEDS_CURVE1, 0); + + err = regmap_update_bits(regmap, ctrl_base, + (SC27XX_LED_RUN | SC27XX_LED_TYPE) << ctrl_shift, 0); + + ldev->brightness = LED_OFF; + + mutex_unlock(&leds->priv->lock); + + return err; +} + +static int sc27xx_led_pattern_set(struct led_classdev *ldev, + struct led_pattern *pattern, + int len, u32 repeat) +{ + struct sc27xx_led *leds = to_sc27xx_led(ldev); + u32 base = sc27xx_led_get_offset(leds); + u32 ctrl_base = leds->priv->base + SC27XX_LEDS_CTRL; + u8 ctrl_shift = SC27XX_CTRL_SHIFT * leds->line; + struct regmap *regmap = leds->priv->regmap; + int err; + + /* + * Must contain 4 tuples to configure the rise time, high time, fall + * time and low time to enable the breathing mode. + */ + if (len != SC27XX_LEDS_PATTERN_CNT) + return -EINVAL; + + mutex_lock(&leds->priv->lock); + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_L_MASK, + pattern[0].delta_t / SC27XX_LEDS_STEP); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_L_MASK, + pattern[1].delta_t / SC27XX_LEDS_STEP); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE0, + SC27XX_CURVE_H_MASK, + (pattern[2].delta_t / SC27XX_LEDS_STEP) << + SC27XX_CURVE_SHIFT); + if (err) + goto out; + + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_CURVE1, + SC27XX_CURVE_H_MASK, + (pattern[3].delta_t / SC27XX_LEDS_STEP) << + SC27XX_CURVE_SHIFT); + if (err) + goto out; + + err = regmap_update_bits(regmap, base + SC27XX_LEDS_DUTY, + SC27XX_DUTY_MASK, + (pattern[1].brightness << SC27XX_DUTY_SHIFT) | + SC27XX_MOD_MASK); + if (err) + goto out; + + /* Enable the LED breathing mode */ + err = regmap_update_bits(regmap, ctrl_base, + SC27XX_LED_RUN << ctrl_shift, + SC27XX_LED_RUN << ctrl_shift); + if (!err) + ldev->brightness = pattern[1].brightness; + +out: + mutex_unlock(&leds->priv->lock); + + return err; +} + static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) { int i, err; @@ -140,6 +239,9 @@ static int sc27xx_led_register(struct device *dev, struct sc27xx_led_priv *priv) led->priv = priv; led->ldev.name = led->name; led->ldev.brightness_set_blocking = sc27xx_led_set; + led->ldev.pattern_set = sc27xx_led_pattern_set; + led->ldev.pattern_clear = sc27xx_led_pattern_clear; + led->ldev.default_trigger = "pattern"; err = devm_led_classdev_register(dev, &led->ldev); if (err) @@ -241,4 +343,5 @@ static int sc27xx_led_remove(struct platform_device *pdev) MODULE_DESCRIPTION("Spreadtrum SC27xx breathing light controller driver"); MODULE_AUTHOR("Xiaotong Lu "); +MODULE_AUTHOR("Baolin Wang "); MODULE_LICENSE("GPL v2");