| Message ID | 20240201204421.16992-4-quic_amelende@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add QCOM PBS driver | expand |
On 01/02/2024 21:44, Anjelique Melendez wrote: > Add binding for the Qualcomm Programmable Boot Sequencer device. > > Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> How is it possible? This is v1, not a resend, and I never give review tags not in public. Best regards, Krzysztof
On 2/1/2024 11:29 PM, Krzysztof Kozlowski wrote: > On 01/02/2024 21:44, Anjelique Melendez wrote: >> Add binding for the Qualcomm Programmable Boot Sequencer device. >> >> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > How is it possible? This is v1, not a resend, and I never give review > tags not in public. > > Best regards, > Krzysztof > Sorry for the confusion, this patch was originally in this series: https://lore.kernel.org/all/20231221185838.28440-2-quic_amelende@quicinc.com/, where you gave your reviewed by tag in v3: https://lore.kernel.org/all/102328fa-5699-4731-d639-079bce8863a5@linaro.org/. This was separated into a new series since half of the original patches were already applied. I mentioned this in the cover letter but in future should I keep version the same as the original series? Thanks, Anjelique
On Fri, Feb 02, 2024 at 09:49:21AM -0800, Anjelique Melendez wrote: > > > On 2/1/2024 11:29 PM, Krzysztof Kozlowski wrote: > > On 01/02/2024 21:44, Anjelique Melendez wrote: > >> Add binding for the Qualcomm Programmable Boot Sequencer device. > >> > >> Signed-off-by: Anjelique Melendez <quic_amelende@quicinc.com> > >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > How is it possible? This is v1, not a resend, and I never give review > > tags not in public. > > > > Best regards, > > Krzysztof > > > Sorry for the confusion, this patch was originally in this series: > https://lore.kernel.org/all/20231221185838.28440-2-quic_amelende@quicinc.com/, > where you gave your reviewed by tag in v3: > https://lore.kernel.org/all/102328fa-5699-4731-d639-079bce8863a5@linaro.org/. > This was separated into a new series since half of the original > patches were already applied. I mentioned this in the cover > letter but in future should I keep version the same as the original > series? > Marking the patch(es) v9 makes it clear that they have been on the list already. This would be true either if you rebased v8 (and git dropped the applied patches from your series), or if you resubmitted some patch on it's own. Regards, Bjorn
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml new file mode 100644 index 000000000000..b502ca72266a --- /dev/null +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/soc/qcom/qcom,pbs.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Technologies, Inc. Programmable Boot Sequencer + +maintainers: + - Anjelique Melendez <quic_amelende@quicinc.com> + +description: | + The Qualcomm Technologies, Inc. Programmable Boot Sequencer (PBS) + supports triggering power up and power down sequences for clients + upon request. + +properties: + compatible: + items: + - enum: + - qcom,pmi632-pbs + - const: qcom,pbs + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/spmi/spmi.h> + + pmic@0 { + reg = <0x0 SPMI_USID>; + #address-cells = <1>; + #size-cells = <0>; + + pbs@7400 { + compatible = "qcom,pmi632-pbs", "qcom,pbs"; + reg = <0x7400>; + }; + };