From patchwork Thu Apr 20 18:10:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naresh Solanki X-Patchwork-Id: 675778 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33DCEC77B72 for ; Thu, 20 Apr 2023 18:10:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229458AbjDTSKz (ORCPT ); Thu, 20 Apr 2023 14:10:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229625AbjDTSKx (ORCPT ); Thu, 20 Apr 2023 14:10:53 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3B012715 for ; Thu, 20 Apr 2023 11:10:51 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id n43-20020a05600c502b00b003f17466a9c1so3475766wmr.2 for ; Thu, 20 Apr 2023 11:10:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1682014250; x=1684606250; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EN4wCZ9lkq1KnrA6HkR+5KfkKCmTmfRZgBHM2t8UIZA=; b=GzWJ7JXjs+y1FrFizQuoL8MZmH2Ob5rX+5n6oL/MGV8BMx0bXrh0cFIk4QYhnclA8N zLRolQlz3gjpmHJkLRPBQThFPBqBeIhnZdU2O/8DolDn2NY8Ue8Gw7VX5f8fHQmfVcMS SHm7flAMFwoQ1HO5Z1vAHYfzB2bckLlC26w8YlpyXihzqQ3P8q8oD+72teYl0iPcXfKc HQQ9JGZXKoFeJI5qf8GH6IdL4NAILnG040HzvEeLwaXElp2+sAwKOVzFFAzqMRg3udZh A2eHMvvmUFkyJ0EjDs9LRAAiJNMfYoa7CfrcHlcGkFgrwYoezkVIrUyBnPQfdkeYpXEJ xFWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682014250; x=1684606250; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EN4wCZ9lkq1KnrA6HkR+5KfkKCmTmfRZgBHM2t8UIZA=; b=iFKhfeD1MvNc7FN/trwK3zd0f+XVOBgTYCS1CRS0pdEKXu8fst9/Hcvzf2XiQIRnf8 +CKU1BkBLtqiBZYL5/ETI0cvMrEGEbxTD2mHQ2qfz4MFHE1vqFMfDCvopYqER5eh8uNf HNNFHUDwILMaeljv7UWGA2FbmyGPzZA5aOiSaP3nq2KjmIdiLHRb7y58cTMULHjwhuqz SPBBDhxclYMhqUz0f9lUZHL4C6ynqj9pm7f0lUjP+RExtF675YbekpdiYoBeV/6R7w7v 8a2l4Y2ebp6kwJpXEwAP1Pn29C68q2WL721Zm4tILI0SYP/C84LjFj6QD9vfMs5hEXfP COcg== X-Gm-Message-State: AAQBX9eiGjPd9IvOaD0bjVwIGsCfxYKdNYZCPtqiu9XAwOvRrmffvmaj cgVGQznc8IrPA51opCJPFtx0RQ== X-Google-Smtp-Source: AKy350YrQyP8uEtvQxSbmpXuI4pxTLko412mhNHqG9366balvbwHOc8YG9kk6QxOXLFbmIP2AZm3Gg== X-Received: by 2002:a1c:e917:0:b0:3f1:727d:77a4 with SMTP id q23-20020a1ce917000000b003f1727d77a4mr1886970wmc.39.1682014250156; Thu, 20 Apr 2023 11:10:50 -0700 (PDT) Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id l2-20020a05600c4f0200b003ee74c25f12sm6155490wmq.35.2023.04.20.11.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 11:10:49 -0700 (PDT) From: Naresh Solanki X-Google-Original-From: Naresh Solanki To: Pavel Machek , Lee Jones Cc: Patrick Rudolph , Naresh Solanki , linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org Subject: [PATCH v6] leds: max597x: Add support for max597x Date: Thu, 20 Apr 2023 20:10:42 +0200 Message-Id: <20230420181042.3553335-1-Naresh.Solanki@9elements.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org From: Patrick Rudolph max597x is hot swap controller with indicator LED support. This driver uses DT property to configure led during boot time & also provide the LED control in sysfs. DTS example: i2c { #address-cells = <1>; #size-cells = <0>; regulator@3a { compatible = "maxim,max5978"; reg = <0x3a>; vss1-supply = <&p3v3>; regulators { sw0_ref_0: sw0 { shunt-resistor-micro-ohms = <12000>; }; }; }; leds { #address-cells = <1>; #size-cells = <0>; led@0 { reg = <0>; label = "ssd0:green"; default-state = "on"; }; led@1 { reg = <1>; label = "ssd1:green"; default-state = "on"; }; }; }; Signed-off-by: Patrick Rudolph Signed-off-by: Naresh Solanki ... Change in V6: - Improve error handling in case of failure in LED setup Changes in V5: - Update commit message - Fix comments - Add necessary new line Changes in V4: - Remove unwanted preinitialise - Remove unneeded line breaks - Fix variable name to avoid confusion - Update module description to mention LED driver. Changes in V3: - Remove of_node_put as its handled by for loop - Print error if an LED fails to register. - Update driver name in Kconfig description - Remove unneeded variable assignment - Use devm_led_classdev_register to reget led Changes in V2: - Fix regmap update - Remove devm_kfree - Remove default-state - Add example dts in commit message - Fix whitespace in Kconfig - Fix comment --- drivers/leds/Kconfig | 11 +++ drivers/leds/Makefile | 1 + drivers/leds/leds-max597x.c | 133 ++++++++++++++++++++++++++++++++++++ 3 files changed, 145 insertions(+) create mode 100644 drivers/leds/leds-max597x.c base-commit: 9d8d0d98885abba451d7ffc4885236d14ead3c9a diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 9dbce09eabac..60004cb8c257 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -590,6 +590,17 @@ config LEDS_ADP5520 To compile this driver as a module, choose M here: the module will be called leds-adp5520. +config LEDS_MAX597X + tristate "LED Support for Maxim 597x" + depends on LEDS_CLASS + depends on MFD_MAX597X + help + This option enables support for the Maxim MAX5970 & MAX5978 smart + switch indication LEDs via the I2C bus. + + To compile this driver as a module, choose M here: the module will + be called leds-max597x. + config LEDS_MC13783 tristate "LED Support for MC13XXX PMIC" depends on LEDS_CLASS diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index d30395d11fd8..da1192e40268 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -53,6 +53,7 @@ obj-$(CONFIG_LEDS_LP8501) += leds-lp8501.o obj-$(CONFIG_LEDS_LP8788) += leds-lp8788.o obj-$(CONFIG_LEDS_LP8860) += leds-lp8860.o obj-$(CONFIG_LEDS_LT3593) += leds-lt3593.o +obj-$(CONFIG_LEDS_MAX597X) += leds-max597x.o obj-$(CONFIG_LEDS_MAX77650) += leds-max77650.o obj-$(CONFIG_LEDS_MAX8997) += leds-max8997.o obj-$(CONFIG_LEDS_MC13783) += leds-mc13783.o diff --git a/drivers/leds/leds-max597x.c b/drivers/leds/leds-max597x.c new file mode 100644 index 000000000000..8ba710d20bff --- /dev/null +++ b/drivers/leds/leds-max597x.c @@ -0,0 +1,133 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Device driver for leds in MAX5970 and MAX5978 IC + * + * Copyright (c) 2022 9elements GmbH + * + * Author: Patrick Rudolph + */ + +#include +#include +#include +#include +#include + +#define ldev_to_maxled(c) container_of(c, struct max597x_led, cdev) + +struct max597x_led { + struct device *dev; + struct regmap *regmap; + struct led_classdev cdev; + unsigned int index; +}; + +static int max597x_led_set_brightness(struct led_classdev *cdev, + enum led_brightness brightness) +{ + struct max597x_led *ddata = ldev_to_maxled(cdev); + int ret, val; + + if (!ddata->regmap) + return -ENODEV; + + /* Set/clear corresponding bit for given led index */ + val = !brightness ? BIT(ddata->index) : 0; + + ret = regmap_update_bits(ddata->regmap, MAX5970_REG_LED_FLASH, BIT(ddata->index), val); + if (ret < 0) + dev_err(cdev->dev, "failed to set brightness %d", ret); + + return ret; +} + +static int max597x_setup_led(struct max597x_led *ddata, struct regmap *regmap, + struct device_node *nc, u32 reg) +{ + int ret; + + if (of_property_read_string(nc, "label", &ddata->cdev.name)) + ddata->cdev.name = nc->name; + + ddata->cdev.max_brightness = 1; + ddata->cdev.brightness_set_blocking = max597x_led_set_brightness; + ddata->cdev.default_trigger = "none"; + + ret = devm_led_classdev_register(ddata->dev, &ddata->cdev); + if (ret) + dev_err(ddata->dev, "Error initializing LED %s", ddata->cdev.name); + + return ret; +} + +static int max597x_led_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct device_node *np = dev_of_node(dev->parent); + struct regmap *regmap; + struct device_node *led_node; + struct device_node *child; + struct max597x_led *ddata[MAX597X_NUM_LEDS]; + int ret = 0, i = 0; + bool leds_found = false; + + regmap = dev_get_regmap(pdev->dev.parent, NULL); + if (!regmap) + return -EPROBE_DEFER; + + led_node = of_get_child_by_name(np, "leds"); + if (!led_node) + return -ENODEV; + + for_each_available_child_of_node(led_node, child) { + u32 reg; + + if (of_property_read_u32(child, "reg", ®)) + continue; + + if (reg >= MAX597X_NUM_LEDS) { + dev_err(dev, "invalid LED (%u >= %d)\n", reg, MAX597X_NUM_LEDS); + continue; + } + + ddata[i] = devm_kzalloc(dev, sizeof(struct max597x_led), GFP_KERNEL); + if (!ddata[i]) { + ret = -ENOMEM; + goto exit; + } + + ddata[i]->index = reg; + ddata[i]->regmap = regmap; + ddata[i]->dev = dev; + + ret = max597x_setup_led(ddata[i], regmap, child, reg); + if (ret < 0) { + dev_err(dev, "Failed to initialize LED %u\n", reg); + goto exit; + } + i++; + leds_found = true; + } + + if (!leds_found) + return -ENODEV; + +exit: + if (ret < 0) + for (int j = 0; j < i; j++) + devm_led_classdev_unregister(dev, &ddata[j]->cdev); + + return ret; +} + +static struct platform_driver max597x_led_driver = { + .driver = { + .name = "max597x-led", + }, + .probe = max597x_led_probe, +}; + +module_platform_driver(max597x_led_driver); +MODULE_AUTHOR("Patrick Rudolph "); +MODULE_DESCRIPTION("MAX5970_hot-swap controller LED driver"); +MODULE_LICENSE("GPL");