From patchwork Mon Apr 11 19:24:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corentin Labbe X-Patchwork-Id: 559807 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BEB4C433F5 for ; Mon, 11 Apr 2022 19:24:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349501AbiDKT1F (ORCPT ); Mon, 11 Apr 2022 15:27:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239283AbiDKT1F (ORCPT ); Mon, 11 Apr 2022 15:27:05 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA354DF28 for ; Mon, 11 Apr 2022 12:24:48 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id e21so8002604wrc.8 for ; Mon, 11 Apr 2022 12:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dAY/HDr2OeDTCS6+sRG3x2tQWGxxS70z/3Rn/qr2aK8=; b=xHhS8pvte1T6tfxc46+ld57g/HMp/HtV6ELqazOcDyQWg58ef+5ighPb52lBAHJl/6 NNMNeECu/NZ4qUQ7+HT4BOGrotWvk0mN44tWDtDNiwHRj6CYa31eJSaQjxUUiqR16gKx H4oIbRSwUD0+NkYaoJBvZ97UsH/6ZoyIx+bFacXTdIIC8AbUMrTm1+bOU3Z02CZIWfma nueK2YyQAcoQ/unIBh/WFo+UJGpDV9W+nLOj9DX+fd+HG6+3tupdLQBVBqXWb3EutkrW MnxMhGuzuvAYkNdN5mqV5hPgLwnRgveZxb0RfD+JZrKynrBToKmjrOlxb8D6M2227Ecr bWYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dAY/HDr2OeDTCS6+sRG3x2tQWGxxS70z/3Rn/qr2aK8=; b=xJK+TQLVm3HRs0IWVctzpPMyxHzfciXUF67En9SSV0EL/ZzD2q0h1cEz5fERs/tj+2 qHlGdNkneD9Nq8KEiZU4R/hApmk4UZUfNai73RGqa73f6nse7YPhrPI82cJVblYDGmah 4rPqVkWH+jqK3w5Ifg3g5aBxB1N/sHV9nzC/hVr/IfvsA8RzfrDpuy19NS+Xsh6E6Oxi k4OtamFhd8+WZiDfsiyNyd4FRKIRpm/HTudzhL1r5EgcELQLDJftwiRUuXOfsrbfN3WE ewENW4E+vEeNyjqT2DVXHDRQA5NbT9MQwTZF+HFq6W5OFh16qAiYYeu1Q60h+2WSGivI tXUg== X-Gm-Message-State: AOAM531Byx0lTL0C3lEJBaMUDQyZPXhVpZDgEM7Ynxa3A8kYsz6sAzGY wpf8t4R9LraJ+NVKlKwy4emsZw== X-Google-Smtp-Source: ABdhPJwg+3g2Bo4WXSUK6cfl1Nnw8dm8b0XLkTInSMP4K3NvYIKMXpcaaV5U1NJ38Xnjh8HsC1Tw5w== X-Received: by 2002:adf:c547:0:b0:207:9abc:cfa1 with SMTP id s7-20020adfc547000000b002079abccfa1mr12648661wrf.390.1649705087372; Mon, 11 Apr 2022 12:24:47 -0700 (PDT) Received: from localhost.localdomain (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.googlemail.com with ESMTPSA id k13-20020a7bc40d000000b0038e9edf5e73sm725177wmi.3.2022.04.11.12.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 12:24:46 -0700 (PDT) From: Corentin Labbe To: krzysztof.kozlowski+dt@linaro.org, pavel@ucw.cz, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, Corentin Labbe , Rob Herring Subject: [PATCH v4] leds: remove ide-disk trigger Date: Mon, 11 Apr 2022 19:24:34 +0000 Message-Id: <20220411192434.3386384-1-clabbe@baylibre.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org No user of ide-disk remains, so remove this deprecated trigger. Only a few platforms used this and were fixed in 2016. Acked-by: Rob Herring Signed-off-by: Corentin Labbe --- Change since v1: - remove also DEFINE_LED_TRIGGER(ledtrig_ide) Changes since v2: - Added the fact that few platforms used this and it was fixed old ago. - Added Rob's ack Change since v3: - Rebase on top of latest next Documentation/devicetree/bindings/leds/common.yaml | 3 --- drivers/leds/trigger/ledtrig-disk.c | 4 ---- 2 files changed, 7 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml index 344a6492ba36..1d1f79238a32 100644 --- a/Documentation/devicetree/bindings/leds/common.yaml +++ b/Documentation/devicetree/bindings/leds/common.yaml @@ -91,9 +91,6 @@ properties: - disk-activity - disk-read - disk-write - # LED indicates IDE disk activity (deprecated), in new implementations - # use "disk-activity" - - ide-disk # LED flashes at a fixed, configurable rate - timer # LED alters the brightness for the specified duration with one software diff --git a/drivers/leds/trigger/ledtrig-disk.c b/drivers/leds/trigger/ledtrig-disk.c index 0741910785bb..0b7dfbd04273 100644 --- a/drivers/leds/trigger/ledtrig-disk.c +++ b/drivers/leds/trigger/ledtrig-disk.c @@ -16,7 +16,6 @@ DEFINE_LED_TRIGGER(ledtrig_disk); DEFINE_LED_TRIGGER(ledtrig_disk_read); DEFINE_LED_TRIGGER(ledtrig_disk_write); -DEFINE_LED_TRIGGER(ledtrig_ide); void ledtrig_disk_activity(bool write) { @@ -24,8 +23,6 @@ void ledtrig_disk_activity(bool write) led_trigger_blink_oneshot(ledtrig_disk, &blink_delay, &blink_delay, 0); - led_trigger_blink_oneshot(ledtrig_ide, - &blink_delay, &blink_delay, 0); if (write) led_trigger_blink_oneshot(ledtrig_disk_write, &blink_delay, &blink_delay, 0); @@ -40,7 +37,6 @@ static int __init ledtrig_disk_init(void) led_trigger_register_simple("disk-activity", &ledtrig_disk); led_trigger_register_simple("disk-read", &ledtrig_disk_read); led_trigger_register_simple("disk-write", &ledtrig_disk_write); - led_trigger_register_simple("ide-disk", &ledtrig_ide); return 0; }