From patchwork Mon Oct 28 18:36:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Murphy X-Patchwork-Id: 177966 Delivered-To: patch@linaro.org Received: by 2002:ac9:3c86:0:0:0:0:0 with SMTP id w6csp3418786ocf; Mon, 28 Oct 2019 11:39:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqzRmgcXxxppIc67MTZvuLHgRaji7lUYLRM3BYQcYOZ+ygQDy/Q+Y4TGwmg5VOkcQDO/kfX0 X-Received: by 2002:a17:906:1542:: with SMTP id c2mr17764845ejd.80.1572287947754; Mon, 28 Oct 2019 11:39:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572287947; cv=none; d=google.com; s=arc-20160816; b=hLYNYNKUWXNtBN7CLqpiF6lzA0a+To6q5os8kKa4VFi5h3/jVEWs2v/4oiwzpPytOb 9a/VrVqE7aMbNoEZnQ3VYWf60vdlNfqAMiErKPKfBSeDB4+kgWh5XFRLdkiVYlK/73Ny 4bAj2Ewc4bBNSiQ3B+zDmJj1tXljLSVUhi3hSG8sFpe2BWKiz71s861RkR5GptjxtaLu dNHgIiWfN87TGRQIJIov2mPt1VRF+cGiEZGn0rWzPaB6WxGzO7Lsj7Uur5S+c1Uyiy8t bFHlRyChhDKYrqg9W0p3l5xd3oQh4nw/VhT/SteM9hlOyuQaYG/rCmwm/Qhd8Luw/Lob uxeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CiO3hXAyFsuZm3cE8SXZzPxL1D+KaY4p9kZlHGgSu6M=; b=RNzfEVFhySU1ITapdRhKZS3BwpmBXcLNaYxUe0Z8hJnSJGXeHbcpn2FV9S6hng2J8c brfrb+CkgzlVfeYPGdVmhznWNaMRnqEPxkri9tretxg3/z42XwVzJqgJP1kW8eroOXN6 5yFB891qcBqK9oEMDiGwRRVafVdiNoEvo9hpxoy1+wUrsDb2LjzqnttV42iivsinvxgO 3ApiMbzSOd7aU5UK9j36EviAKT82K4X22XVIqYBH/Xd5rs9eWVpRcv9JXnjAtxfo5C8A l+kaTRCGZaFNaghYUQTqx3bn3WbFPo9Vd3D5k8m/6nIG/1s9T+c8E92K/C8ez8i4PG+1 j3+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="vG8+/kNd"; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a12si6263367ejp.425.2019.10.28.11.39.07; Mon, 28 Oct 2019 11:39:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b="vG8+/kNd"; spf=pass (google.com: best guess record for domain of linux-leds-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-leds-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728202AbfJ1SjH (ORCPT + 1 other); Mon, 28 Oct 2019 14:39:07 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:38676 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727034AbfJ1SjH (ORCPT ); Mon, 28 Oct 2019 14:39:07 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x9SId4fq017495; Mon, 28 Oct 2019 13:39:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1572287944; bh=CiO3hXAyFsuZm3cE8SXZzPxL1D+KaY4p9kZlHGgSu6M=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=vG8+/kNdu5gLrWQRaesP8Zzm2ONBqG9DU2T+h0L1SzGFSAChCLXdF+Ol5od8fKNcp +QmAtQ+ntN1Bkb2YHcLI6Kg7BCuwT1RThVpH4gqmZbE//cJUKHOpOLiqhQfxWZ1YIw Shp8ffYkv8GxCUbgTkJ0GAPaCjmmthY2vlxowDHY= Received: from DFLE108.ent.ti.com (dfle108.ent.ti.com [10.64.6.29]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id x9SId4GE098551; Mon, 28 Oct 2019 13:39:04 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 28 Oct 2019 13:38:52 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 28 Oct 2019 13:38:52 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x9SId4n4058699; Mon, 28 Oct 2019 13:39:04 -0500 From: Dan Murphy To: , CC: , , Dan Murphy Subject: [PATCH v15 19/19] leds: lp55xx-common: Remove extern from lp55xx-common header Date: Mon, 28 Oct 2019 13:36:29 -0500 Message-ID: <20191028183629.11779-20-dmurphy@ti.com> X-Mailer: git-send-email 2.22.0.214.g8dca754b1e In-Reply-To: <20191028183629.11779-1-dmurphy@ti.com> References: <20191028183629.11779-1-dmurphy@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org extern is implied and is not needed in the common header file. Remove the extern keyword and re-align the code. Signed-off-by: Dan Murphy --- drivers/leds/leds-lp55xx-common.h | 26 ++++++++++++-------------- 1 file changed, 12 insertions(+), 14 deletions(-) -- 2.22.0.214.g8dca754b1e diff --git a/drivers/leds/leds-lp55xx-common.h b/drivers/leds/leds-lp55xx-common.h index 18476051d3d2..051f8b33c601 100644 --- a/drivers/leds/leds-lp55xx-common.h +++ b/drivers/leds/leds-lp55xx-common.h @@ -183,29 +183,27 @@ struct lp55xx_led { }; /* register access */ -extern int lp55xx_write(struct lp55xx_chip *chip, u8 reg, u8 val); -extern int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val); -extern int lp55xx_update_bits(struct lp55xx_chip *chip, u8 reg, - u8 mask, u8 val); +int lp55xx_write(struct lp55xx_chip *chip, u8 reg, u8 val); +int lp55xx_read(struct lp55xx_chip *chip, u8 reg, u8 *val); +int lp55xx_update_bits(struct lp55xx_chip *chip, u8 reg, u8 mask, u8 val); /* external clock detection */ -extern bool lp55xx_is_extclk_used(struct lp55xx_chip *chip); +bool lp55xx_is_extclk_used(struct lp55xx_chip *chip); /* common device init/deinit functions */ -extern int lp55xx_init_device(struct lp55xx_chip *chip); -extern void lp55xx_deinit_device(struct lp55xx_chip *chip); +int lp55xx_init_device(struct lp55xx_chip *chip); +void lp55xx_deinit_device(struct lp55xx_chip *chip); /* common LED class device functions */ -extern int lp55xx_register_leds(struct lp55xx_led *led, - struct lp55xx_chip *chip); +int lp55xx_register_leds(struct lp55xx_led *led, struct lp55xx_chip *chip); /* common device attributes functions */ -extern int lp55xx_register_sysfs(struct lp55xx_chip *chip); -extern void lp55xx_unregister_sysfs(struct lp55xx_chip *chip); +int lp55xx_register_sysfs(struct lp55xx_chip *chip); +void lp55xx_unregister_sysfs(struct lp55xx_chip *chip); /* common device tree population function */ -extern struct lp55xx_platform_data -*lp55xx_of_populate_pdata(struct device *dev, struct device_node *np, - struct lp55xx_chip *chip); +struct lp55xx_platform_data *lp55xx_of_populate_pdata(struct device *dev, + struct device_node *np, + struct lp55xx_chip *chip); #endif /* _LEDS_LP55XX_COMMON_H */