From patchwork Wed Nov 28 04:38:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 13255 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 6244024259 for ; Wed, 28 Nov 2012 04:44:45 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 16D9FA192A0 for ; Wed, 28 Nov 2012 04:44:44 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id c10so7623273ieb.11 for ; Tue, 27 Nov 2012 20:44:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=1jcvNCS9STLVX7pI1+r1Erw9raWkdBUw0LeOijv+gLM=; b=gKEyr2kfqnXmPjI5VUtH93/aAimDIojcksFTR6h0g++zy7Ld9IM7Lf3R2ngtNy5tDC QOn3Kt5PEDPuVD6tus67XvnHDGnBnvq1U73AQSksq0hu5EgZOKWN6FkkCnXsTgM07HWd M7xZrI32rbAURVlpkPtcGK/88QquFNZPQ3fHxxky9z+qcSqKe0qAZkiudWySU89KCAHw t/U7gUkiWClXVx5szksjkuklhnWFOMAeUWOJTg6HnN0SF0AuuBHulVyfI+HfhXwP8nNN l0obNh7bkWwDD3BP2PYndzCi4Ma3BCUXPSaMZU77i1fN3wTHrt2gh+PhL49gjTYt8J41 woUg== Received: by 10.50.213.69 with SMTP id nq5mr20284115igc.70.1354077884534; Tue, 27 Nov 2012 20:44:44 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp587563igt; Tue, 27 Nov 2012 20:44:44 -0800 (PST) Received: by 10.66.88.102 with SMTP id bf6mr49186983pab.10.1354077883868; Tue, 27 Nov 2012 20:44:43 -0800 (PST) Received: from mail-pb0-f46.google.com (mail-pb0-f46.google.com [209.85.160.46]) by mx.google.com with ESMTPS id bd1si23210326pab.276.2012.11.27.20.44.43 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 27 Nov 2012 20:44:43 -0800 (PST) Received-SPF: neutral (google.com: 209.85.160.46 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.46; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.46 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f46.google.com with SMTP id wy7so9428204pbc.19 for ; Tue, 27 Nov 2012 20:44:43 -0800 (PST) Received: by 10.68.234.229 with SMTP id uh5mr54504071pbc.123.1354077883630; Tue, 27 Nov 2012 20:44:43 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id o10sm11831325paz.37.2012.11.27.20.44.40 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 27 Nov 2012 20:44:42 -0800 (PST) From: Sachin Kamat To: linux-leds@vger.kernel.org Cc: cooloney@gmail.com, rpurdie@rpsys.net, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 2/2] leds: leds-clevo-mail: Use pr_* instead of printks Date: Wed, 28 Nov 2012 10:08:10 +0530 Message-Id: <1354077490-22292-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1354077490-22292-1-git-send-email-sachin.kamat@linaro.org> References: <1354077490-22292-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQnU+LEeSZByI/qz1dnknTU14UQXr2GShRVzenlC0ZgFoiiYc3q5yN5v7icBG9qEmgS51sXW Silences checkpatch warnings related to the use of printks. Signed-off-by: Sachin Kamat --- drivers/leds/leds-clevo-mail.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/leds/leds-clevo-mail.c b/drivers/leds/leds-clevo-mail.c index e024b0b..4fd0493 100644 --- a/drivers/leds/leds-clevo-mail.c +++ b/drivers/leds/leds-clevo-mail.c @@ -1,3 +1,4 @@ +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt #include @@ -26,7 +27,7 @@ static struct platform_device *pdev; static int __init clevo_mail_led_dmi_callback(const struct dmi_system_id *id) { - printk(KERN_INFO KBUILD_MODNAME ": '%s' found\n", id->ident); + pr_info("'%s' found\n", id->ident); return 1; } @@ -135,8 +136,7 @@ static int clevo_mail_led_blink(struct led_classdev *led_cdev, status = 0; } else { - printk(KERN_DEBUG KBUILD_MODNAME - ": clevo_mail_led_blink(..., %lu, %lu)," + pr_debug("clevo_mail_led_blink(..., %lu, %lu)," " returning -EINVAL (unsupported)\n", *delay_on, *delay_off); } @@ -183,7 +183,7 @@ static int __init clevo_mail_led_init(void) count = dmi_check_system(clevo_mail_led_dmi_table); } else { count = 1; - printk(KERN_ERR KBUILD_MODNAME ": Skipping DMI detection. " + pr_err("Skipping DMI detection. " "If the driver works on your hardware please " "report model and the output of dmidecode in tracker " "at http://sourceforge.net/projects/clevo-mailled/\n"); @@ -197,8 +197,7 @@ static int __init clevo_mail_led_init(void) error = platform_driver_probe(&clevo_mail_led_driver, clevo_mail_led_probe); if (error) { - printk(KERN_ERR KBUILD_MODNAME - ": Can't probe platform driver\n"); + pr_err("Can't probe platform driver\n"); platform_device_unregister(pdev); } } else