From patchwork Mon Nov 26 04:09:36 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 13176 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 039D523E17 for ; Mon, 26 Nov 2012 04:16:42 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id A98D4A1834A for ; Mon, 26 Nov 2012 04:16:41 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id c10so4007790ieb.11 for ; Sun, 25 Nov 2012 20:16:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=L9SQIGxScOaSi7tsFxuf7UayP1nuVE52z/okIsiPGg8=; b=MZVb/CAcDReQvkGEF3nLbpdSVEFbCBZybsZL91Ha1CWLLvgK+vmfiGCg97aQqTTR1I B+SszmZM6p1ShoBY3B8wtHdhaSKh5NRKWFKz6Nbh/5kDg30JoUP2R4FHThBTWqc6sLiO SgcFG69uTGE1BWMVm5EGGi+CqJ5LBMXXOZcDuCZpPJpA+dAodF7j5P2XgZiGXDQnBJpL nEh9PZIHSl+/rnekYBZ/E4Lql3n+qheEBZMGRbfPyT7n5XJM7Kgmq0lYrrhEX/LkHGNL Tw1Lrzxj8K/hglMcL+LosV6mhwC08koKixHQBVocp+e93RaHt3Dcj9tJVYQLKCXMLLMf 8CMg== Received: by 10.50.186.199 with SMTP id fm7mr9595250igc.62.1353903401482; Sun, 25 Nov 2012 20:16:41 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp197708igt; Sun, 25 Nov 2012 20:16:41 -0800 (PST) Received: by 10.68.241.232 with SMTP id wl8mr33599933pbc.144.1353903400940; Sun, 25 Nov 2012 20:16:40 -0800 (PST) Received: from mail-pb0-f53.google.com (mail-pb0-f53.google.com [209.85.160.53]) by mx.google.com with ESMTPS id az5si17882595pbd.54.2012.11.25.20.16.40 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:16:40 -0800 (PST) Received-SPF: neutral (google.com: 209.85.160.53 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.53; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.53 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f53.google.com with SMTP id jt11so7252234pbb.12 for ; Sun, 25 Nov 2012 20:16:40 -0800 (PST) Received: by 10.68.130.197 with SMTP id og5mr33736491pbb.138.1353903400733; Sun, 25 Nov 2012 20:16:40 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id yi9sm8036353pbc.39.2012.11.25.20.16.37 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:16:40 -0800 (PST) From: Sachin Kamat To: linux-leds@vger.kernel.org Cc: cooloney@gmail.com, rpurdie@rpsys.net, patches@linaro.org, sachin.kamat@linaro.org Subject: [PATCH 08/16] leds: leds-gpio: Use dev_info instead of printk Date: Mon, 26 Nov 2012 09:39:36 +0530 Message-Id: <1353902984-10728-9-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353902984-10728-1-git-send-email-sachin.kamat@linaro.org> References: <1353902984-10728-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQnRaC2Q/DBA/rSSoGAJin4WboSfwUk/ea3X9J1t4KfEIDfTNpARNWUtzet67VZ/c1Awzh+F Fixes the following checkpatch warning: WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ... FILE: leds/leds-gpio.c:105: printk(KERN_INFO "Skipping unavailable LED gpio %d (%s)\n", Signed-off-by: Sachin Kamat --- drivers/leds/leds-gpio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c index 77e2e40..4f31792 100644 --- a/drivers/leds/leds-gpio.c +++ b/drivers/leds/leds-gpio.c @@ -102,7 +102,7 @@ static int __devinit create_gpio_led(const struct gpio_led *template, /* skip leds that aren't available */ if (!gpio_is_valid(template->gpio)) { - printk(KERN_INFO "Skipping unavailable LED gpio %d (%s)\n", + dev_info(parent, "Skipping unavailable LED gpio %d (%s)\n", template->gpio, template->name); return 0; }