From patchwork Mon Nov 26 04:09:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 13170 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 0359223E17 for ; Mon, 26 Nov 2012 04:16:22 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id B3CFBA192A4 for ; Mon, 26 Nov 2012 04:16:21 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id c10so4007790ieb.11 for ; Sun, 25 Nov 2012 20:16:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=jyK+aJMg7qRPbf8oHzA11NR2MTThofWFiDhj3o+aw5Y=; b=Ksl7MYGnZKxHKmrD+0FWKm706PEW5GCTWLZjJ3yAbCmkpbk3WuoK3FoNom4fd43MV7 df8xqfHShQd3Xb0S1tA+Qcl/bx5x5sQnA+9hBwYhGtfqjZDt6MLJvvc7XIQH2UvyQw31 Hm2e+ic5QnSmm1eyU4NP8/KQ1k0MFIQhBPmgQUcFFqqv5Cm+gUPGfUF6HzYAP4f4Tdc/ QHtPrxAhT8LUZ9rT0RmTluF4ifYwpnvKkdc0nwWqLvcD3qggbZ3tJ8F0mGed0YRNbBoY lFWnMEVJwnuqUgbQ1fX2F40dmVidClHatMKuLqlFX0GfDuFJjUKS13+z/qUuuz/GQ0Wq CO2g== Received: by 10.50.187.197 with SMTP id fu5mr9670490igc.70.1353903381455; Sun, 25 Nov 2012 20:16:21 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp197671igt; Sun, 25 Nov 2012 20:16:21 -0800 (PST) Received: by 10.69.1.1 with SMTP id bc1mr33968453pbd.102.1353903380890; Sun, 25 Nov 2012 20:16:20 -0800 (PST) Received: from mail-da0-f44.google.com (mail-da0-f44.google.com [209.85.210.44]) by mx.google.com with ESMTPS id o4si17328400paw.228.2012.11.25.20.16.20 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:16:20 -0800 (PST) Received-SPF: neutral (google.com: 209.85.210.44 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.210.44; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.44 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-da0-f44.google.com with SMTP id z20so1907405dae.3 for ; Sun, 25 Nov 2012 20:16:20 -0800 (PST) Received: by 10.66.75.232 with SMTP id f8mr29452931paw.23.1353903380649; Sun, 25 Nov 2012 20:16:20 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id yi9sm8036353pbc.39.2012.11.25.20.16.17 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:16:20 -0800 (PST) From: Sachin Kamat To: linux-leds@vger.kernel.org Cc: cooloney@gmail.com, rpurdie@rpsys.net, patches@linaro.org, sachin.kamat@linaro.org, Daniel Mack Subject: [PATCH 02/16] leds: leds-lt3593: use devm_gpio_request_one Date: Mon, 26 Nov 2012 09:39:30 +0530 Message-Id: <1353902984-10728-3-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353902984-10728-1-git-send-email-sachin.kamat@linaro.org> References: <1353902984-10728-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQlu6oaFEjqSVcuncTuAQDA5M83bDaawnQNjJj+XCQwfQnKjhTshjC6r8JrW3da77ZXx/LDS devm_gpio_request_one is device managed and makes error handling and cleanup simpler. Cc: Daniel Mack Signed-off-by: Sachin Kamat Acked-by: Daniel Mack --- drivers/leds/leds-lt3593.c | 11 +++-------- 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/leds/leds-lt3593.c b/drivers/leds/leds-lt3593.c index 17b710c..5ee6b8b 100644 --- a/drivers/leds/leds-lt3593.c +++ b/drivers/leds/leds-lt3593.c @@ -106,8 +106,8 @@ static int __devinit create_lt3593_led(const struct gpio_led *template, if (!template->retain_state_suspended) led_dat->cdev.flags |= LED_CORE_SUSPENDRESUME; - ret = gpio_request_one(template->gpio, GPIOF_DIR_OUT | state, - template->name); + ret = devm_gpio_request_one(parent, template->gpio, + GPIOF_DIR_OUT | state, template->name); if (ret < 0) return ret; @@ -115,16 +115,12 @@ static int __devinit create_lt3593_led(const struct gpio_led *template, ret = led_classdev_register(parent, &led_dat->cdev); if (ret < 0) - goto err; + return ret; printk(KERN_INFO "%s: registered LT3593 LED '%s' at GPIO %d\n", KBUILD_MODNAME, template->name, template->gpio); return 0; - -err: - gpio_free(led_dat->gpio); - return ret; } static void delete_lt3593_led(struct lt3593_led_data *led) @@ -134,7 +130,6 @@ static void delete_lt3593_led(struct lt3593_led_data *led) led_classdev_unregister(&led->cdev); cancel_work_sync(&led->work); - gpio_free(led->gpio); } static int __devinit lt3593_led_probe(struct platform_device *pdev)