From patchwork Mon Nov 26 04:09:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 13184 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 2490F23E17 for ; Mon, 26 Nov 2012 04:17:09 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id CA815A1834A for ; Mon, 26 Nov 2012 04:17:08 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id c10so4007790ieb.11 for ; Sun, 25 Nov 2012 20:17:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=sB3C/M7j/akPCH2r9vM+jZY0yC4CguhdjcBQLEFMKD4=; b=Gli3alkrdgaoyWxku//njvub0vlvGYxi/XYt1vf0Vru4vs5BzWwiqmNzEyz6pVrZlX HLtLejzHzrqXFNp7aencaqN1cxEMZl378Qh2+jnBRh+tFxBKxGCY44lXsPWBNwNIR7XY W/ulUy+ahWRTuwL0q1G5Bw/pOJcBuoFIC1XXDtVxO4nOOWUKj3/utoN9snJUfBFbMpFU LfD8T4TP4eA5n5MdD4PFPDHvOZui1SC3XqxkvOCoNYY1c777OyEQIxIBZl+OhX3Ap8Ya GA9YyFFcMoMbgETk/xaYpvbL+31pbqDeYTfZlp9d9sDs3EUObyqqUYqRvtXsRnvzBpSZ zAVQ== Received: by 10.50.152.137 with SMTP id uy9mr9627308igb.62.1353903428628; Sun, 25 Nov 2012 20:17:08 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp197770igt; Sun, 25 Nov 2012 20:17:08 -0800 (PST) Received: by 10.68.253.226 with SMTP id ad2mr33861737pbd.38.1353903428144; Sun, 25 Nov 2012 20:17:08 -0800 (PST) Received: from mail-pb0-f46.google.com (mail-pb0-f46.google.com [209.85.160.46]) by mx.google.com with ESMTPS id p7si17392380pay.32.2012.11.25.20.17.07 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:17:08 -0800 (PST) Received-SPF: neutral (google.com: 209.85.160.46 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.46; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.46 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f46.google.com with SMTP id wy7so7697826pbc.19 for ; Sun, 25 Nov 2012 20:17:07 -0800 (PST) Received: by 10.68.136.135 with SMTP id qa7mr33651923pbb.157.1353903427865; Sun, 25 Nov 2012 20:17:07 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id yi9sm8036353pbc.39.2012.11.25.20.17.05 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:17:07 -0800 (PST) From: Sachin Kamat To: linux-leds@vger.kernel.org Cc: cooloney@gmail.com, rpurdie@rpsys.net, patches@linaro.org, sachin.kamat@linaro.org Subject: [PATCH 16/16] leds: led-triggers: Fix checkpatch warnings Date: Mon, 26 Nov 2012 09:39:44 +0530 Message-Id: <1353902984-10728-17-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353902984-10728-1-git-send-email-sachin.kamat@linaro.org> References: <1353902984-10728-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQmjqR97EE0hz+7eblUqMPaJY7mjJyfkbGWabk4n+ihYYnB5PXLtE408f52jXQ4Zo+OLG+EE Fixes the following type of warnings: WARNING: Prefer netdev_warn(netdev, ... then dev_warn(dev, ... then pr_warn(... to printk(KERN_WARNING ... WARNING: quoted string split across lines While at it also fix a coding style issue w.r.t braces. Signed-off-by: Sachin Kamat --- drivers/leds/led-triggers.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c index a4fa4bf..3c972b2 100644 --- a/drivers/leds/led-triggers.c +++ b/drivers/leds/led-triggers.c @@ -313,13 +313,13 @@ void led_trigger_register_simple(const char *name, struct led_trigger **tp) if (err < 0) { kfree(trig); trig = NULL; - printk(KERN_WARNING "LED trigger %s failed to register" - " (%d)\n", name, err); + pr_warn("LED trigger %s failed to register (%d)\n", + name, err); } - } else - printk(KERN_WARNING "LED trigger %s failed to register" - " (no memory)\n", name); - + } else { + pr_warn("LED trigger %s failed to register (no memory)\n", + name); + } *tp = trig; } EXPORT_SYMBOL_GPL(led_trigger_register_simple);