From patchwork Mon Nov 26 04:09:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 13181 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id E6DB723E17 for ; Mon, 26 Nov 2012 04:16:59 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 99FABA1834A for ; Mon, 26 Nov 2012 04:16:59 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id c10so4007790ieb.11 for ; Sun, 25 Nov 2012 20:16:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=fFkf1spyqQ4aSNVipNSbJyQl7Y6dQ3IRlClieQjvLvs=; b=Ap1E5mQlqcHsPa3VTDlaNWQ6RbNhngsBYQNBDH8yMZFCpiDDFG37I4EZdN7Sk2bksr nbzAjAmOxyHIw1aWcQ9zh37Kbabs5TKUMqckJ4au0Fkzsxk90chGRiukelEqmugBQlXl E7Xs9EqQs3w5NYS3fJAJYVSLu7nFDItToQE5iofBXyCrxZwn5tNIitA7vGiHcKzFDjcI Wli5uJKRtlk4lKxoj/ujQTW3bsWt81NmDkDbQ1fZs8Id2vIAsrSTxCiusBGethDkHrvK Nboequ0nlOUrjnJ9oXc3ld8FvbHs/kgDzG/edUEKTg6kbfP1SO0p6n/Y9y6NYcVqq2SM fQ7Q== Received: by 10.50.91.195 with SMTP id cg3mr12400912igb.57.1353903419425; Sun, 25 Nov 2012 20:16:59 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp197743igt; Sun, 25 Nov 2012 20:16:59 -0800 (PST) Received: by 10.66.88.37 with SMTP id bd5mr29194868pab.75.1353903418905; Sun, 25 Nov 2012 20:16:58 -0800 (PST) Received: from mail-pb0-f46.google.com (mail-pb0-f46.google.com [209.85.160.46]) by mx.google.com with ESMTPS id h9si17324764paw.250.2012.11.25.20.16.58 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:16:58 -0800 (PST) Received-SPF: neutral (google.com: 209.85.160.46 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.46; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.46 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f46.google.com with SMTP id wy7so7624569pbc.5 for ; Sun, 25 Nov 2012 20:16:58 -0800 (PST) Received: by 10.66.78.231 with SMTP id e7mr29351103pax.44.1353903418683; Sun, 25 Nov 2012 20:16:58 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id yi9sm8036353pbc.39.2012.11.25.20.16.55 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:16:57 -0800 (PST) From: Sachin Kamat To: linux-leds@vger.kernel.org Cc: cooloney@gmail.com, rpurdie@rpsys.net, patches@linaro.org, sachin.kamat@linaro.org Subject: [PATCH 13/16] leds: leds-wm8350: Use dev_err instead of printk Date: Mon, 26 Nov 2012 09:39:41 +0530 Message-Id: <1353902984-10728-14-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353902984-10728-1-git-send-email-sachin.kamat@linaro.org> References: <1353902984-10728-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQkw37vx3ybEvrC9LT7GpWTTwuzhi73gGF83m+qlt5grKzuYM1Gcxn9CulY0+uWkDrgE6sY3 Fixes the following type of checkpatch warnings: WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: Sachin Kamat --- drivers/leds/leds-wm8350.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-wm8350.c b/drivers/leds/leds-wm8350.c index 88f23f8..ed15157 100644 --- a/drivers/leds/leds-wm8350.c +++ b/drivers/leds/leds-wm8350.c @@ -216,13 +216,13 @@ static int wm8350_led_probe(struct platform_device *pdev) isink = devm_regulator_get(&pdev->dev, "led_isink"); if (IS_ERR(isink)) { - printk(KERN_ERR "%s: can't get ISINK\n", __func__); + dev_err(&pdev->dev, "%s: can't get ISINK\n", __func__); return PTR_ERR(isink); } dcdc = devm_regulator_get(&pdev->dev, "led_vcc"); if (IS_ERR(dcdc)) { - printk(KERN_ERR "%s: can't get DCDC\n", __func__); + dev_err(&pdev->dev, "%s: can't get DCDC\n", __func__); return PTR_ERR(dcdc); }