| Message ID | 20241004-bcm63138-leds-v3-0-ba99a8e464b9@linaro.org |
|---|---|
| Headers | show |
| Series | leds: bcm63138: Add some new bindings and code | expand |
On 10/4/24 00:59, Linus Walleij wrote: > This adds code to optionally read the width of the shift register > chain from the device tree and use it to set up the register > controlling the shifter hardware. > > If the property is not present, the boot-time default is used so > existing device trees keep working as this is what they assume. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
On Fri, 04 Oct 2024 09:59:22 +0200, Linus Walleij wrote: > The BCM63138 family of serial LED controllers has a register > where we can set up bits for the shift registers. These are > the number of rounds the bits need to be shifted before all > bits have been shifted through the external shift registers. > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > ChangeLog v2->v3: > - Mention that HW defaults will be used if the shift > register property is missing. > ChangeLog v1->v2: > - Drop the $ref to u32 since the new property is suffixed > with "-bits" and thus get standard treatment. > --- > Documentation/devicetree/bindings/leds/leds-bcm63138.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
This brings over the few know-how items and little things I found about the BCMBCA LEDs in my previous duplicate driver. This was tested on the BCM6846-based Genexis XG6846B. The main addition is the ability to define the number shifting bits in the serial shift register which is necessary if the previous boot stages have not set up the hardware properly before. Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- Changes in v3: - Mention in the DT binding that hardware defaults will be used if the property is missing. - Link to v2: https://lore.kernel.org/r/20240928-bcm63138-leds-v2-0-f6aa4d4d6ef2@linaro.org Changes in v2: - Drop the u32 $ref in the schema, -bits is a standard suffix. - Fix algorithm for shift register configuration. - Fix spelling errors and numbering errors. - Link to v1: https://lore.kernel.org/r/20240920-bcm63138-leds-v1-0-c150871324a0@linaro.org --- Linus Walleij (4): dt-bindings: leds: bcm63138: Add shift register bits leds: bcm63138: Use scopes and guards leds: bcm63138: Handle shift register config leds: bcm63138: Add some register defines .../devicetree/bindings/leds/leds-bcm63138.yaml | 11 +++++++++ drivers/leds/blink/leds-bcm63138.c | 28 ++++++++++++---------- 2 files changed, 27 insertions(+), 12 deletions(-) --- base-commit: 5724faee6be4109d7a3168625357e4127f42b5d2 change-id: 20240920-bcm63138-leds-1bc5f41c47cd Best regards,