From patchwork Tue Sep 3 10:19:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Marek_Beh=C3=BAn?= X-Patchwork-Id: 825139 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 937EF2904 for ; Tue, 3 Sep 2024 10:19:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725358776; cv=none; b=Vm6erZO4fobmM1Hz/23l1Rbd+mH39412d5XkWE8N6/yG/WUoirP3ryCxHktKerzTcoZIOJL37pox7jqNkIS1/bPDftW9gsltx73/eThwB7Xu9Q27rhXlK+rpAhRqdt3bi3nJxNBXLPeWSsRtphyh4YrWoX5UWbtaKS2yMuSv//s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725358776; c=relaxed/simple; bh=zOl5UJC+OXlvlIIJzVEwApk7WtJxOv98Ox7oX7DxnF4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=nhBwyXwiyUtdbAdmLJutVJ4Ap9AaNQIg08W+VzahFJZSdkrKr67gXLxUMew4UJXT87g824koT7CvSi+PFP4WHFH7xNSqMBh23D/q+bA6bxd+TTzkSmdWGXsTZ1wd2Rnlc9gpJf4wQ6/L1MwrfopkNWcupXOMoE3MRub66HcEjVU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LTGKq8Jo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LTGKq8Jo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7637EC4CEC4; Tue, 3 Sep 2024 10:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725358776; bh=zOl5UJC+OXlvlIIJzVEwApk7WtJxOv98Ox7oX7DxnF4=; h=From:To:List-Id:Cc:Subject:Date:From; b=LTGKq8JoP+YyyTcGlGu61iCZW9Yeoldxa8gQzwxkCw6JENEFy9e5uhFydCRZ7lYOD R+ortx9yNk8Onace9hrQ7gz+q2zJetkfhyaeK+DHDMsj5RkOOZKWkt0VZkR2yzdlVd gR4KuUFmN35APHoQJoKrrEzg9nxHY3aN2xUo680oIXf59gsSl6QEtaxRbNll/WVRbz r6SPSuVwBAmP81b1AVfiZji6x2L9yVM7hbKwrRfkjEwyDFz3LOGlNO4CAIryyWRk5M 3YUgjCni0nvuxa9iiIK0mV5S1eBJEJ424hrGoqeTGrloJDmhqoO7urS+dVzmxs4SQV mfiSOs23BNbBQ== From: =?utf-8?q?Marek_Beh=C3=BAn?= To: Lee Jones Cc: Pavel Machek , linux-leds@vger.kernel.org, Arnd Bergmann , soc@kernel.org, Gregory CLEMENT , arm@kernel.org, Andy Shevchenko , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Andrew Lunn , Sebastian Hesselbarth , =?utf-8?q?Marek_Be?= =?utf-8?q?h=C3=BAn?= Subject: [PATCH leds v2 00/11] Turris Omnia LED driver changes Date: Tue, 3 Sep 2024 12:19:19 +0200 Message-ID: <20240903101930.16251-1-kabel@kernel.org> X-Mailer: git-send-email 2.44.2 Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hello Lee, this is v2 of Turris Omnia LED driver changes. v1 can be found at https://lore.kernel.org/linux-leds/20240902124104.14297-1-kabel@kernel.org/ This series is for 6.12, but it depends on changes that have been merged to 6.11-rc3. Your for-leds-next branch is based on 6.11-rc1, so it won't apply there. Changes since v1: - patch 2 does away also with i2c_master_send() call, in favor of omnia_cmd_write() - patch 5 was rewritten to not use devm_device_add_group() anymore, since this function was deprecated. Instead, the sysfs_put() call for the "brightness" node is done the first time the IRQ handler is called, instead of driver probe. - the changes were done with 100 columns limit in mind - added 3 more "cosmetic" patches Marek Marek Behún (11): turris-omnia-mcu-interface.h: Move command execution function to global header leds: turris-omnia: Use command execution functions from the MCU driver turris-omnia-mcu-interface.h: Add LED commands related definitions to global header leds: turris-omnia: Use global header for MCU command definitions leds: turris-omnia: Notify sysfs on MCU global LEDs brightness change platform: cznic: turris-omnia-mcu: Inform about missing LED panel brightness change interrupt feature leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU driver leds: turris-omnia: Use dev_err_probe() where appropriate leds: turris-omnia: Use uppercase first letter in all comments leds: turris-omnia: Use 100 columns in the rest of the code ARM: dts: turris-omnia: Add global LED brightness change interrupt .../dts/marvell/armada-385-turris-omnia.dts | 1 + drivers/leds/leds-turris-omnia.c | 283 +++++++----------- .../platform/cznic/turris-omnia-mcu-base.c | 3 + drivers/platform/cznic/turris-omnia-mcu.h | 130 -------- include/linux/turris-omnia-mcu-interface.h | 148 ++++++++- 5 files changed, 257 insertions(+), 308 deletions(-)