mbox series

[v5,0/3] auxdisplay: 7-segment LED display

Message ID 20240306235021.976083-1-chris.packham@alliedtelesis.co.nz
Headers show
Series auxdisplay: 7-segment LED display | expand

Message

Chris Packham March 6, 2024, 11:50 p.m. UTC 
This series adds a driver for a 7-segment LED display.

I think I've addressed all of Andy's feedback in this round. I haven't
heard from the ARM maintainers on any of the previous rounds. At Andy's
request I've dropped the USB LED change as it's not related. I can
submit the dts change separately if required, I've mostly been including
it so there is an in-tree user of the driver I'm adding.

Chris Packham (3):
  auxdisplay: Add 7-segment LED display driver
  dt-bindings: auxdisplay: Add bindings for generic 7-segment LED
  ARM: dts: marvell: Add 7-segment LED display on x530

 .../bindings/auxdisplay/gpio-7-segment.yaml   |  55 +++++++++
 .../boot/dts/marvell/armada-385-atl-x530.dts  |  13 +-
 drivers/auxdisplay/Kconfig                    |  11 ++
 drivers/auxdisplay/Makefile                   |   1 +
 drivers/auxdisplay/seg-led-gpio.c             | 112 ++++++++++++++++++
 5 files changed, 191 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/auxdisplay/gpio-7-segment.yaml
 create mode 100644 drivers/auxdisplay/seg-led-gpio.c

Comments

Andy Shevchenko March 7, 2024, 12:07 p.m. UTC | #1 
On Thu, Mar 07, 2024 at 12:50:18PM +1300, Chris Packham wrote:
> This series adds a driver for a 7-segment LED display.
> 
> I think I've addressed all of Andy's feedback in this round. I haven't
> heard from the ARM maintainers on any of the previous rounds. At Andy's
> request I've dropped the USB LED change as it's not related. I can
> submit the dts change separately if required, I've mostly been including
> it so there is an in-tree user of the driver I'm adding.

All LGTM, I need a Geert's Ack/Rb on the first one and DT maintainer on
the second. The third one I have no clue by heart who, but somebody related
should also give a tag.