| Message ID | 20230918161104.20860-1-kabel@kernel.org |
|---|---|
| Headers | show |
| Series | leds: turris-omnia: updates | expand |
On Mon, 18 Sep 2023 18:11:00 +0200, Marek Behún wrote: > I am sending version 4 of Turris Omnia's LED controller updates. > I tried to address the issues you mentioned: > - I made the omnia_cmd_read_raw() function to return the number of read > bytes on success > - I have renamed omnia_cmd_read() to omnia_cmd_read_u8() since it always > reads one byte. The function returns the read byte on success and > a negative errno on failure > - accordingly, I have renamed omnia_cmd_write() to omnia_cmd_write_u8(), > and made it so that it returns the number of written bytes on success > - the newly added comments now start with a capital letter > > [...] Applied, thanks! [1/4] leds: turris-omnia: do not use SMBUS calls commit: 2b423ec3d05b5b9f6e663e99d40314c011a23a41 [2/4] leds: turris-omnia: make set_brightness() more efficient commit: aa5799d8cf1958e1359023aa13842952c6fde267 [3/4] leds: turris-omnia: support HW controlled mode via private trigger commit: 276f5ece909ee04676c92d4a942354a75059d832 [4/4] leds: turris-omnia: add support for enabling/disabling HW gamma correction commit: d82d0db48329785d31e7fed3ead8429383c94127 -- Lee Jones [李琼斯]
Hello Lee, I am sending version 4 of Turris Omnia's LED controller updates. I tried to address the issues you mentioned: - I made the omnia_cmd_read_raw() function to return the number of read bytes on success - I have renamed omnia_cmd_read() to omnia_cmd_read_u8() since it always reads one byte. The function returns the read byte on success and a negative errno on failure - accordingly, I have renamed omnia_cmd_write() to omnia_cmd_write_u8(), and made it so that it returns the number of written bytes on success - the newly added comments now start with a capital letter Marek Marek Behún (4): leds: turris-omnia: do not use SMBUS calls leds: turris-omnia: make set_brightness() more efficient leds: turris-omnia: support HW controlled mode via private trigger leds: turris-omnia: add support for enabling/disabling HW gamma correction .../sysfs-class-led-driver-turris-omnia | 14 + drivers/leds/Kconfig | 1 + drivers/leds/leds-turris-omnia.c | 352 ++++++++++++++++-- 3 files changed, 329 insertions(+), 38 deletions(-)