| Message ID | 20230618-ktd202x-v1-0-fc182fefadd7@apitzsch.eu |
|---|---|
| Headers | show |
| Series | leds: Add a driver for KTD202x | expand |
On 18/06/2023 13:45, André Apitzsch wrote: > Document Kinetic KTD2026/2027 LED driver devicetree bindings. > > Signed-off-by: André Apitzsch <git@apitzsch.eu> > --- > .../devicetree/bindings/leds/leds-ktd202x.yaml | 164 +++++++++++++++++++++ > 1 file changed, 164 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml b/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml > new file mode 100644 > index 000000000000..9868d6f6f147 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml Filename matching compatible, so missing vendor prefix. Can be kinetic,ktd202x.yaml > @@ -0,0 +1,164 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/leds-ktd202x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kinetic KTD2026/7 RGB/White LED Driver Driver stands for Linux driver or for driving a LED? If the first, then drop. The rest looks good, so you just need to use proper filename. Best regards, Krzysztof
Am Sonntag, dem 18.06.2023 um 14:41 +0200 schrieb Krzysztof Kozlowski: > On 18/06/2023 13:45, André Apitzsch wrote: > > Document Kinetic KTD2026/2027 LED driver devicetree bindings. > > > > Signed-off-by: André Apitzsch <git@apitzsch.eu> > > --- > > .../devicetree/bindings/leds/leds-ktd202x.yaml | 164 > > +++++++++++++++++++++ > > 1 file changed, 164 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/leds/leds- > > ktd202x.yaml b/Documentation/devicetree/bindings/leds/leds- > > ktd202x.yaml > > new file mode 100644 > > index 000000000000..9868d6f6f147 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/leds/leds-ktd202x.yaml > > Filename matching compatible, so missing vendor prefix. Can be > kinetic,ktd202x.yaml Thank you for pointing this out. I'll use kinetic,ktd202x.yaml in the next version. > > > @@ -0,0 +1,164 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/leds/leds-ktd202x.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Kinetic KTD2026/7 RGB/White LED Driver > > Driver stands for Linux driver or for driving a LED? If the first, > then > drop. > It stands for driving a LED. > > The rest looks good, so you just need to use proper filename. > > Best regards, > Krzysztof > Best regards, André
Add the binding description and the corresponding driver for the Kinetic KTD2026 and KTD2027. Signed-off-by: André Apitzsch <git@apitzsch.eu> --- André Apitzsch (2): dt-bindings: leds: Add Kinetic KTD2026/2027 LED leds: add ktd202x driver .../devicetree/bindings/leds/leds-ktd202x.yaml | 164 ++++++ drivers/leds/rgb/Kconfig | 12 + drivers/leds/rgb/Makefile | 1 + drivers/leds/rgb/leds-ktd202x.c | 610 +++++++++++++++++++++ 4 files changed, 787 insertions(+) --- base-commit: f7efed9f38f886edb450041b82a6f15d663c98f8 change-id: 20230618-ktd202x-546b2a7d240b Best regards,